* [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes
@ 2021-06-30 17:43 Marek Behún
2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún
` (6 more replies)
0 siblings, 7 replies; 21+ messages in thread
From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw)
To: netdev, Andrew Lunn, Vivien Didelot
Cc: David S . Miller, Jakub Kicinski, Marek Behún
Hello,
here comes some fixes for the Topaz family (Marvell 88E6141 / 88E6341)
which I found out about when I compared the Topaz' operations
structure with that one of Peridot (6390).
Marek Behún (6):
net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz
net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz
net: dsa: mv88e6xxx: enable .rmu_disable() on Topaz
net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz
net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz
net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on
Topaz
drivers/net/dsa/mv88e6xxx/chip.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:02 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún ` (5 subsequent siblings) 6 siblings, 1 reply; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") introduced .port_set_policy() method with implementation for several models, but forgot to add Topaz, which can use the 6352 implementation. Use the 6352 implementation of .port_set_policy() on Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 961fa6b75cad..6bcee3e012d4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3583,6 +3583,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .port_set_speed_duplex = mv88e6341_port_set_speed_duplex, .port_max_speed_mode = mv88e6341_port_max_speed_mode, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood, @@ -4383,6 +4384,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .port_set_speed_duplex = mv88e6341_port_set_speed_duplex, .port_max_speed_mode = mv88e6341_port_max_speed_mode, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz 2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún @ 2021-06-30 20:02 ` Andrew Lunn 0 siblings, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:02 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:03PM +0200, Marek Behún wrote: > Commit f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") > introduced .port_set_policy() method with implementation for several > models, but forgot to add Topaz, which can use the 6352 implementation. > > Use the 6352 implementation of .port_set_policy() on Topaz. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:03 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún ` (4 subsequent siblings) 6 siblings, 1 reply; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") introduced wrong .stats_set_histogram() method for Topaz family. The Peridot method should be used instead. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6bcee3e012d4..b125d3227dbd 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3597,7 +3597,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .port_set_cmode = mv88e6341_port_set_cmode, .port_setup_message_port = mv88e6xxx_setup_message_port, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats, @@ -4398,7 +4398,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .port_set_cmode = mv88e6341_port_set_cmode, .port_setup_message_port = mv88e6xxx_setup_message_port, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz 2021-06-30 17:43 ` [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún @ 2021-06-30 20:03 ` Andrew Lunn 0 siblings, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:03 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:04PM +0200, Marek Behún wrote: > Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") > introduced wrong .stats_set_histogram() method for Topaz family. > > The Peridot method should be used instead. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() on Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún 2021-06-30 17:43 ` [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:07 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún ` (3 subsequent siblings) 6 siblings, 1 reply; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") introduced .rmu_disable() method with implementation for several models, but forgot to add Topaz, which can use the Peridot implementation. Use the Peridot implementation of .rmu_disable() on Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index b125d3227dbd..d4b05c10e5f2 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3607,6 +3607,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, @@ -4408,6 +4409,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() on Topaz 2021-06-30 17:43 ` [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún @ 2021-06-30 20:07 ` Andrew Lunn 0 siblings, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:07 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:05PM +0200, Marek Behún wrote: > Commit 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") > introduced .rmu_disable() method with implementation for several models, > but forgot to add Topaz, which can use the Peridot implementation. > > Use the Peridot implementation of .rmu_disable() on Topaz. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (2 preceding siblings ...) 2021-06-30 17:43 ` [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:08 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún ` (2 subsequent siblings) 6 siblings, 1 reply; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.") introduced ATU hash algorithm access via devlink, but did not enable it for Topaz. Enable this feature also for Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.") --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index d4b05c10e5f2..354ff0b84b7f 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3608,6 +3608,8 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, + .atu_set_hash = mv88e6165_g1_atu_set_hash, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, @@ -4410,6 +4412,8 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, + .atu_set_hash = mv88e6165_g1_atu_set_hash, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz 2021-06-30 17:43 ` [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún @ 2021-06-30 20:08 ` Andrew Lunn 0 siblings, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:08 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:06PM +0200, Marek Behún wrote: > Commit 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU > hash algorithm.") introduced ATU hash algorithm access via devlink, but > did not enable it for Topaz. > > Enable this feature also for Topaz. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (3 preceding siblings ...) 2021-06-30 17:43 ` [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:08 ` Andrew Lunn 2021-06-30 22:15 ` Marek Behún 2021-06-30 17:43 ` [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 6 siblings, 2 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added support for RX statistics on SerDes ports for Peridot. This same implementation is also valid for Topaz, but was not enabled at the time. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 354ff0b84b7f..1e95a0facbd4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3623,6 +3623,9 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .serdes_irq_enable = mv88e6390_serdes_irq_enable, .serdes_irq_status = mv88e6390_serdes_irq_status, .gpio_ops = &mv88e6352_gpio_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, }; @@ -4429,6 +4432,9 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .gpio_ops = &mv88e6352_gpio_ops, .avb_ops = &mv88e6390_avb_ops, .ptp_ops = &mv88e6352_ptp_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, }; -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz 2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún @ 2021-06-30 20:08 ` Andrew Lunn 2021-06-30 22:15 ` Marek Behún 1 sibling, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:08 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:07PM +0200, Marek Behún wrote: > Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added > support for RX statistics on SerDes ports for Peridot. > > This same implementation is also valid for Topaz, but was not enabled > at the time. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz 2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún 2021-06-30 20:08 ` Andrew Lunn @ 2021-06-30 22:15 ` Marek Behún 1 sibling, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:15 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot; +Cc: David S . Miller, Jakub Kicinski On Wed, 30 Jun 2021 19:43:07 +0200 Marek Behún <kabel@kernel.org> wrote: > Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added > support for RX statistics on SerDes ports for Peridot. > > This same implementation is also valid for Topaz, but was not enabled > at the time. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") I accidentally sent wrong version of this fix which won't work. There is another change needed which I applied to another branch while testing and then generated the patches from the branch where this change was missing. I am going to send v2 in a moment. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (4 preceding siblings ...) 2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún @ 2021-06-30 17:43 ` Marek Behún 2021-06-30 20:10 ` Andrew Lunn 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 6 siblings, 1 reply; 21+ messages in thread From: Marek Behún @ 2021-06-30 17:43 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d") added support for dumping SerDes PCS registers via ethtool -d for Peridot. The same implementation is also valid for Topaz, but was not enabled at the time. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d") --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 1e95a0facbd4..beb41572d04e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3626,6 +3626,8 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, .serdes_get_strings = mv88e6390_serdes_get_strings, .serdes_get_stats = mv88e6390_serdes_get_stats, + .serdes_get_regs_len = mv88e6390_serdes_get_regs_len, + .serdes_get_regs = mv88e6390_serdes_get_regs, .phylink_validate = mv88e6341_phylink_validate, }; @@ -4435,6 +4437,8 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, .serdes_get_strings = mv88e6390_serdes_get_strings, .serdes_get_stats = mv88e6390_serdes_get_stats, + .serdes_get_regs_len = mv88e6390_serdes_get_regs_len, + .serdes_get_regs = mv88e6390_serdes_get_regs, .phylink_validate = mv88e6341_phylink_validate, }; -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz 2021-06-30 17:43 ` [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún @ 2021-06-30 20:10 ` Andrew Lunn 0 siblings, 0 replies; 21+ messages in thread From: Andrew Lunn @ 2021-06-30 20:10 UTC (permalink / raw) To: Marek Behún; +Cc: netdev, Vivien Didelot, David S . Miller, Jakub Kicinski On Wed, Jun 30, 2021 at 07:43:08PM +0200, Marek Behún wrote: > Commit bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS > registers to ethtool -d") added support for dumping SerDes PCS registers > via ethtool -d for Peridot. > > The same implementation is also valid for Topaz, but was not > enabled at the time. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d") Reviewed-by: Andrew Lunn <andrew@lunn.ch> I actually think devlink regions will be better for this. But the ethtool code exists. Andrew ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (5 preceding siblings ...) 2021-06-30 17:43 ` [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún ` (5 more replies) 6 siblings, 6 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Hello, here comes some fixes for the Topaz family (Marvell 88E6141 / 88E6341) which I found out about when I compared the Topaz' operations structure with that one of Peridot (6390). This is v2. In v1, I accidentally sent patches generated from wrong branch and the 5th patch does not contain a necessary change in serdes.c. Changes from v1: - the fifth patch, "enable SerDes RX stats for Topaz", needs another change in serdes.c - Andrew's Reviewed-by to 1,2,3,4 and 6 Marek Behún (6): net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz net: dsa: mv88e6xxx: enable .rmu_disable() on Topaz net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz drivers/net/dsa/mv88e6xxx/chip.c | 22 ++++++++++++++++++++-- drivers/net/dsa/mv88e6xxx/serdes.c | 6 +++--- 2 files changed, 23 insertions(+), 5 deletions(-) -- 2.31.1 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún ` (4 subsequent siblings) 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") introduced .port_set_policy() method with implementation for several models, but forgot to add Topaz, which can use the 6352 implementation. Use the 6352 implementation of .port_set_policy() on Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 961fa6b75cad..6bcee3e012d4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3583,6 +3583,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .port_set_speed_duplex = mv88e6341_port_set_speed_duplex, .port_max_speed_mode = mv88e6341_port_max_speed_mode, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood, @@ -4383,6 +4384,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .port_set_speed_duplex = mv88e6341_port_set_speed_duplex, .port_max_speed_mode = mv88e6341_port_max_speed_mode, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH net v2 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 22:22 ` [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún ` (3 subsequent siblings) 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") introduced wrong .stats_set_histogram() method for Topaz family. The Peridot method should be used instead. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6bcee3e012d4..b125d3227dbd 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3597,7 +3597,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .port_set_cmode = mv88e6341_port_set_cmode, .port_setup_message_port = mv88e6xxx_setup_message_port, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats, @@ -4398,7 +4398,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .port_set_cmode = mv88e6341_port_set_cmode, .port_setup_message_port = mv88e6xxx_setup_message_port, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH net v2 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() on Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 22:22 ` [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún 2021-06-30 22:22 ` [PATCH net v2 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún ` (2 subsequent siblings) 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") introduced .rmu_disable() method with implementation for several models, but forgot to add Topaz, which can use the Peridot implementation. Use the Peridot implementation of .rmu_disable() on Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 9e5baf9b36367 ("net: dsa: mv88e6xxx: add RMU disable op") Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index b125d3227dbd..d4b05c10e5f2 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3607,6 +3607,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, @@ -4408,6 +4409,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH net v2 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (2 preceding siblings ...) 2021-06-30 22:22 ` [PATCH net v2 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún 2021-06-30 22:22 ` [PATCH net v2 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.") introduced ATU hash algorithm access via devlink, but did not enable it for Topaz. Enable this feature also for Topaz. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 23e8b470c7788 ("net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.") Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index d4b05c10e5f2..354ff0b84b7f 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3608,6 +3608,8 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, + .atu_set_hash = mv88e6165_g1_atu_set_hash, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, @@ -4410,6 +4412,8 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .pot_clear = mv88e6xxx_g2_pot_clear, .reset = mv88e6352_g1_reset, .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, + .atu_set_hash = mv88e6165_g1_atu_set_hash, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .serdes_power = mv88e6390_serdes_power, -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH net v2 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats for Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (3 preceding siblings ...) 2021-06-30 22:22 ` [PATCH net v2 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún @ 2021-06-30 22:22 ` Marek Behún 2021-06-30 22:22 ` [PATCH net v2 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") added support for RX statistics on SerDes ports for Peridot. This same implementation is also valid for Topaz, but was not enabled at the time. We need to use the generic .serdes_get_lane() method instead of the Peridot specific one in the stats methods so that on Topaz the proper one is used. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 0df952873636a ("mv88e6xxx: Add serdes Rx statistics") --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++++++ drivers/net/dsa/mv88e6xxx/serdes.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 354ff0b84b7f..1e95a0facbd4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3623,6 +3623,9 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .serdes_irq_enable = mv88e6390_serdes_irq_enable, .serdes_irq_status = mv88e6390_serdes_irq_status, .gpio_ops = &mv88e6352_gpio_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, }; @@ -4429,6 +4432,9 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .gpio_ops = &mv88e6352_gpio_ops, .avb_ops = &mv88e6390_avb_ops, .ptp_ops = &mv88e6352_ptp_ops, + .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, + .serdes_get_strings = mv88e6390_serdes_get_strings, + .serdes_get_stats = mv88e6390_serdes_get_stats, .phylink_validate = mv88e6341_phylink_validate, }; diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c index e4fbef81bc52..b1d46dd8eaab 100644 --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -722,7 +722,7 @@ static struct mv88e6390_serdes_hw_stat mv88e6390_serdes_hw_stats[] = { int mv88e6390_serdes_get_sset_count(struct mv88e6xxx_chip *chip, int port) { - if (mv88e6390_serdes_get_lane(chip, port) < 0) + if (mv88e6xxx_serdes_get_lane(chip, port) < 0) return 0; return ARRAY_SIZE(mv88e6390_serdes_hw_stats); @@ -734,7 +734,7 @@ int mv88e6390_serdes_get_strings(struct mv88e6xxx_chip *chip, struct mv88e6390_serdes_hw_stat *stat; int i; - if (mv88e6390_serdes_get_lane(chip, port) < 0) + if (mv88e6xxx_serdes_get_lane(chip, port) < 0) return 0; for (i = 0; i < ARRAY_SIZE(mv88e6390_serdes_hw_stats); i++) { @@ -770,7 +770,7 @@ int mv88e6390_serdes_get_stats(struct mv88e6xxx_chip *chip, int port, int lane; int i; - lane = mv88e6390_serdes_get_lane(chip, port); + lane = mv88e6xxx_serdes_get_lane(chip, port); if (lane < 0) return 0; -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH net v2 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún ` (4 preceding siblings ...) 2021-06-30 22:22 ` [PATCH net v2 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún @ 2021-06-30 22:22 ` Marek Behún 5 siblings, 0 replies; 21+ messages in thread From: Marek Behún @ 2021-06-30 22:22 UTC (permalink / raw) To: netdev, Andrew Lunn, Vivien Didelot Cc: David S . Miller, Jakub Kicinski, Marek Behún Commit bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d") added support for dumping SerDes PCS registers via ethtool -d for Peridot. The same implementation is also valid for Topaz, but was not enabled at the time. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d") Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 1e95a0facbd4..beb41572d04e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3626,6 +3626,8 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, .serdes_get_strings = mv88e6390_serdes_get_strings, .serdes_get_stats = mv88e6390_serdes_get_stats, + .serdes_get_regs_len = mv88e6390_serdes_get_regs_len, + .serdes_get_regs = mv88e6390_serdes_get_regs, .phylink_validate = mv88e6341_phylink_validate, }; @@ -4435,6 +4437,8 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .serdes_get_sset_count = mv88e6390_serdes_get_sset_count, .serdes_get_strings = mv88e6390_serdes_get_strings, .serdes_get_stats = mv88e6390_serdes_get_stats, + .serdes_get_regs_len = mv88e6390_serdes_get_regs_len, + .serdes_get_regs = mv88e6390_serdes_get_regs, .phylink_validate = mv88e6341_phylink_validate, }; -- 2.31.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-06-30 22:22 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún 2021-06-30 20:02 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún 2021-06-30 20:03 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún 2021-06-30 20:07 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún 2021-06-30 20:08 ` Andrew Lunn 2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún 2021-06-30 20:08 ` Andrew Lunn 2021-06-30 22:15 ` Marek Behún 2021-06-30 17:43 ` [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún 2021-06-30 20:10 ` Andrew Lunn 2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún 2021-06-30 22:22 ` [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún 2021-06-30 22:22 ` [PATCH net v2 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún 2021-06-30 22:22 ` [PATCH net v2 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún 2021-06-30 22:22 ` [PATCH net v2 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún 2021-06-30 22:22 ` [PATCH net v2 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún 2021-06-30 22:22 ` [PATCH net v2 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.