From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
airlied@linux.ie, daniel@ffwll.ch,
Alistair Popple <apopple@nvidia.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
bskeggs@redhat.com, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: nouveau: failed to initialise sync
Date: Wed, 14 Jul 2021 17:02:18 +0200 [thread overview]
Message-ID: <YO78eo/MNcPMYAgC@phenom.ffwll.local> (raw)
In-Reply-To: <8fd70eb5-7306-89a3-57f9-d633243c9df5@amd.com>
On Wed, Jul 14, 2021 at 03:02:21PM +0200, Christian König wrote:
> Am 14.07.21 um 14:56 schrieb Kirill A. Shutemov:
> > On Tue, Jul 06, 2021 at 08:58:37AM +0200, Christian König wrote:
> > > Hi guys,
> > >
> > > yes nouveau was using the same functionality for internal BOs without
> > > noticing it. This is fixes by the following commit:
> > >
> > > commit d098775ed44021293b1962dea61efb19297b8d02
> > > Author: Christian König <christian.koenig@amd.com>
> > > Date: Wed Jun 9 19:25:56 2021 +0200
> > >
> > > drm/nouveau: init the base GEM fields for internal BOs
> > >
> > > TTMs buffer objects are based on GEM objects for quite a while
> > > and rely on initializing those fields before initializing the TTM BO.
> > >
> > > Nouveau now doesn't init the GEM object for internally allocated BOs,
> > > so make sure that we at least initialize some necessary fields.
> > >
> > > Could be that the patch needs to be send to stable as well.
> > The regression is present in v5.14-rc1. Any idea when it will hit
> > upstream? I don't see it being applied to drm=next.
>
> Well that question needs to answer Dave or somebody else from the drm-misc
> maintainer team.
>
> This fix together with some others are already in drm-misc-next-fixes
> waiting to be pushed upstream, but it looks like that hasn't happened yet.
>
> Even Linus already pinged me where the fix for qxl got stuck.
Yeah there was some missed patches. drm-misc-fixes is now in drm-fixes,
and drm-misc-next-fixes is included in drm-misc-fixes, for which Thomas
will do a pull request on Thu so it will land in -rc2.
It should also now be in linux-next.
But yes somehow bugfixes got a bit lost during the merge window.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: airlied@linux.ie, nouveau@lists.freedesktop.org,
Alistair Popple <apopple@nvidia.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Corentin Labbe <clabbe.montjoie@gmail.com>,
bskeggs@redhat.com, daniel@ffwll.ch,
"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [Nouveau] nouveau: failed to initialise sync
Date: Wed, 14 Jul 2021 17:02:18 +0200 [thread overview]
Message-ID: <YO78eo/MNcPMYAgC@phenom.ffwll.local> (raw)
In-Reply-To: <8fd70eb5-7306-89a3-57f9-d633243c9df5@amd.com>
On Wed, Jul 14, 2021 at 03:02:21PM +0200, Christian König wrote:
> Am 14.07.21 um 14:56 schrieb Kirill A. Shutemov:
> > On Tue, Jul 06, 2021 at 08:58:37AM +0200, Christian König wrote:
> > > Hi guys,
> > >
> > > yes nouveau was using the same functionality for internal BOs without
> > > noticing it. This is fixes by the following commit:
> > >
> > > commit d098775ed44021293b1962dea61efb19297b8d02
> > > Author: Christian König <christian.koenig@amd.com>
> > > Date: Wed Jun 9 19:25:56 2021 +0200
> > >
> > > drm/nouveau: init the base GEM fields for internal BOs
> > >
> > > TTMs buffer objects are based on GEM objects for quite a while
> > > and rely on initializing those fields before initializing the TTM BO.
> > >
> > > Nouveau now doesn't init the GEM object for internally allocated BOs,
> > > so make sure that we at least initialize some necessary fields.
> > >
> > > Could be that the patch needs to be send to stable as well.
> > The regression is present in v5.14-rc1. Any idea when it will hit
> > upstream? I don't see it being applied to drm=next.
>
> Well that question needs to answer Dave or somebody else from the drm-misc
> maintainer team.
>
> This fix together with some others are already in drm-misc-next-fixes
> waiting to be pushed upstream, but it looks like that hasn't happened yet.
>
> Even Linus already pinged me where the fix for qxl got stuck.
Yeah there was some missed patches. drm-misc-fixes is now in drm-fixes,
and drm-misc-next-fixes is included in drm-misc-fixes, for which Thomas
will do a pull request on Thu so it will land in -rc2.
It should also now be in linux-next.
But yes somehow bugfixes got a bit lost during the merge window.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: airlied@linux.ie, nouveau@lists.freedesktop.org,
Alistair Popple <apopple@nvidia.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Corentin Labbe <clabbe.montjoie@gmail.com>,
bskeggs@redhat.com, "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: nouveau: failed to initialise sync
Date: Wed, 14 Jul 2021 17:02:18 +0200 [thread overview]
Message-ID: <YO78eo/MNcPMYAgC@phenom.ffwll.local> (raw)
In-Reply-To: <8fd70eb5-7306-89a3-57f9-d633243c9df5@amd.com>
On Wed, Jul 14, 2021 at 03:02:21PM +0200, Christian König wrote:
> Am 14.07.21 um 14:56 schrieb Kirill A. Shutemov:
> > On Tue, Jul 06, 2021 at 08:58:37AM +0200, Christian König wrote:
> > > Hi guys,
> > >
> > > yes nouveau was using the same functionality for internal BOs without
> > > noticing it. This is fixes by the following commit:
> > >
> > > commit d098775ed44021293b1962dea61efb19297b8d02
> > > Author: Christian König <christian.koenig@amd.com>
> > > Date: Wed Jun 9 19:25:56 2021 +0200
> > >
> > > drm/nouveau: init the base GEM fields for internal BOs
> > >
> > > TTMs buffer objects are based on GEM objects for quite a while
> > > and rely on initializing those fields before initializing the TTM BO.
> > >
> > > Nouveau now doesn't init the GEM object for internally allocated BOs,
> > > so make sure that we at least initialize some necessary fields.
> > >
> > > Could be that the patch needs to be send to stable as well.
> > The regression is present in v5.14-rc1. Any idea when it will hit
> > upstream? I don't see it being applied to drm=next.
>
> Well that question needs to answer Dave or somebody else from the drm-misc
> maintainer team.
>
> This fix together with some others are already in drm-misc-next-fixes
> waiting to be pushed upstream, but it looks like that hasn't happened yet.
>
> Even Linus already pinged me where the fix for qxl got stuck.
Yeah there was some missed patches. drm-misc-fixes is now in drm-fixes,
and drm-misc-next-fixes is included in drm-misc-fixes, for which Thomas
will do a pull request on Thu so it will land in -rc2.
It should also now be in linux-next.
But yes somehow bugfixes got a bit lost during the merge window.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-07-14 15:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 19:21 nouveau: failed to initialise sync Corentin Labbe
2021-07-03 19:21 ` [Nouveau] " Corentin Labbe
2021-07-06 2:44 ` Alistair Popple
2021-07-06 2:44 ` Alistair Popple
2021-07-06 2:44 ` [Nouveau] " Alistair Popple
2021-07-06 6:58 ` Christian König
2021-07-06 6:58 ` Christian König
2021-07-06 6:58 ` [Nouveau] " Christian König
2021-07-06 7:42 ` Alistair Popple
2021-07-06 7:42 ` Alistair Popple
2021-07-06 7:42 ` [Nouveau] " Alistair Popple
2021-07-14 12:56 ` Kirill A. Shutemov
2021-07-14 12:56 ` Kirill A. Shutemov
2021-07-14 12:56 ` [Nouveau] " Kirill A. Shutemov
2021-07-14 13:02 ` Christian König
2021-07-14 13:02 ` Christian König
2021-07-14 13:02 ` [Nouveau] " Christian König
2021-07-14 15:02 ` Daniel Vetter [this message]
2021-07-14 15:02 ` Daniel Vetter
2021-07-14 15:02 ` [Nouveau] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO78eo/MNcPMYAgC@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=apopple@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=clabbe.montjoie@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.