* [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
@ 2021-07-12 0:13 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2021-07-12 0:13 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Krishna Reddy, Joerg Roedel,
Will Deacon
Cc: linux-tegra, iommu, linux-kernel
Change debugfs directory name to "smmu", which is a much more obvious name
than the generic name of the memory controller device-tree node.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/iommu/tegra-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 0a281833f611..093c270b9245 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1141,7 +1141,7 @@ struct tegra_smmu *tegra_smmu_probe(struct device *dev,
tegra_smmu_ahb_enable();
- err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
+ err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
if (err)
return ERR_PTR(err);
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
@ 2021-07-12 0:13 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2021-07-12 0:13 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Krishna Reddy, Joerg Roedel,
Will Deacon
Cc: linux-tegra, iommu, linux-kernel
Change debugfs directory name to "smmu", which is a much more obvious name
than the generic name of the memory controller device-tree node.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/iommu/tegra-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 0a281833f611..093c270b9245 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1141,7 +1141,7 @@ struct tegra_smmu *tegra_smmu_probe(struct device *dev,
tegra_smmu_ahb_enable();
- err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
+ err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
if (err)
return ERR_PTR(err);
--
2.32.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
2021-07-12 0:13 ` Dmitry Osipenko
@ 2021-07-14 10:52 ` Joerg Roedel
-1 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2021-07-14 10:52 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Thierry Reding, Jonathan Hunter, Krishna Reddy, Will Deacon,
linux-tegra, iommu, linux-kernel
On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote:
> - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
> + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
Are you sure no one is relying on the old name so that this change
breaks ABI? Also this change means that there is always be only one SMMU
per system. Is that guaranteed too?
Regards,
Joerg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
@ 2021-07-14 10:52 ` Joerg Roedel
0 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2021-07-14 10:52 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: linux-kernel, iommu, Jonathan Hunter, Thierry Reding,
linux-tegra, Will Deacon
On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote:
> - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
> + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
Are you sure no one is relying on the old name so that this change
breaks ABI? Also this change means that there is always be only one SMMU
per system. Is that guaranteed too?
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
2021-07-14 10:52 ` Joerg Roedel
@ 2021-07-14 11:17 ` Dmitry Osipenko
-1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2021-07-14 11:17 UTC (permalink / raw)
To: Joerg Roedel
Cc: Thierry Reding, Jonathan Hunter, Krishna Reddy, Will Deacon,
linux-tegra, iommu, linux-kernel
14.07.2021 13:52, Joerg Roedel пишет:
> On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote:
>> - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
>> + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
>
> Are you sure no one is relying on the old name so that this change
> breaks ABI?
IIUC, Thierry and Jon have a testing suite that uses the old name, but
it shouldn't be a problem to support the new name in addition to the old
name since it's internal/private testing suite.
The reason I'm proposing this change is because it's not obvious where
the SMMU debug is located when you look at the debugfs directory, it
takes some effort to find it.
> Also this change means that there is always be only one SMMU
> per system. Is that guaranteed too?
A single SMMU is guaranteed here. Only latest Tegra SoCs have two SMMUs
and those are ARM SMMUs, while this is a legacy Tegra SMMU here.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
@ 2021-07-14 11:17 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2021-07-14 11:17 UTC (permalink / raw)
To: Joerg Roedel
Cc: linux-kernel, iommu, Jonathan Hunter, Thierry Reding,
linux-tegra, Will Deacon
14.07.2021 13:52, Joerg Roedel пишет:
> On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote:
>> - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
>> + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
>
> Are you sure no one is relying on the old name so that this change
> breaks ABI?
IIUC, Thierry and Jon have a testing suite that uses the old name, but
it shouldn't be a problem to support the new name in addition to the old
name since it's internal/private testing suite.
The reason I'm proposing this change is because it's not obvious where
the SMMU debug is located when you look at the debugfs directory, it
takes some effort to find it.
> Also this change means that there is always be only one SMMU
> per system. Is that guaranteed too?
A single SMMU is guaranteed here. Only latest Tegra SoCs have two SMMUs
and those are ARM SMMUs, while this is a legacy Tegra SMMU here.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-14 11:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 0:13 [PATCH v1] iommu/tegra-smmu: Change debugfs directory name Dmitry Osipenko
2021-07-12 0:13 ` Dmitry Osipenko
2021-07-14 10:52 ` Joerg Roedel
2021-07-14 10:52 ` Joerg Roedel
2021-07-14 11:17 ` Dmitry Osipenko
2021-07-14 11:17 ` Dmitry Osipenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.