All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Gruber <j4n6ru@gmail.com>
Cc: adilger.kernel@dilger.ca, trivial@kernel.org,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix comments and spaces to follow coding style
Date: Tue, 6 Jul 2021 15:20:21 -0400	[thread overview]
Message-ID: <YOSs9Qu1YpvPAP6v@mit.edu> (raw)
In-Reply-To: <20210706183900.310975-1-j4n6ru@gmail.com>

On Tue, Jul 06, 2021 at 08:39:00PM +0200, Jan Gruber wrote:
> This commit addresses two whitespace issues as well as
> instances of the following coding style issue regarding
> block comments, which were identified by checkpatch.pl:
> 
> "WARNING: Block comments use a trailing */ on a separate line"
> 
> The changes aim at making the code more pleasant to read
> and to eliminate warnings
> 
> Signed-off-by: Jan Gruber <j4n6ru@gmail.com>

Please don't send "checkpatch.pl --file" patches for the ext4 file
system; if you must, please focus on files in the drivers directory,
where they are more welcome.  If developers are making changes to a
file, fixing some checkpatch.pl whines is fine, but white-sapace only
changes just obfuscates "git blame" code archology, and so the costs
far outwieghs the costs.  "Fix" is also not the right verb to use.
For more information please see [1].

[1] https://gist.github.com/17twenty/8154928

If you are looking for subtantive ways of contributing to the ext4
file system, feel free to look at various syzbot warnings[2] and try
to figure out what is going on there.

[2] https://syzkaller.appspot.com/upstream

(In some cases, the syzbot complaint has already been fixed, and it's
just a matter of letting syzbot knoww that it has since been fixed by
a particular commit.  See [3] for more details.)

[3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md

Cheers,

						- Ted

  reply	other threads:[~2021-07-06 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:39 [PATCH] ext4: Fix comments and spaces to follow coding style Jan Gruber
2021-07-06 19:20 ` Theodore Ts'o [this message]
2021-07-07  5:25   ` Jan Gru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOSs9Qu1YpvPAP6v@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=j4n6ru@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.