All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0"
@ 2021-06-16 11:53 Zhenguo Zhao
  2021-06-24 12:58 ` Greg KH
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Zhenguo Zhao @ 2021-06-16 11:53 UTC (permalink / raw)
  To: zhenguo6858, gregkh, jirislaby; +Cc: linux-kernel

From: Zhenguo Zhao <zhenguo.zhao1@unisoc.com>

config "initiator=0",gsmld will receives dlci SABM/DISC control command
frame,as slaver,the CR bit value check should be 1.

if check "cr == 0",it will goto invalid,so it can't send UA response
frame and open slaver dlci.

Signed-off-by: Zhenguo Zhao <zhenguo.zhao1@unisoc.com>
---
 drivers/tty/n_gsm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 5fea02c..becca2c 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1779,7 +1779,7 @@ static void gsm_queue(struct gsm_mux *gsm)
 
 	switch (gsm->control) {
 	case SABM|PF:
-		if (cr == 0)
+		if (cr == 1)
 			goto invalid;
 		if (dlci == NULL)
 			dlci = gsm_dlci_alloc(gsm, address);
@@ -1793,7 +1793,7 @@ static void gsm_queue(struct gsm_mux *gsm)
 		}
 		break;
 	case DISC|PF:
-		if (cr == 0)
+		if (cr == 1)
 			goto invalid;
 		if (dlci == NULL || dlci->state == DLCI_CLOSED) {
 			gsm_response(gsm, address, DM);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-15  2:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 11:53 [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0" Zhenguo Zhao
2021-06-24 12:58 ` Greg KH
     [not found] ` <CAGGV+3LgLdohhYhH+qJTokeNU_WdV9oRNHMc9a_5YTTVA3U8ow@mail.gmail.com>
2021-07-07  6:08   ` 赵振国
2021-07-07  6:10   ` Greg KH
2021-07-07  6:12 ` 赵振国
2021-07-15  2:29   ` 赵振国

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.