* [PATCH] bluetooth: bcm203x: update the reference count of udev
@ 2021-07-24 18:20 Salah Triki
2021-07-25 6:37 ` Greg KH
2021-07-27 2:09 ` bluez.test.bot
0 siblings, 2 replies; 3+ messages in thread
From: Salah Triki @ 2021-07-24 18:20 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, gregkh
Cc: linux-bluetooth, linux-kernel
Use usb_get_dev() and usb_put_dev() in order to update the reference
count of udev.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/bluetooth/bcm203x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
index e667933c3d70..547d35425d70 100644
--- a/drivers/bluetooth/bcm203x.c
+++ b/drivers/bluetooth/bcm203x.c
@@ -166,7 +166,7 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
if (!data)
return -ENOMEM;
- data->udev = udev;
+ data->udev = usb_get_dev(udev);
data->state = BCM203X_LOAD_MINIDRV;
data->urb = usb_alloc_urb(0, GFP_KERNEL);
@@ -244,6 +244,8 @@ static void bcm203x_disconnect(struct usb_interface *intf)
usb_set_intfdata(intf, NULL);
+ usb_put_dev(data->udev);
+
usb_free_urb(data->urb);
kfree(data->fw_data);
kfree(data->buffer);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bluetooth: bcm203x: update the reference count of udev
2021-07-24 18:20 [PATCH] bluetooth: bcm203x: update the reference count of udev Salah Triki
@ 2021-07-25 6:37 ` Greg KH
2021-07-27 2:09 ` bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-07-25 6:37 UTC (permalink / raw)
To: Salah Triki
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
linux-bluetooth, linux-kernel
On Sat, Jul 24, 2021 at 07:20:54PM +0100, Salah Triki wrote:
> Use usb_get_dev() and usb_put_dev() in order to update the reference
> count of udev.
That says _what_ you are doing, but no reason as to _why_ this is being
done :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: bluetooth: bcm203x: update the reference count of udev
2021-07-24 18:20 [PATCH] bluetooth: bcm203x: update the reference count of udev Salah Triki
2021-07-25 6:37 ` Greg KH
@ 2021-07-27 2:09 ` bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-07-27 2:09 UTC (permalink / raw)
To: linux-bluetooth, salah.triki
[-- Attachment #1: Type: text/plain, Size: 2727 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=520691
---Test result---
Test Summary:
CheckPatch PASS 0.44 seconds
GitLint PASS 0.10 seconds
BuildKernel PASS 504.94 seconds
TestRunner: Setup PASS 333.35 seconds
TestRunner: l2cap-tester PASS 2.62 seconds
TestRunner: bnep-tester PASS 1.91 seconds
TestRunner: mgmt-tester PASS 30.57 seconds
TestRunner: rfcomm-tester PASS 2.10 seconds
TestRunner: sco-tester PASS 2.05 seconds
TestRunner: smp-tester FAIL 2.12 seconds
TestRunner: userchan-tester PASS 1.94 seconds
Details
##############################
Test: CheckPatch - PASS - 0.44 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS - 0.10 seconds
Run gitlint with rule in .gitlint
##############################
Test: BuildKernel - PASS - 504.94 seconds
Build Kernel with minimal configuration supports Bluetooth
##############################
Test: TestRunner: Setup - PASS - 333.35 seconds
Setup environment for running Test Runner
##############################
Test: TestRunner: l2cap-tester - PASS - 2.62 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: bnep-tester - PASS - 1.91 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: mgmt-tester - PASS - 30.57 seconds
Run test-runner with mgmt-tester
Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3
##############################
Test: TestRunner: rfcomm-tester - PASS - 2.10 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: sco-tester - PASS - 2.05 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: smp-tester - FAIL - 2.12 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0
Failed Test Cases
SMP Client - SC Request 2 Failed 0.020 seconds
##############################
Test: TestRunner: userchan-tester - PASS - 1.94 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44386 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3593 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 616863 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11713 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9948 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11741 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5489 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-27 2:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24 18:20 [PATCH] bluetooth: bcm203x: update the reference count of udev Salah Triki
2021-07-25 6:37 ` Greg KH
2021-07-27 2:09 ` bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.