Re: [PATCH net 1/4] sctp: validate from_addr_param return

From: Ben Hutchings <ben@decadent.org.uk>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	Ilja Van Sprundel <ivansprundel@ioactive.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Xin Long <lucien.xin@gmail.com>,
	carnil@debian.org
Subject: Re: [PATCH net 1/4] sctp: validate from_addr_param return
Date: Tue, 27 Jul 2021 04:20:22 +0200	[thread overview]
Message-ID: <YP9tZryTbUGaQQ+e@decadent.org.uk> (raw)
In-Reply-To: <a8a08b7fbb0bf76377e26584682c12dd82202d2e.1624904195.git.marcelo.leitner@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Mon, Jun 28, 2021 at 04:13:41PM -0300, Marcelo Ricardo Leitner wrote:
[...]
> @@ -1174,7 +1175,8 @@ static struct sctp_association *__sctp_rcv_asconf_lookup(
>  	if (unlikely(!af))
>  		return NULL;
>  
> -	af->from_addr_param(&paddr, param, peer_port, 0);
> +	if (af->from_addr_param(&paddr, param, peer_port, 0))
> +		return NULL;
>  
>  	return __sctp_lookup_association(net, laddr, &paddr, transportp);
>  }
[...]

This condition needs to be inverted, doesn't it?

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]