From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
Ilja Van Sprundel <ivansprundel@ioactive.com>,
Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
Xin Long <lucien.xin@gmail.com>,
carnil@debian.org
Subject: Re: [PATCH net 1/4] sctp: validate from_addr_param return
Date: Tue, 27 Jul 2021 12:10:22 -0300 [thread overview]
Message-ID: <YQAh3sAro23P8B77@horizon.localdomain> (raw)
In-Reply-To: <YP9tZryTbUGaQQ+e@decadent.org.uk>
On Tue, Jul 27, 2021 at 04:20:22AM +0200, Ben Hutchings wrote:
> On Mon, Jun 28, 2021 at 04:13:41PM -0300, Marcelo Ricardo Leitner wrote:
> [...]
> > @@ -1174,7 +1175,8 @@ static struct sctp_association *__sctp_rcv_asconf_lookup(
> > if (unlikely(!af))
> > return NULL;
> >
> > - af->from_addr_param(&paddr, param, peer_port, 0);
> > + if (af->from_addr_param(&paddr, param, peer_port, 0))
> > + return NULL;
> >
> > return __sctp_lookup_association(net, laddr, &paddr, transportp);
> > }
> [...]
>
> This condition needs to be inverted, doesn't it?
Right you are. I'll send a patch today.
Thanks,
Marcelo
next prev parent reply other threads:[~2021-07-27 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:13 [PATCH net 0/4] sctp: add some size validations Marcelo Ricardo Leitner
2021-06-28 19:13 ` [PATCH net 1/4] sctp: validate from_addr_param return Marcelo Ricardo Leitner
2021-07-27 2:20 ` Ben Hutchings
2021-07-27 15:10 ` Marcelo Ricardo Leitner [this message]
2021-06-28 19:13 ` [PATCH net 2/4] sctp: add size validation when walking chunks Marcelo Ricardo Leitner
2021-06-28 19:13 ` [PATCH net 3/4] sctp: validate chunk size in __rcv_asconf_lookup Marcelo Ricardo Leitner
2021-06-28 19:13 ` [PATCH net 4/4] sctp: add param size validation for SCTP_PARAM_SET_PRIMARY Marcelo Ricardo Leitner
2021-06-28 22:40 ` [PATCH net 0/4] sctp: add some size validations patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQAh3sAro23P8B77@horizon.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=ben@decadent.org.uk \
--cc=carnil@debian.org \
--cc=ivansprundel@ioactive.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.