From: Vivek Goyal <vgoyal@redhat.com> To: Jeffle Xu <jefflexu@linux.alibaba.com> Cc: stefanha@redhat.com, miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, bo.liu@linux.alibaba.com, joseph.qi@linux.alibaba.com Subject: Re: [PATCH v2 3/4] fuse: add per-file DAX flag Date: Mon, 19 Jul 2021 14:41:30 -0400 [thread overview] Message-ID: <YPXHWmiYXMNxxhf7@redhat.com> (raw) In-Reply-To: <20210716104753.74377-4-jefflexu@linux.alibaba.com> On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: > Add one flag for fuse_attr.flags indicating if DAX shall be enabled for > this file. > > When the per-file DAX flag changes for an *opened* file, the state of > the file won't be updated until this file is closed and reopened later. > > Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> [..] > diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h > index 36ed092227fa..90c9df10d37a 100644 > --- a/include/uapi/linux/fuse.h > +++ b/include/uapi/linux/fuse.h > @@ -184,6 +184,9 @@ > * > * 7.34 > * - add FUSE_SYNCFS > + * > + * 7.35 > + * - add FUSE_ATTR_DAX > */ > > #ifndef _LINUX_FUSE_H > @@ -449,8 +452,10 @@ struct fuse_file_lock { > * fuse_attr flags > * > * FUSE_ATTR_SUBMOUNT: Object is a submount root > + * FUSE_ATTR_DAX: Enable DAX for this file in per-file DAX mode > */ > #define FUSE_ATTR_SUBMOUNT (1 << 0) > +#define FUSE_ATTR_DAX (1 << 1) Generic fuse changes (addition of FUSE_ATTR_DAX) should probably in a separate patch. I am not clear on one thing. If we are planning to rely on persistent inode attr (FS_XFLAG_DAX as per Documentation/filesystems/dax.rst), then why fuse server needs to communicate the state of that attr using a flag? Can client directly query it? I am not sure where at these attrs stored and if fuse protocol currently supports it. What about flag STATX_ATTR_DAX. We probably should report that too in stat if we are using dax on the inode? Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: Jeffle Xu <jefflexu@linux.alibaba.com> Cc: miklos@szeredi.hu, virtualization@lists.linux-foundation.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, stefanha@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 3/4] fuse: add per-file DAX flag Date: Mon, 19 Jul 2021 14:41:30 -0400 [thread overview] Message-ID: <YPXHWmiYXMNxxhf7@redhat.com> (raw) In-Reply-To: <20210716104753.74377-4-jefflexu@linux.alibaba.com> On Fri, Jul 16, 2021 at 06:47:52PM +0800, Jeffle Xu wrote: > Add one flag for fuse_attr.flags indicating if DAX shall be enabled for > this file. > > When the per-file DAX flag changes for an *opened* file, the state of > the file won't be updated until this file is closed and reopened later. > > Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> [..] > diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h > index 36ed092227fa..90c9df10d37a 100644 > --- a/include/uapi/linux/fuse.h > +++ b/include/uapi/linux/fuse.h > @@ -184,6 +184,9 @@ > * > * 7.34 > * - add FUSE_SYNCFS > + * > + * 7.35 > + * - add FUSE_ATTR_DAX > */ > > #ifndef _LINUX_FUSE_H > @@ -449,8 +452,10 @@ struct fuse_file_lock { > * fuse_attr flags > * > * FUSE_ATTR_SUBMOUNT: Object is a submount root > + * FUSE_ATTR_DAX: Enable DAX for this file in per-file DAX mode > */ > #define FUSE_ATTR_SUBMOUNT (1 << 0) > +#define FUSE_ATTR_DAX (1 << 1) Generic fuse changes (addition of FUSE_ATTR_DAX) should probably in a separate patch. I am not clear on one thing. If we are planning to rely on persistent inode attr (FS_XFLAG_DAX as per Documentation/filesystems/dax.rst), then why fuse server needs to communicate the state of that attr using a flag? Can client directly query it? I am not sure where at these attrs stored and if fuse protocol currently supports it. What about flag STATX_ATTR_DAX. We probably should report that too in stat if we are using dax on the inode? Vivek _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-07-19 22:09 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-16 10:47 [PATCH v2 0/4] virtiofs,fuse: support per-file DAX Jeffle Xu 2021-07-16 10:47 ` Jeffle Xu 2021-07-16 10:47 ` [PATCH v2 1/4] fuse: add fuse_should_enable_dax() helper Jeffle Xu 2021-07-16 10:47 ` Jeffle Xu 2021-07-16 10:47 ` [PATCH v2 2/4] fuse: Make DAX mount option a tri-state Jeffle Xu 2021-07-16 10:47 ` Jeffle Xu 2021-07-19 18:02 ` Vivek Goyal 2021-07-19 18:02 ` Vivek Goyal 2021-07-20 5:54 ` JeffleXu 2021-07-20 5:54 ` JeffleXu 2021-07-16 10:47 ` [PATCH v2 3/4] fuse: add per-file DAX flag Jeffle Xu 2021-07-16 10:47 ` Jeffle Xu 2021-07-19 18:41 ` Vivek Goyal [this message] 2021-07-19 18:41 ` Vivek Goyal 2021-07-20 7:19 ` JeffleXu 2021-07-20 7:19 ` JeffleXu 2021-07-20 19:40 ` Vivek Goyal 2021-07-20 19:40 ` Vivek Goyal 2021-07-21 12:35 ` JeffleXu 2021-07-21 12:35 ` JeffleXu 2021-07-19 19:44 ` Vivek Goyal 2021-07-19 19:44 ` Vivek Goyal 2021-07-20 6:51 ` JeffleXu 2021-07-20 6:51 ` JeffleXu 2021-07-20 9:22 ` JeffleXu 2021-07-20 9:22 ` JeffleXu 2021-07-20 19:27 ` Vivek Goyal 2021-07-20 19:27 ` Vivek Goyal 2021-07-21 14:14 ` JeffleXu 2021-07-21 14:14 ` JeffleXu 2021-07-21 14:40 ` Vivek Goyal 2021-07-21 14:40 ` Vivek Goyal 2021-07-16 10:47 ` [PATCH v2 4/4] fuse: support changing per-file DAX flag inside guest Jeffle Xu 2021-07-16 10:47 ` Jeffle Xu 2021-07-19 19:54 ` Vivek Goyal 2021-07-19 19:54 ` Vivek Goyal 2021-07-19 21:30 ` [PATCH v2 0/4] virtiofs,fuse: support per-file DAX Vivek Goyal 2021-07-19 21:30 ` Vivek Goyal 2021-07-20 5:25 ` JeffleXu 2021-07-20 5:25 ` JeffleXu 2021-07-20 19:18 ` Vivek Goyal 2021-07-20 19:18 ` Vivek Goyal 2021-07-21 12:32 ` JeffleXu 2021-07-21 12:32 ` JeffleXu 2021-07-21 12:48 ` Vivek Goyal 2021-07-21 12:48 ` Vivek Goyal 2021-07-21 14:42 ` Vivek Goyal 2021-07-21 14:42 ` Vivek Goyal 2021-08-04 6:51 ` JeffleXu 2021-08-04 6:51 ` JeffleXu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YPXHWmiYXMNxxhf7@redhat.com \ --to=vgoyal@redhat.com \ --cc=bo.liu@linux.alibaba.com \ --cc=jefflexu@linux.alibaba.com \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.