From: Boqun Feng <boqun.feng@gmail.com> To: Marc Zyngier <maz@kernel.org> Cc: "Bjorn Helgaas" <bhelgaas@google.com>, "Arnd Bergmann" <arnd@arndb.de>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "K. Y. Srinivasan" <kys@microsoft.com>, "Haiyang Zhang" <haiyangz@microsoft.com>, "Stephen Hemminger" <sthemmin@microsoft.com>, "Wei Liu" <wei.liu@kernel.org>, "Dexuan Cui" <decui@microsoft.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, "Sunil Muthuswamy" <sunilmut@microsoft.com>, "Mike Rapoport" <rppt@kernel.org> Subject: Re: [RFC v5 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Date: Tue, 20 Jul 2021 22:59:41 +0800 [thread overview] Message-ID: <YPbk3Ya20z1PDn2H@boqun-archlinux> (raw) In-Reply-To: <87v95582zh.wl-maz@kernel.org> On Tue, Jul 20, 2021 at 03:38:26PM +0100, Marc Zyngier wrote: > On Tue, 20 Jul 2021 14:44:29 +0100, > Boqun Feng <boqun.feng@gmail.com> wrote: > > > > Now we have everything we need, just provide a proper sysdata type for > > the bus to use on ARM64 and everything else works. > > > > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > > --- > > drivers/pci/controller/pci-hyperv.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > > index e6276aaa4659..62dbe98d1fe1 100644 > > --- a/drivers/pci/controller/pci-hyperv.c > > +++ b/drivers/pci/controller/pci-hyperv.c > > @@ -40,6 +40,7 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > #include <linux/pci.h> > > +#include <linux/pci-ecam.h> > > #include <linux/delay.h> > > #include <linux/semaphore.h> > > #include <linux/irqdomain.h> > > @@ -448,7 +449,11 @@ enum hv_pcibus_state { > > }; > > > > struct hv_pcibus_device { > > +#ifdef CONFIG_X86 > > struct pci_sysdata sysdata; > > +#elif defined(CONFIG_ARM64) > > + struct pci_config_window sysdata; > > +#endif > > Am I the only one who find this rather odd? Nothing ever populates > this data structure on arm64, and its only purpose seems to serve as > an anchor to retrieve the hbus via container_of(). > This field will also be used as the ->sysdata of pci_bus and pci_host_bridge, and some of the PCI core code touches. Although I made this field as all zeroed and make sure PCI core can handle (patch #4). > If that's indeed the case, I'd rather see an arch-specific to_hbus() > helper that uses another (preexisting) field as the anchor for arm64. > I did a quick look, but I didn't find another field works: the field needs to be placed inside hv_pcibus_device and the address can be retrieved via pci_bus. I'm open to any suggestion in case that I missed something. Regards, Boqun > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Boqun Feng <boqun.feng@gmail.com> To: Marc Zyngier <maz@kernel.org> Cc: "Bjorn Helgaas" <bhelgaas@google.com>, "Arnd Bergmann" <arnd@arndb.de>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "K. Y. Srinivasan" <kys@microsoft.com>, "Haiyang Zhang" <haiyangz@microsoft.com>, "Stephen Hemminger" <sthemmin@microsoft.com>, "Wei Liu" <wei.liu@kernel.org>, "Dexuan Cui" <decui@microsoft.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, "Sunil Muthuswamy" <sunilmut@microsoft.com>, "Mike Rapoport" <rppt@kernel.org> Subject: Re: [RFC v5 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Date: Tue, 20 Jul 2021 22:59:41 +0800 [thread overview] Message-ID: <YPbk3Ya20z1PDn2H@boqun-archlinux> (raw) In-Reply-To: <87v95582zh.wl-maz@kernel.org> On Tue, Jul 20, 2021 at 03:38:26PM +0100, Marc Zyngier wrote: > On Tue, 20 Jul 2021 14:44:29 +0100, > Boqun Feng <boqun.feng@gmail.com> wrote: > > > > Now we have everything we need, just provide a proper sysdata type for > > the bus to use on ARM64 and everything else works. > > > > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > > --- > > drivers/pci/controller/pci-hyperv.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > > index e6276aaa4659..62dbe98d1fe1 100644 > > --- a/drivers/pci/controller/pci-hyperv.c > > +++ b/drivers/pci/controller/pci-hyperv.c > > @@ -40,6 +40,7 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > #include <linux/pci.h> > > +#include <linux/pci-ecam.h> > > #include <linux/delay.h> > > #include <linux/semaphore.h> > > #include <linux/irqdomain.h> > > @@ -448,7 +449,11 @@ enum hv_pcibus_state { > > }; > > > > struct hv_pcibus_device { > > +#ifdef CONFIG_X86 > > struct pci_sysdata sysdata; > > +#elif defined(CONFIG_ARM64) > > + struct pci_config_window sysdata; > > +#endif > > Am I the only one who find this rather odd? Nothing ever populates > this data structure on arm64, and its only purpose seems to serve as > an anchor to retrieve the hbus via container_of(). > This field will also be used as the ->sysdata of pci_bus and pci_host_bridge, and some of the PCI core code touches. Although I made this field as all zeroed and make sure PCI core can handle (patch #4). > If that's indeed the case, I'd rather see an arch-specific to_hbus() > helper that uses another (preexisting) field as the anchor for arm64. > I did a quick look, but I didn't find another field works: the field needs to be placed inside hv_pcibus_device and the address can be retrieved via pci_bus. I'm open to any suggestion in case that I missed something. Regards, Boqun > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-20 15:12 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-20 13:44 [RFC v5 0/8] PCI: hv: Support host bridge probing on ARM64 Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 1/8] PCI: Introduce domain_nr in pci_host_bridge Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 22:49 ` Bjorn Helgaas 2021-07-20 22:49 ` Bjorn Helgaas 2021-07-21 0:57 ` Boqun Feng 2021-07-21 0:57 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 2/8] PCI: Support populating MSI domains of root buses via bridges Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 3/8] arm64: PCI: Restructure pcibios_root_bridge_prepare() Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 4/8] arm64: PCI: Support root bridge preparation for Hyper-V Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 5/8] PCI: hv: Generify PCI probing Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 6/8] PCI: hv: Set ->domain_nr of pci_host_bridge at probing time Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 7/8] PCI: hv: Set up MSI domain at bridge " Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 13:44 ` [RFC v5 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Boqun Feng 2021-07-20 13:44 ` Boqun Feng 2021-07-20 14:38 ` Marc Zyngier 2021-07-20 14:38 ` Marc Zyngier 2021-07-20 14:59 ` Boqun Feng [this message] 2021-07-20 14:59 ` Boqun Feng 2021-07-20 15:53 ` Marc Zyngier 2021-07-20 15:53 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YPbk3Ya20z1PDn2H@boqun-archlinux \ --to=boqun.feng@gmail.com \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=catalin.marinas@arm.com \ --cc=decui@microsoft.com \ --cc=haiyangz@microsoft.com \ --cc=kw@linux.com \ --cc=kys@microsoft.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=rppt@kernel.org \ --cc=sthemmin@microsoft.com \ --cc=sunilmut@microsoft.com \ --cc=wei.liu@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.