[PATCH] tty: n_gsm: delete CLD command frame as requester

[PATCH] tty: n_gsm: delete CLD command frame as requester

[Zhenguo Zhao]

From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>

as initiator,it may be send CLD conmmand ,as requester,there is
no need to send the CLD control frame,it will cause redundant data.

Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
---
 drivers/tty/n_gsm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 5fea02c..eecbc76 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2043,9 +2043,11 @@ static int gsm_disconnect(struct gsm_mux *gsm)
 
 	/* In theory disconnecting DLCI 0 is sufficient but for some
 	   modems this is apparently not the case. */
-	gc = gsm_control_send(gsm, CMD_CLD, NULL, 0);
-	if (gc)
-		gsm_control_wait(gsm, gc);
+	if (gsm->initiator) {
+		gc = gsm_control_send(gsm, CMD_CLD, NULL, 0);
+		if (gc)
+			gsm_control_wait(gsm, gc);
+	}
 
 	del_timer_sync(&gsm->t2_timer);
 	/* Now we are sure T2 has stopped */
-- 
1.9.1

Re: [PATCH] tty: n_gsm: delete CLD command frame as requester

[Greg KH]

On Thu, Jul 01, 2021 at 01:58:05PM +0800, Zhenguo Zhao wrote:
> From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
> 
> as initiator,it may be send CLD conmmand ,as requester,there is
> no need to send the CLD control frame,it will cause redundant data.

Same issue here.

And please make this a patch series, properly numbered, so we can track
them all together.

thanks,

greg k-h