* [PATCH] soundwire: cadence: Remove ret variable from sdw_cdns_irq()
@ 2021-07-14 1:55 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-07-14 1:55 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, gregkh, srinivas.kandagatla,
rander.wang, pierre-louis.bossart, sanyog.r.kale, bard.liao
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The ret is not used in the interrupt handler, it is just returned without
any condition or change.
We can return the IRQ_HANDLED directly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 25950422b085..9a9b6110e763 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -822,7 +822,6 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id)
{
struct sdw_cdns *cdns = dev_id;
u32 int_status;
- int ret = IRQ_HANDLED;
/* Check if the link is up */
if (!cdns->link_up)
@@ -900,7 +899,7 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id)
}
cdns_writel(cdns, CDNS_MCP_INTSTAT, int_status);
- return ret;
+ return IRQ_HANDLED;
}
EXPORT_SYMBOL(sdw_cdns_irq);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soundwire: cadence: Remove ret variable from sdw_cdns_irq()
@ 2021-07-14 1:55 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-07-14 1:55 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, gregkh, pierre-louis.bossart, linux-kernel,
sanyog.r.kale, rander.wang, bard.liao
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The ret is not used in the interrupt handler, it is just returned without
any condition or change.
We can return the IRQ_HANDLED directly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 25950422b085..9a9b6110e763 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -822,7 +822,6 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id)
{
struct sdw_cdns *cdns = dev_id;
u32 int_status;
- int ret = IRQ_HANDLED;
/* Check if the link is up */
if (!cdns->link_up)
@@ -900,7 +899,7 @@ irqreturn_t sdw_cdns_irq(int irq, void *dev_id)
}
cdns_writel(cdns, CDNS_MCP_INTSTAT, int_status);
- return ret;
+ return IRQ_HANDLED;
}
EXPORT_SYMBOL(sdw_cdns_irq);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: cadence: Remove ret variable from sdw_cdns_irq()
2021-07-14 1:55 ` Bard Liao
@ 2021-07-22 14:17 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-07-22 14:17 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, linux-kernel, gregkh, srinivas.kandagatla,
rander.wang, pierre-louis.bossart, sanyog.r.kale, bard.liao
On 14-07-21, 09:55, Bard Liao wrote:
> From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>
> The ret is not used in the interrupt handler, it is just returned without
> any condition or change.
> We can return the IRQ_HANDLED directly.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: cadence: Remove ret variable from sdw_cdns_irq()
@ 2021-07-22 14:17 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-07-22 14:17 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, gregkh, pierre-louis.bossart, linux-kernel,
sanyog.r.kale, rander.wang, bard.liao
On 14-07-21, 09:55, Bard Liao wrote:
> From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>
> The ret is not used in the interrupt handler, it is just returned without
> any condition or change.
> We can return the IRQ_HANDLED directly.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-22 14:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 1:55 [PATCH] soundwire: cadence: Remove ret variable from sdw_cdns_irq() Bard Liao
2021-07-14 1:55 ` Bard Liao
2021-07-22 14:17 ` Vinod Koul
2021-07-22 14:17 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.