From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
corbet@lwn.net, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next] docs: networking: dpaa2: add documentation for the switch driver
Date: Thu, 22 Jul 2021 17:10:30 +0200 [thread overview]
Message-ID: <YPmKZnU+8DptQMor@lunn.ch> (raw)
In-Reply-To: <20210722144258.iir7cgowfplwzjlq@skbuf>
> > Are these requirements tested? Will the driver fail probe if they are
> > not met?
>
> Yes, they are tested.
>
> If the DPSW object configuration does not meet the requirements, the
> driver will error out on probe with a message explictly saying what
> is happening.
Good. Maybe reference that here, so somebody googling the error
message lands on this document.
> On the other hand, I think this section might give too much details on
> the actual implementation (I took it from the commit message of the
> patch adding the support). Might as well just remove it and add the
> example.
>
> All that I was trying to say is that the filters will not be added in
> the ACL table with the explicit priority specified by the user but
> rather with one determined based on all the rules currently present in
> the table.
> Nothing is unusual in the usage, the order in which the rules are
> executed will be respected.
So if it is an implementation detail, it probably is not relevant
here.
Andrew
prev parent reply other threads:[~2021-07-22 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 13:27 [PATCH net-next] docs: networking: dpaa2: add documentation for the switch driver Ioana Ciornei
2021-07-22 14:27 ` Andrew Lunn
2021-07-22 14:42 ` Ioana Ciornei
2021-07-22 15:10 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPmKZnU+8DptQMor@lunn.ch \
--to=andrew@lunn.ch \
--cc=ciorneiioana@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.