* [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem
@ 2021-06-22 19:10 Petr Vorel
2021-07-08 19:08 ` Petr Vorel
2021-07-24 18:56 ` Petr Vorel
0 siblings, 2 replies; 3+ messages in thread
From: Petr Vorel @ 2021-06-22 19:10 UTC (permalink / raw)
To: linux-arm-msm
Cc: Petr Vorel, Konrad Dybcio, Alexey Minnekhanov, Andy Gross,
Bjorn Andersson, Rob Herring, devicetree
As the default definition breaks booting angler:
[ 1.862561] printk: console [ttyMSM0] enabled
[ 1.872260] msm_serial: driver initialized
D - 15524 - pm_driver_init, Delta
cont_splash_mem was introduced in 74d6d0a145835, but the problem
manifested after 86588296acbf ("fdt: Properly handle "no-map" field
in the memory region").
Disabling it because Angler's firmware does not report where the memory
is allocated (dmesg from downstream kernel):
[ 0.000000] cma: Found cont_splash_mem@0, memory base 0x0000000000000000, size 16 MiB, limit 0x0000000000000000
[ 0.000000] cma: CMA: reserved 16 MiB at 0x0000000000000000 for cont_splash_mem
Similar issue might be on Google Nexus 5X (lg-bullhead). Other MSM8992/4
are known to report correct address.
Fixes: 74d6d0a145835 ("arm64: dts: qcom: msm8994/8994-kitakami: Fix up
the memory map")
Suggested-by: Konrad Dybcio <konradybcio@gmail.com>
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Changes v3->v4:
* add a comment in dts (asked by Konrad)
Kind regards,
Petr
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
index ffe1a9bd8f70..c096b7758aa0 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
@@ -1,12 +1,16 @@
// SPDX-License-Identifier: GPL-2.0-only
/* Copyright (c) 2015, Huawei Inc. All rights reserved.
* Copyright (c) 2016, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
*/
/dts-v1/;
#include "msm8994.dtsi"
+/* Angler's firmware does not report where the memory is allocated */
+/delete-node/ &cont_splash_mem;
+
/ {
model = "Huawei Nexus 6P";
compatible = "huawei,angler", "qcom,msm8994";
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem
2021-06-22 19:10 [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem Petr Vorel
@ 2021-07-08 19:08 ` Petr Vorel
2021-07-24 18:56 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-07-08 19:08 UTC (permalink / raw)
To: linux-arm-msm
Cc: Konrad Dybcio, Alexey Minnekhanov, Andy Gross, Bjorn Andersson,
Rob Herring, devicetree
Hi all,
gentle ping for a review, please.
Kind regards,
Petr
> As the default definition breaks booting angler:
> [ 1.862561] printk: console [ttyMSM0] enabled
> [ 1.872260] msm_serial: driver initialized
> D - 15524 - pm_driver_init, Delta
> cont_splash_mem was introduced in 74d6d0a145835, but the problem
> manifested after 86588296acbf ("fdt: Properly handle "no-map" field
> in the memory region").
> Disabling it because Angler's firmware does not report where the memory
> is allocated (dmesg from downstream kernel):
> [ 0.000000] cma: Found cont_splash_mem@0, memory base 0x0000000000000000, size 16 MiB, limit 0x0000000000000000
> [ 0.000000] cma: CMA: reserved 16 MiB at 0x0000000000000000 for cont_splash_mem
> Similar issue might be on Google Nexus 5X (lg-bullhead). Other MSM8992/4
> are known to report correct address.
> Fixes: 74d6d0a145835 ("arm64: dts: qcom: msm8994/8994-kitakami: Fix up
> the memory map")
> Suggested-by: Konrad Dybcio <konradybcio@gmail.com>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Changes v3->v4:
> * add a comment in dts (asked by Konrad)
> Kind regards,
> Petr
> arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index ffe1a9bd8f70..c096b7758aa0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -1,12 +1,16 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /* Copyright (c) 2015, Huawei Inc. All rights reserved.
> * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
> */
> /dts-v1/;
> #include "msm8994.dtsi"
> +/* Angler's firmware does not report where the memory is allocated */
> +/delete-node/ &cont_splash_mem;
> +
> / {
> model = "Huawei Nexus 6P";
> compatible = "huawei,angler", "qcom,msm8994";
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem
2021-06-22 19:10 [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem Petr Vorel
2021-07-08 19:08 ` Petr Vorel
@ 2021-07-24 18:56 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-07-24 18:56 UTC (permalink / raw)
To: linux-arm-msm, Bjorn Andersson
Cc: Konrad Dybcio, Alexey Minnekhanov, Andy Gross, Rob Herring, devicetree
Hi Bjorn,
could you please queue also this fix? Angler needs it for booting.
Kind regards,
Petr
> As the default definition breaks booting angler:
> [ 1.862561] printk: console [ttyMSM0] enabled
> [ 1.872260] msm_serial: driver initialized
> D - 15524 - pm_driver_init, Delta
> cont_splash_mem was introduced in 74d6d0a145835, but the problem
> manifested after 86588296acbf ("fdt: Properly handle "no-map" field
> in the memory region").
> Disabling it because Angler's firmware does not report where the memory
> is allocated (dmesg from downstream kernel):
> [ 0.000000] cma: Found cont_splash_mem@0, memory base 0x0000000000000000, size 16 MiB, limit 0x0000000000000000
> [ 0.000000] cma: CMA: reserved 16 MiB at 0x0000000000000000 for cont_splash_mem
> Similar issue might be on Google Nexus 5X (lg-bullhead). Other MSM8992/4
> are known to report correct address.
> Fixes: 74d6d0a145835 ("arm64: dts: qcom: msm8994/8994-kitakami: Fix up
> the memory map")
> Suggested-by: Konrad Dybcio <konradybcio@gmail.com>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Changes v3->v4:
> * add a comment in dts (asked by Konrad)
> Kind regards,
> Petr
> arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index ffe1a9bd8f70..c096b7758aa0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -1,12 +1,16 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /* Copyright (c) 2015, Huawei Inc. All rights reserved.
> * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
> */
> /dts-v1/;
> #include "msm8994.dtsi"
> +/* Angler's firmware does not report where the memory is allocated */
> +/delete-node/ &cont_splash_mem;
> +
> / {
> model = "Huawei Nexus 6P";
> compatible = "huawei,angler", "qcom,msm8994";
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-24 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 19:10 [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem Petr Vorel
2021-07-08 19:08 ` Petr Vorel
2021-07-24 18:56 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.