All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	cluster-devel <cluster-devel@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH v4 1/8] iov_iter: Introduce iov_iter_fault_in_writeable helper
Date: Sat, 24 Jul 2021 21:57:28 +0000	[thread overview]
Message-ID: <YPyMyPCpZKGlfAGk@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <CAHc6FU5nGRn1_oc-8rSOCPfkasWknH1Wb3FeeQYP29zb_5fFGQ@mail.gmail.com>

On Sat, Jul 24, 2021 at 11:38:20PM +0200, Andreas Gruenbacher wrote:

> Hmm, how could we have sub-page failure areas when this is about if
> and how pages are mapped? If we return the number of bytes that are
> accessible, then users will know if they got nothing, something, or
> everything, and they can act accordingly.

What I'm saying is that in situation when you have cacheline-sized
poisoned areas, there's no way to get an accurate count of readable
area other than try and copy it out.

What's more, "something" is essentially useless information - the
pages might get unmapped right as your function returns; the caller
still needs to deal with partial copies.  And that's a slow path
by definition, so informing them of a partial fault-in is not
going to be useful.

As far as callers are concerned, it's "nothing suitable in the
beginning of the area" vs. "something might be accessible".

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel <cluster-devel@redhat.com>, Jan Kara <jack@suse.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v4 1/8] iov_iter: Introduce iov_iter_fault_in_writeable helper
Date: Sat, 24 Jul 2021 21:57:28 +0000	[thread overview]
Message-ID: <YPyMyPCpZKGlfAGk@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <CAHc6FU5nGRn1_oc-8rSOCPfkasWknH1Wb3FeeQYP29zb_5fFGQ@mail.gmail.com>

On Sat, Jul 24, 2021 at 11:38:20PM +0200, Andreas Gruenbacher wrote:

> Hmm, how could we have sub-page failure areas when this is about if
> and how pages are mapped? If we return the number of bytes that are
> accessible, then users will know if they got nothing, something, or
> everything, and they can act accordingly.

What I'm saying is that in situation when you have cacheline-sized
poisoned areas, there's no way to get an accurate count of readable
area other than try and copy it out.

What's more, "something" is essentially useless information - the
pages might get unmapped right as your function returns; the caller
still needs to deal with partial copies.  And that's a slow path
by definition, so informing them of a partial fault-in is not
going to be useful.

As far as callers are concerned, it's "nothing suitable in the
beginning of the area" vs. "something might be accessible".

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v4 1/8] iov_iter: Introduce iov_iter_fault_in_writeable helper
Date: Sat, 24 Jul 2021 21:57:28 +0000	[thread overview]
Message-ID: <YPyMyPCpZKGlfAGk@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <CAHc6FU5nGRn1_oc-8rSOCPfkasWknH1Wb3FeeQYP29zb_5fFGQ@mail.gmail.com>

On Sat, Jul 24, 2021 at 11:38:20PM +0200, Andreas Gruenbacher wrote:

> Hmm, how could we have sub-page failure areas when this is about if
> and how pages are mapped? If we return the number of bytes that are
> accessible, then users will know if they got nothing, something, or
> everything, and they can act accordingly.

What I'm saying is that in situation when you have cacheline-sized
poisoned areas, there's no way to get an accurate count of readable
area other than try and copy it out.

What's more, "something" is essentially useless information - the
pages might get unmapped right as your function returns; the caller
still needs to deal with partial copies.  And that's a slow path
by definition, so informing them of a partial fault-in is not
going to be useful.

As far as callers are concerned, it's "nothing suitable in the
beginning of the area" vs. "something might be accessible".



  reply	other threads:[~2021-07-24 21:57 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 19:34 [PATCH v4 0/8] gfs2: Fix mmap + page fault deadlocks Andreas Gruenbacher
2021-07-24 19:34 ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 1/8] iov_iter: Introduce iov_iter_fault_in_writeable helper Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:52   ` Linus Torvalds
2021-07-24 19:52     ` [Cluster-devel] " Linus Torvalds
2021-07-24 19:52     ` [Ocfs2-devel] " Linus Torvalds
2021-07-24 20:24     ` Al Viro
2021-07-24 20:24       ` [Cluster-devel] " Al Viro
2021-07-24 20:24       ` [Ocfs2-devel] " Al Viro
2021-07-24 20:37       ` Linus Torvalds
2021-07-24 20:37         ` [Cluster-devel] " Linus Torvalds
2021-07-24 20:37         ` [Ocfs2-devel] " Linus Torvalds
2021-07-24 21:38       ` Andreas Gruenbacher
2021-07-24 21:38         ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 21:38         ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 21:57         ` Al Viro [this message]
2021-07-24 21:57           ` [Cluster-devel] " Al Viro
2021-07-24 21:57           ` [Ocfs2-devel] " Al Viro
2021-07-24 22:06           ` Andreas Gruenbacher
2021-07-24 22:06             ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 22:06             ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 23:39             ` Al Viro
2021-07-24 23:39               ` [Cluster-devel] " Al Viro
2021-07-24 23:39               ` [Ocfs2-devel] " Al Viro
2021-07-27  9:30     ` David Laight
2021-07-27  9:30       ` [Cluster-devel] " David Laight
2021-07-27  9:30       ` [Ocfs2-devel] " David Laight
2021-07-27 11:13       ` Andreas Gruenbacher
2021-07-27 11:13         ` [Cluster-devel] " Andreas Gruenbacher
2021-07-27 11:13         ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-27 17:51         ` Linus Torvalds
2021-07-27 17:51           ` [Cluster-devel] " Linus Torvalds
2021-07-27 17:51           ` [Ocfs2-devel] " Linus Torvalds
2021-07-24 19:34 ` [PATCH v4 2/8] gfs2: Add wrapper for iomap_file_buffered_write Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 3/8] gfs2: Fix mmap + page fault deadlocks for buffered I/O Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 4/8] iomap: Fix iomap_dio_rw return value for user copies Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 5/8] iomap: Add done_before argument to iomap_dio_rw Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 6/8] iomap: Support restarting direct I/O requests after user copy failures Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 7/8] iov_iter: Introduce noio flag to disable page faults Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-07-24 19:34 ` [PATCH v4 8/8] gfs2: Fix mmap + page fault deadlocks for direct I/O Andreas Gruenbacher
2021-07-24 19:34   ` [Cluster-devel] " Andreas Gruenbacher
2021-07-24 19:34   ` [Ocfs2-devel] " Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPyMyPCpZKGlfAGk@zeniv-ca.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.