From: Patrick Williams <patrick@stwcx.xyz>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: OpenBMC List <openbmc@lists.ozlabs.org>
Subject: Re: `phosphor-logging` APIs (RFC)
Date: Wed, 28 Jul 2021 01:25:17 -0500 [thread overview]
Message-ID: <YQD4TWus75QQjH3U@heinlein> (raw)
In-Reply-To: <41a334dd-56c4-44d0-b8f4-7ecdf5bfa5de@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Wed, Jul 28, 2021 at 03:22:43PM +0930, Andrew Jeffery wrote:
> On Wed, 28 Jul 2021, at 05:54, Patrick Williams wrote:
> - Source location data is invalid (issue openbmc/openbmc#2207).
>
> I think you wanted openbmc/openbmc#2297 there, but yes!
Indeed, that's the issue I meant to refer to. Seems I mentioned it correctly in
the commit.
> > - Useful data is missing from `journalctl` resulting in people working
> > around it by generating strings with `fmt` et.al.
>
> Sounds promising! Reading the proposal it seems like you're appending
> certain bits of structured data to the message. I think it would be
> nice if the data could be interpolated into arbitrary positions and not
> just appended (note, I'm not asking for interpolation of arbitrary
> variables here unlike what can be achieved with raw use of fmt, only
> those captured via the structured logging).
Can you give me a concrete example of what you mean by this? I'm not
understanding.
> Andrew
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-28 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 20:24 `phosphor-logging` APIs (RFC) Patrick Williams
2021-07-28 5:52 ` Andrew Jeffery
2021-07-28 6:25 ` Patrick Williams [this message]
2021-07-28 23:34 ` Andrew Jeffery
2021-07-29 2:53 ` Patrick Williams
2021-08-03 0:27 ` Patrick Williams
2021-08-03 4:07 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQD4TWus75QQjH3U@heinlein \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.