* [PATCH v2 1/1] serial: max310x: Use clock-names property matching to recognize EXTCLK
@ 2021-07-23 12:59 Andy Shevchenko
2021-07-28 14:52 ` Dennis Giaya
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-07-23 12:59 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-serial, linux-kernel
Cc: Jiri Slaby, Andy Shevchenko, Dennis Giaya
Dennis reported that on ACPI-based systems the clock frequency
isn't enough to configure device properly. We have to respect
the clock source as well. To achieve this match the clock-names
property against "osc" to recognize external clock connection.
On DT-based system this doesn't change anything.
Reported-and-tested-by: Dennis Giaya <dgiaya@whoi.edu>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: added Tested-by tag (Dennis), inverted comparison to leave original flow
drivers/tty/serial/max310x.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index ef11860cd69e..3df0788ddeb0 100644
--- a/drivers/tty/serial/max310x.c
+++ b/drivers/tty/serial/max310x.c
@@ -1271,18 +1271,13 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty
/* Always ask for fixed clock rate from a property. */
device_property_read_u32(dev, "clock-frequency", &uartclk);
- s->clk = devm_clk_get_optional(dev, "osc");
+ xtal = device_property_match_string(dev, "clock-names", "osc") < 0;
+ if (xtal)
+ s->clk = devm_clk_get_optional(dev, "xtal");
+ else
+ s->clk = devm_clk_get_optional(dev, "osc");
if (IS_ERR(s->clk))
return PTR_ERR(s->clk);
- if (s->clk) {
- xtal = false;
- } else {
- s->clk = devm_clk_get_optional(dev, "xtal");
- if (IS_ERR(s->clk))
- return PTR_ERR(s->clk);
-
- xtal = true;
- }
ret = clk_prepare_enable(s->clk);
if (ret)
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] serial: max310x: Use clock-names property matching to recognize EXTCLK
2021-07-23 12:59 [PATCH v2 1/1] serial: max310x: Use clock-names property matching to recognize EXTCLK Andy Shevchenko
@ 2021-07-28 14:52 ` Dennis Giaya
2021-07-28 15:19 ` andriy.shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Dennis Giaya @ 2021-07-28 14:52 UTC (permalink / raw)
To: linux-serial, andriy.shevchenko, gregkh, linux-kernel; +Cc: jirislaby
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
> v2: added Tested-by tag (Dennis), inverted comparison to leave
> original flow
I've tested v2 with the inverted comparison and it works under the same
test conditions as v1.
Best,Dennis
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5624 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] serial: max310x: Use clock-names property matching to recognize EXTCLK
2021-07-28 14:52 ` Dennis Giaya
@ 2021-07-28 15:19 ` andriy.shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: andriy.shevchenko @ 2021-07-28 15:19 UTC (permalink / raw)
To: Dennis Giaya; +Cc: linux-serial, gregkh, linux-kernel, jirislaby
On Wed, Jul 28, 2021 at 02:52:17PM +0000, Dennis Giaya wrote:
> > v2: added Tested-by tag (Dennis), inverted comparison to leave
> > original flow
>
> I've tested v2 with the inverted comparison and it works under the same
> test conditions as v1.
Thanks! It's pending for v5.15-rc1.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-28 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 12:59 [PATCH v2 1/1] serial: max310x: Use clock-names property matching to recognize EXTCLK Andy Shevchenko
2021-07-28 14:52 ` Dennis Giaya
2021-07-28 15:19 ` andriy.shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.