From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch,
amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com,
patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, daniel@ffwll.ch,
edmund.j.dea@intel.com, s.hauer@pengutronix.de,
alison.wang@nxp.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, dri-devel@lists.freedesktop.org,
sean@poorly.run, linux-arm-kernel@lists.infradead.org,
tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi,
christian.koenig@amd.com, robdclark@gmail.com,
kernel@pengutronix.de, alexander.deucher@amd.com,
shawnguo@kernel.org, brian.starkey@arm.com
Subject: Re: [PATCH 14/14] drm: IRQ midlayer is now legacy
Date: Wed, 28 Jul 2021 16:10:53 +0200 [thread overview]
Message-ID: <YQFlbRE84lwAcov7@ravnborg.org> (raw)
In-Reply-To: <20210727182721.17981-15-tzimmermann@suse.de>
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote:
> Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use
> the prefix drm_legacy_, and move declarations to drm_legacy.h.
> In struct drm_device, move the fields irq and irq_enabled behind
> CONFIG_DRM_LEGACY.
>
> All callers have been updated.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/drm_irq.c | 63 ++++---------------------------
You could have pulled it all into drm_legacy_misc.c.
> drivers/gpu/drm/drm_legacy_misc.c | 3 +-
> drivers/gpu/drm/drm_vblank.c | 8 ++--
> drivers/gpu/drm/i810/i810_dma.c | 3 +-
> drivers/gpu/drm/mga/mga_dma.c | 2 +-
> drivers/gpu/drm/mga/mga_drv.h | 1 -
> drivers/gpu/drm/r128/r128_cce.c | 3 +-
> drivers/gpu/drm/via/via_mm.c | 3 +-
> include/drm/drm_device.h | 18 ++-------
> include/drm/drm_drv.h | 44 ++-------------------
> include/drm/drm_irq.h | 31 ---------------
> include/drm/drm_legacy.h | 3 ++
> 12 files changed, 27 insertions(+), 155 deletions(-)
> delete mode 100644 include/drm/drm_irq.h
Nice cleanup.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, liviu.dudau@arm.com,
amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
edmund.j.dea@intel.com, s.hauer@pengutronix.de,
alison.wang@nxp.com, dri-devel@lists.freedesktop.org,
sean@poorly.run, linux-arm-kernel@lists.infradead.org,
tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi,
nicolas.ferre@microchip.com, christian.koenig@amd.com,
kernel@pengutronix.de, alexander.deucher@amd.com,
shawnguo@kernel.org
Subject: Re: [PATCH 14/14] drm: IRQ midlayer is now legacy
Date: Wed, 28 Jul 2021 16:10:53 +0200 [thread overview]
Message-ID: <YQFlbRE84lwAcov7@ravnborg.org> (raw)
In-Reply-To: <20210727182721.17981-15-tzimmermann@suse.de>
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote:
> Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use
> the prefix drm_legacy_, and move declarations to drm_legacy.h.
> In struct drm_device, move the fields irq and irq_enabled behind
> CONFIG_DRM_LEGACY.
>
> All callers have been updated.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/drm_irq.c | 63 ++++---------------------------
You could have pulled it all into drm_legacy_misc.c.
> drivers/gpu/drm/drm_legacy_misc.c | 3 +-
> drivers/gpu/drm/drm_vblank.c | 8 ++--
> drivers/gpu/drm/i810/i810_dma.c | 3 +-
> drivers/gpu/drm/mga/mga_dma.c | 2 +-
> drivers/gpu/drm/mga/mga_drv.h | 1 -
> drivers/gpu/drm/r128/r128_cce.c | 3 +-
> drivers/gpu/drm/via/via_mm.c | 3 +-
> include/drm/drm_device.h | 18 ++-------
> include/drm/drm_drv.h | 44 ++-------------------
> include/drm/drm_irq.h | 31 ---------------
> include/drm/drm_legacy.h | 3 ++
> 12 files changed, 27 insertions(+), 155 deletions(-)
> delete mode 100644 include/drm/drm_irq.h
Nice cleanup.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch,
amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com,
patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, daniel@ffwll.ch,
edmund.j.dea@intel.com, s.hauer@pengutronix.de,
alison.wang@nxp.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, dri-devel@lists.freedesktop.org,
sean@poorly.run, linux-arm-kernel@lists.infradead.org,
tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi,
nicolas.ferre@microchip.com, christian.koenig@amd.com,
robdclark@gmail.com, kernel@pengutronix.de,
alexander.deucher@amd.com, shawnguo@kernel.org,
brian.starkey@arm.com
Subject: Re: [PATCH 14/14] drm: IRQ midlayer is now legacy
Date: Wed, 28 Jul 2021 16:10:53 +0200 [thread overview]
Message-ID: <YQFlbRE84lwAcov7@ravnborg.org> (raw)
In-Reply-To: <20210727182721.17981-15-tzimmermann@suse.de>
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote:
> Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use
> the prefix drm_legacy_, and move declarations to drm_legacy.h.
> In struct drm_device, move the fields irq and irq_enabled behind
> CONFIG_DRM_LEGACY.
>
> All callers have been updated.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/drm_irq.c | 63 ++++---------------------------
You could have pulled it all into drm_legacy_misc.c.
> drivers/gpu/drm/drm_legacy_misc.c | 3 +-
> drivers/gpu/drm/drm_vblank.c | 8 ++--
> drivers/gpu/drm/i810/i810_dma.c | 3 +-
> drivers/gpu/drm/mga/mga_dma.c | 2 +-
> drivers/gpu/drm/mga/mga_drv.h | 1 -
> drivers/gpu/drm/r128/r128_cce.c | 3 +-
> drivers/gpu/drm/via/via_mm.c | 3 +-
> include/drm/drm_device.h | 18 ++-------
> include/drm/drm_drv.h | 44 ++-------------------
> include/drm/drm_irq.h | 31 ---------------
> include/drm/drm_legacy.h | 3 ++
> 12 files changed, 27 insertions(+), 155 deletions(-)
> delete mode 100644 include/drm/drm_irq.h
Nice cleanup.
Sam
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-07-28 14:15 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 18:27 [PATCH 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-28 10:27 ` Christian König
2021-07-28 10:27 ` Christian König
2021-07-28 10:27 ` Christian König
2021-07-28 10:27 ` Christian König
2021-07-28 14:03 ` Alex Deucher
2021-07-28 14:03 ` Alex Deucher
2021-07-28 14:03 ` Alex Deucher
2021-07-28 14:03 ` Alex Deucher
2021-08-02 8:43 ` Thomas Zimmermann
2021-08-02 8:43 ` Thomas Zimmermann
2021-08-02 8:43 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 02/14] drm/arm/hdlcd: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-28 13:31 ` Sam Ravnborg
2021-07-28 13:31 ` Sam Ravnborg
2021-07-28 13:31 ` Sam Ravnborg
2021-07-28 18:15 ` Thomas Zimmermann
2021-07-28 18:15 ` Thomas Zimmermann
2021-07-28 18:15 ` Thomas Zimmermann
2021-07-28 18:15 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 03/14] drm/atmel-hlcdc: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-28 14:00 ` Sam Ravnborg
2021-07-28 14:00 ` Sam Ravnborg
2021-07-28 14:00 ` Sam Ravnborg
2021-07-28 15:11 ` Dan.Sneddon
2021-07-28 15:11 ` Dan.Sneddon
2021-07-28 15:11 ` Dan.Sneddon
2021-07-28 15:11 ` Dan.Sneddon
2021-07-28 15:44 ` Sam Ravnborg
2021-07-28 15:44 ` Sam Ravnborg
2021-07-28 15:44 ` Sam Ravnborg
2021-07-28 17:50 ` Dan.Sneddon
2021-07-28 17:50 ` Dan.Sneddon
2021-07-28 17:50 ` Dan.Sneddon
2021-07-28 17:50 ` Dan.Sneddon
2021-07-28 18:11 ` Sam Ravnborg
2021-07-28 18:11 ` Sam Ravnborg
2021-07-28 18:11 ` Sam Ravnborg
2021-07-28 18:17 ` Thomas Zimmermann
2021-07-28 18:17 ` Thomas Zimmermann
2021-07-28 18:17 ` Thomas Zimmermann
2021-07-28 18:17 ` Thomas Zimmermann
2021-07-28 18:46 ` Dan.Sneddon
2021-07-28 18:46 ` Dan.Sneddon
2021-07-28 18:46 ` Dan.Sneddon
2021-07-28 18:46 ` Dan.Sneddon
2021-07-28 19:08 ` Sam Ravnborg
2021-07-28 19:08 ` Sam Ravnborg
2021-07-28 19:08 ` Sam Ravnborg
2021-07-28 19:19 ` Dan.Sneddon
2021-07-28 19:19 ` Dan.Sneddon
2021-07-28 19:19 ` Dan.Sneddon
2021-07-28 19:19 ` Dan.Sneddon
2021-07-28 20:11 ` Sam Ravnborg
2021-07-28 20:11 ` Sam Ravnborg
2021-07-28 20:11 ` Sam Ravnborg
2021-07-29 19:18 ` Thomas Zimmermann
2021-07-29 19:18 ` Thomas Zimmermann
2021-07-29 19:18 ` Thomas Zimmermann
2021-07-29 19:18 ` Thomas Zimmermann
2021-07-29 19:21 ` Thomas Zimmermann
2021-07-29 19:21 ` Thomas Zimmermann
2021-07-29 19:21 ` Thomas Zimmermann
2021-07-29 19:21 ` Thomas Zimmermann
2021-07-29 19:24 ` Dan.Sneddon
2021-07-29 19:24 ` Dan.Sneddon
2021-07-29 19:24 ` Dan.Sneddon
2021-07-29 19:24 ` Dan.Sneddon
2021-07-29 19:32 ` Thomas Zimmermann
2021-07-29 19:32 ` Thomas Zimmermann
2021-07-29 19:32 ` Thomas Zimmermann
2021-07-29 19:32 ` Thomas Zimmermann
2021-07-29 19:48 ` Sam Ravnborg
2021-07-29 19:48 ` Sam Ravnborg
2021-07-29 19:48 ` Sam Ravnborg
2021-07-29 19:55 ` Dan.Sneddon
2021-07-29 19:55 ` Dan.Sneddon
2021-07-29 19:55 ` Dan.Sneddon
2021-07-29 19:55 ` Dan.Sneddon
2021-07-30 8:31 ` Thomas Zimmermann
2021-07-30 8:31 ` Thomas Zimmermann
2021-07-30 8:31 ` Thomas Zimmermann
2021-07-30 8:31 ` Thomas Zimmermann
2021-07-30 18:10 ` Dan.Sneddon
2021-07-30 18:10 ` Dan.Sneddon
2021-07-30 18:10 ` Dan.Sneddon
2021-07-28 18:19 ` Dan.Sneddon
2021-07-28 18:19 ` Dan.Sneddon
2021-07-28 18:19 ` Dan.Sneddon
2021-07-28 18:19 ` Dan.Sneddon
2021-07-27 18:27 ` [PATCH 04/14] drm/fsl-dcu: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 05/14] drm/gma500: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 06/14] drm/kmb: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 07/14] drm/msm: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 08/14] drm/mxsfb: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 09/14] drm/radeon: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-08-02 15:27 ` Alex Deucher
2021-08-02 15:27 ` Alex Deucher
2021-08-02 15:27 ` Alex Deucher
2021-07-27 18:27 ` [PATCH 10/14] drm/tidss: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-29 7:02 ` Tomi Valkeinen
2021-07-29 7:02 ` Tomi Valkeinen
2021-07-29 7:02 ` Tomi Valkeinen
2021-07-29 7:02 ` Tomi Valkeinen
2021-07-27 18:27 ` [PATCH 11/14] drm/tilcdc: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 12/14] drm/vc4: " Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 13/14] drm: Remove unused devm_drm_irq_install() Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-27 18:27 ` Thomas Zimmermann
2021-07-28 14:10 ` Sam Ravnborg [this message]
2021-07-28 14:10 ` Sam Ravnborg
2021-07-28 14:10 ` Sam Ravnborg
2021-07-27 18:51 ` [PATCH 00/14] drm: Make DRM's IRQ helpers legacy Sam Ravnborg
2021-07-27 18:51 ` Sam Ravnborg
2021-07-27 18:51 ` Sam Ravnborg
2021-07-28 5:19 ` Thomas Zimmermann
2021-07-28 5:19 ` Thomas Zimmermann
2021-07-28 5:19 ` Thomas Zimmermann
2021-07-28 5:19 ` Thomas Zimmermann
2021-07-31 18:50 ` Sam Ravnborg
2021-07-31 18:50 ` Sam Ravnborg
2021-08-01 19:56 ` Thomas Zimmermann
2021-08-01 19:56 ` Thomas Zimmermann
2021-08-01 20:24 ` Sam Ravnborg
2021-08-01 20:24 ` Sam Ravnborg
2021-08-02 8:42 ` Thomas Zimmermann
2021-08-02 8:42 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQFlbRE84lwAcov7@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alison.wang@nxp.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=bbrezillon@kernel.org \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tomba@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.