From: Heiko Carstens <hca@linux.ibm.com>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Dimitri John Ledkov <dimitri.ledkov@canonical.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] s390/boot: fix zstd build for -march=z900
Date: Thu, 29 Jul 2021 16:42:53 +0200 [thread overview]
Message-ID: <YQK+bbDzoqhOngxZ@osiris> (raw)
In-Reply-To: <patch-1.thread-f0f589.git-f0f58936888f.your-ad-here.call-01627564869-ext-2765@work.hours>
On Thu, Jul 29, 2021 at 03:29:19PM +0200, Vasily Gorbik wrote:
> zstd decompression uses __builtin_clz() which fails back to __clzdi2()
> when the kernel is built for older hardware like z900. This leads to
> build failures like the following:
> s390x-11.1.0-ld: /devel/src/kernel/arch/s390/boot/compressed/../../../../lib/zstd/bitstream.h:148: undefined reference to `__clzdi2'
>
> Fix that by optionally including lib/clz_ctz.c into the decompressor.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 7b034d9c1b08 ("s390/boot: add zstd support")
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> arch/s390/boot/compressed/Makefile | 1 +
> arch/s390/boot/compressed/clz_ctz.c | 2 ++
> 2 files changed, 3 insertions(+)
> create mode 100644 arch/s390/boot/compressed/clz_ctz.c
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] s390/boot: fix zstd build for -march=z900
Date: Thu, 29 Jul 2021 16:42:53 +0200 [thread overview]
Message-ID: <YQK+bbDzoqhOngxZ@osiris> (raw)
In-Reply-To: <patch-1.thread-f0f589.git-f0f58936888f.your-ad-here.call-01627564869-ext-2765@work.hours>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Thu, Jul 29, 2021 at 03:29:19PM +0200, Vasily Gorbik wrote:
> zstd decompression uses __builtin_clz() which fails back to __clzdi2()
> when the kernel is built for older hardware like z900. This leads to
> build failures like the following:
> s390x-11.1.0-ld: /devel/src/kernel/arch/s390/boot/compressed/../../../../lib/zstd/bitstream.h:148: undefined reference to `__clzdi2'
>
> Fix that by optionally including lib/clz_ctz.c into the decompressor.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 7b034d9c1b08 ("s390/boot: add zstd support")
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> arch/s390/boot/compressed/Makefile | 1 +
> arch/s390/boot/compressed/clz_ctz.c | 2 ++
> 2 files changed, 3 insertions(+)
> create mode 100644 arch/s390/boot/compressed/clz_ctz.c
Applied, thanks!
next prev parent reply other threads:[~2021-07-29 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 17:27 decompressor.c:undefined reference to `__clzdi2' kernel test robot
2021-07-27 17:27 ` kernel test robot
2021-07-29 13:29 ` Vasily Gorbik
2021-07-29 13:29 ` Vasily Gorbik
2021-07-29 13:29 ` [PATCH] s390/boot: fix zstd build for -march=z900 Vasily Gorbik
2021-07-29 13:29 ` Vasily Gorbik
2021-07-29 14:42 ` Heiko Carstens [this message]
2021-07-29 14:42 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQK+bbDzoqhOngxZ@osiris \
--to=hca@linux.ibm.com \
--cc=dimitri.ledkov@canonical.com \
--cc=gor@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.