All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: dmaengine@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, shawnguo@kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH] dma: imx-dma: configure the generic DMA type to make it work
Date: Mon, 2 Aug 2021 12:33:44 +0530	[thread overview]
Message-ID: <YQeY0E5oRHXkT+TO@matsya> (raw)
In-Reply-To: <20210729071821.9857-1-jbe@pengutronix.de>

On 29-07-21, 09:18, Juergen Borleis wrote:
> Commit dea7a9f

you should use 12+ chars for sha1 
>   dmaengine: imx-dma: remove dma_slave_config direction usage

even with this is commit log, you made the patch tile dma: ....!
> 
> changes the method from a "configuration when called" to an "configuration
> when used". Due to this, only the cyclic DMA type gets configured
> correctly, while the generic DMA type is left non-configured.
> 
> Without this additional call, the struct imxdma_channel::word_size member
> is stuck at DMA_SLAVE_BUSWIDTH_UNDEFINED and imxdma_prep_slave_sg() always
> returns NULL.

I ahve fixed the subsystem name, updated commit in 12 chars and format
expected, added it as Fixes line and applied.

Please take care of these things!

> 
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
>  drivers/dma/imx-dma.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 7f116bb..2ddc31e 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -812,6 +812,8 @@ static struct dma_async_tx_descriptor *imxdma_prep_slave_sg(
>  		dma_length += sg_dma_len(sg);
>  	}
>  
> +	imxdma_config_write(chan, &imxdmac->config, direction);
> +
>  	switch (imxdmac->word_size) {
>  	case DMA_SLAVE_BUSWIDTH_4_BYTES:
>  		if (sg_dma_len(sgl) & 3 || sgl->dma_address & 3)
> -- 
> 2.20.1

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: dmaengine@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, shawnguo@kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH] dma: imx-dma: configure the generic DMA type to make it work
Date: Mon, 2 Aug 2021 12:33:44 +0530	[thread overview]
Message-ID: <YQeY0E5oRHXkT+TO@matsya> (raw)
In-Reply-To: <20210729071821.9857-1-jbe@pengutronix.de>

On 29-07-21, 09:18, Juergen Borleis wrote:
> Commit dea7a9f

you should use 12+ chars for sha1 
>   dmaengine: imx-dma: remove dma_slave_config direction usage

even with this is commit log, you made the patch tile dma: ....!
> 
> changes the method from a "configuration when called" to an "configuration
> when used". Due to this, only the cyclic DMA type gets configured
> correctly, while the generic DMA type is left non-configured.
> 
> Without this additional call, the struct imxdma_channel::word_size member
> is stuck at DMA_SLAVE_BUSWIDTH_UNDEFINED and imxdma_prep_slave_sg() always
> returns NULL.

I ahve fixed the subsystem name, updated commit in 12 chars and format
expected, added it as Fixes line and applied.

Please take care of these things!

> 
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
>  drivers/dma/imx-dma.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 7f116bb..2ddc31e 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -812,6 +812,8 @@ static struct dma_async_tx_descriptor *imxdma_prep_slave_sg(
>  		dma_length += sg_dma_len(sg);
>  	}
>  
> +	imxdma_config_write(chan, &imxdmac->config, direction);
> +
>  	switch (imxdmac->word_size) {
>  	case DMA_SLAVE_BUSWIDTH_4_BYTES:
>  		if (sg_dma_len(sgl) & 3 || sgl->dma_address & 3)
> -- 
> 2.20.1

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-02  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  7:18 [PATCH] dma: imx-dma: configure the generic DMA type to make it work Juergen Borleis
2021-07-29  7:18 ` Juergen Borleis
2021-08-02  7:03 ` Vinod Koul [this message]
2021-08-02  7:03   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQeY0E5oRHXkT+TO@matsya \
    --to=vkoul@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=jbe@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.