* [RESEND PATCH v2 0/2] locking/lockdep, drm: apply new lockdep assert in drm_auth.c
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
Hi all,
My bad for the resend. Adding cc: intel-gfx, and the maintainers and
mailing lists for include/drm/drm_file.h.
Following a discussion on the patch ("drm: use the lookup lock in
drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert
helpers to make it convenient to compose lockdep checks together.
This series includes the patch that introduces the new lockdep helpers,
then utilizes these helpers in drm_is_current_master_locked in the
following patch.
v1 -> v2:
Patch 2:
- Updated the kerneldoc on the lock design of drm_file.master to explain
the use of lockdep_assert(). As suggested by Boqun Feng.
Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1]
Best wishes,
Desmond
Desmond Cheong Zhi Xi (1):
drm: add lockdep assert to drm_is_current_master_locked
Peter Zijlstra (1):
locking/lockdep: Provide lockdep_assert{,_once}() helpers
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
include/linux/lockdep.h | 41 +++++++++++++++++++-------------------
3 files changed, 28 insertions(+), 23 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 0/2] locking/lockdep, drm: apply new lockdep assert in drm_auth.c
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: intel-gfx, linux-kernel, dri-devel, linaro-mm-sig,
Desmond Cheong Zhi Xi, linux-kernel-mentees, linux-media
Hi all,
My bad for the resend. Adding cc: intel-gfx, and the maintainers and
mailing lists for include/drm/drm_file.h.
Following a discussion on the patch ("drm: use the lookup lock in
drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert
helpers to make it convenient to compose lockdep checks together.
This series includes the patch that introduces the new lockdep helpers,
then utilizes these helpers in drm_is_current_master_locked in the
following patch.
v1 -> v2:
Patch 2:
- Updated the kerneldoc on the lock design of drm_file.master to explain
the use of lockdep_assert(). As suggested by Boqun Feng.
Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1]
Best wishes,
Desmond
Desmond Cheong Zhi Xi (1):
drm: add lockdep assert to drm_is_current_master_locked
Peter Zijlstra (1):
locking/lockdep: Provide lockdep_assert{,_once}() helpers
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
include/linux/lockdep.h | 41 +++++++++++++++++++-------------------
3 files changed, 28 insertions(+), 23 deletions(-)
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] [RESEND PATCH v2 0/2] locking/lockdep, drm: apply new lockdep assert in drm_auth.c
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
Hi all,
My bad for the resend. Adding cc: intel-gfx, and the maintainers and
mailing lists for include/drm/drm_file.h.
Following a discussion on the patch ("drm: use the lookup lock in
drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert
helpers to make it convenient to compose lockdep checks together.
This series includes the patch that introduces the new lockdep helpers,
then utilizes these helpers in drm_is_current_master_locked in the
following patch.
v1 -> v2:
Patch 2:
- Updated the kerneldoc on the lock design of drm_file.master to explain
the use of lockdep_assert(). As suggested by Boqun Feng.
Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1]
Best wishes,
Desmond
Desmond Cheong Zhi Xi (1):
drm: add lockdep assert to drm_is_current_master_locked
Peter Zijlstra (1):
locking/lockdep: Provide lockdep_assert{,_once}() helpers
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
include/linux/lockdep.h | 41 +++++++++++++++++++-------------------
3 files changed, 28 insertions(+), 23 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{,_once}() helpers
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
(?)
(?)
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
-1 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
From: Peter Zijlstra <peterz@infradead.org>
Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:
lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
lockdep_is_held(&drm_file.master_lookup_lock));
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/lockdep.h | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 5cf387813754..9fe165beb0f9 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -306,31 +306,29 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie);
#define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)
-#define lockdep_assert_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_NOT_HELD); \
- } while (0)
+#define lockdep_assert(cond) \
+ do { WARN_ON(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_not_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_HELD); \
- } while (0)
+#define lockdep_assert_once(cond) \
+ do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_held_write(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 0)); \
- } while (0)
+#define lockdep_assert_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
-#define lockdep_assert_held_read(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 1)); \
- } while (0)
+#define lockdep_assert_not_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
-#define lockdep_assert_held_once(l) do { \
- WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \
- } while (0)
+#define lockdep_assert_held_write(l) \
+ lockdep_assert(lockdep_is_held_type(l, 0))
-#define lockdep_assert_none_held_once() do { \
- WARN_ON_ONCE(debug_locks && current->lockdep_depth); \
- } while (0)
+#define lockdep_assert_held_read(l) \
+ lockdep_assert(lockdep_is_held_type(l, 1))
+
+#define lockdep_assert_held_once(l) \
+ lockdep_assert_once(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
+
+#define lockdep_assert_none_held_once() \
+ lockdep_assert_once(!current->lockdep_depth)
#define lockdep_recursing(tsk) ((tsk)->lockdep_recursion)
@@ -407,6 +405,9 @@ extern int lock_is_held(const void *);
extern int lockdep_is_held(const void *);
#define lockdep_is_held_type(l, r) (1)
+#define lockdep_assert(c) do { } while (0)
+#define lockdep_assert_once(c) do { } while (0)
+
#define lockdep_assert_held(l) do { (void)(l); } while (0)
#define lockdep_assert_not_held(l) do { (void)(l); } while (0)
#define lockdep_assert_held_write(l) do { (void)(l); } while (0)
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{, _once}() helpers
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: intel-gfx, linux-kernel, dri-devel, linaro-mm-sig,
Desmond Cheong Zhi Xi, linux-kernel-mentees, linux-media
From: Peter Zijlstra <peterz@infradead.org>
Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:
lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
lockdep_is_held(&drm_file.master_lookup_lock));
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/lockdep.h | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 5cf387813754..9fe165beb0f9 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -306,31 +306,29 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie);
#define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)
-#define lockdep_assert_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_NOT_HELD); \
- } while (0)
+#define lockdep_assert(cond) \
+ do { WARN_ON(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_not_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_HELD); \
- } while (0)
+#define lockdep_assert_once(cond) \
+ do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_held_write(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 0)); \
- } while (0)
+#define lockdep_assert_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
-#define lockdep_assert_held_read(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 1)); \
- } while (0)
+#define lockdep_assert_not_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
-#define lockdep_assert_held_once(l) do { \
- WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \
- } while (0)
+#define lockdep_assert_held_write(l) \
+ lockdep_assert(lockdep_is_held_type(l, 0))
-#define lockdep_assert_none_held_once() do { \
- WARN_ON_ONCE(debug_locks && current->lockdep_depth); \
- } while (0)
+#define lockdep_assert_held_read(l) \
+ lockdep_assert(lockdep_is_held_type(l, 1))
+
+#define lockdep_assert_held_once(l) \
+ lockdep_assert_once(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
+
+#define lockdep_assert_none_held_once() \
+ lockdep_assert_once(!current->lockdep_depth)
#define lockdep_recursing(tsk) ((tsk)->lockdep_recursion)
@@ -407,6 +405,9 @@ extern int lock_is_held(const void *);
extern int lockdep_is_held(const void *);
#define lockdep_is_held_type(l, r) (1)
+#define lockdep_assert(c) do { } while (0)
+#define lockdep_assert_once(c) do { } while (0)
+
#define lockdep_assert_held(l) do { (void)(l); } while (0)
#define lockdep_assert_not_held(l) do { (void)(l); } while (0)
#define lockdep_assert_held_write(l) do { (void)(l); } while (0)
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{, _once}() helpers
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
From: Peter Zijlstra <peterz@infradead.org>
Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:
lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
lockdep_is_held(&drm_file.master_lookup_lock));
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/lockdep.h | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 5cf387813754..9fe165beb0f9 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -306,31 +306,29 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie);
#define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)
-#define lockdep_assert_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_NOT_HELD); \
- } while (0)
+#define lockdep_assert(cond) \
+ do { WARN_ON(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_not_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_HELD); \
- } while (0)
+#define lockdep_assert_once(cond) \
+ do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_held_write(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 0)); \
- } while (0)
+#define lockdep_assert_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
-#define lockdep_assert_held_read(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 1)); \
- } while (0)
+#define lockdep_assert_not_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
-#define lockdep_assert_held_once(l) do { \
- WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \
- } while (0)
+#define lockdep_assert_held_write(l) \
+ lockdep_assert(lockdep_is_held_type(l, 0))
-#define lockdep_assert_none_held_once() do { \
- WARN_ON_ONCE(debug_locks && current->lockdep_depth); \
- } while (0)
+#define lockdep_assert_held_read(l) \
+ lockdep_assert(lockdep_is_held_type(l, 1))
+
+#define lockdep_assert_held_once(l) \
+ lockdep_assert_once(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
+
+#define lockdep_assert_none_held_once() \
+ lockdep_assert_once(!current->lockdep_depth)
#define lockdep_recursing(tsk) ((tsk)->lockdep_recursion)
@@ -407,6 +405,9 @@ extern int lock_is_held(const void *);
extern int lockdep_is_held(const void *);
#define lockdep_is_held_type(l, r) (1)
+#define lockdep_assert(c) do { } while (0)
+#define lockdep_assert_once(c) do { } while (0)
+
#define lockdep_assert_held(l) do { (void)(l); } while (0)
#define lockdep_assert_not_held(l) do { (void)(l); } while (0)
#define lockdep_assert_held_write(l) do { (void)(l); } while (0)
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{, _once}() helpers
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
From: Peter Zijlstra <peterz@infradead.org>
Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:
lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
lockdep_is_held(&drm_file.master_lookup_lock));
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/lockdep.h | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 5cf387813754..9fe165beb0f9 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -306,31 +306,29 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie);
#define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)
-#define lockdep_assert_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_NOT_HELD); \
- } while (0)
+#define lockdep_assert(cond) \
+ do { WARN_ON(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_not_held(l) do { \
- WARN_ON(debug_locks && \
- lockdep_is_held(l) == LOCK_STATE_HELD); \
- } while (0)
+#define lockdep_assert_once(cond) \
+ do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
-#define lockdep_assert_held_write(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 0)); \
- } while (0)
+#define lockdep_assert_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
-#define lockdep_assert_held_read(l) do { \
- WARN_ON(debug_locks && !lockdep_is_held_type(l, 1)); \
- } while (0)
+#define lockdep_assert_not_held(l) \
+ lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
-#define lockdep_assert_held_once(l) do { \
- WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \
- } while (0)
+#define lockdep_assert_held_write(l) \
+ lockdep_assert(lockdep_is_held_type(l, 0))
-#define lockdep_assert_none_held_once() do { \
- WARN_ON_ONCE(debug_locks && current->lockdep_depth); \
- } while (0)
+#define lockdep_assert_held_read(l) \
+ lockdep_assert(lockdep_is_held_type(l, 1))
+
+#define lockdep_assert_held_once(l) \
+ lockdep_assert_once(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
+
+#define lockdep_assert_none_held_once() \
+ lockdep_assert_once(!current->lockdep_depth)
#define lockdep_recursing(tsk) ((tsk)->lockdep_recursion)
@@ -407,6 +405,9 @@ extern int lock_is_held(const void *);
extern int lockdep_is_held(const void *);
#define lockdep_is_held_type(l, r) (1)
+#define lockdep_assert(c) do { } while (0)
+#define lockdep_assert_once(c) do { } while (0)
+
#define lockdep_assert_held(l) do { (void)(l); } while (0)
#define lockdep_assert_not_held(l) do { (void)(l); } while (0)
#define lockdep_assert_held_write(l) do { (void)(l); } while (0)
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
(?)
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
-1 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
In drm_is_current_master_locked, accessing drm_file.master should be
protected by either drm_file.master_lookup_lock or
drm_device.master_mutex. This was previously awkward to assert with
lockdep.
Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
helpers"), this assertion is now convenient. So we add in the
assertion and explain this lock design in the kerneldoc.
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
index 9c24b8cc8e36..6f4d7ff23c80 100644
--- a/drivers/gpu/drm/drm_auth.c
+++ b/drivers/gpu/drm/drm_auth.c
@@ -63,9 +63,9 @@
static bool drm_is_current_master_locked(struct drm_file *fpriv)
{
- /* Either drm_device.master_mutex or drm_file.master_lookup_lock
- * should be held here.
- */
+ lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
+ lockdep_is_held(&fpriv->minor->dev->master_mutex));
+
return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
}
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 726cfe0ff5f5..a3acb7ac3550 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -233,6 +233,10 @@ struct drm_file {
* this only matches &drm_device.master if the master is the currently
* active one.
*
+ * To update @master, both &drm_device.master_mutex and
+ * @master_lookup_lock need to be held, therefore holding either of
+ * them is safe and enough for the read side.
+ *
* When dereferencing this pointer, either hold struct
* &drm_device.master_mutex for the duration of the pointer's use, or
* use drm_file_get_master() if struct &drm_device.master_mutex is not
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: intel-gfx, linux-kernel, dri-devel, linaro-mm-sig,
Desmond Cheong Zhi Xi, linux-kernel-mentees, linux-media
In drm_is_current_master_locked, accessing drm_file.master should be
protected by either drm_file.master_lookup_lock or
drm_device.master_mutex. This was previously awkward to assert with
lockdep.
Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
helpers"), this assertion is now convenient. So we add in the
assertion and explain this lock design in the kerneldoc.
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
index 9c24b8cc8e36..6f4d7ff23c80 100644
--- a/drivers/gpu/drm/drm_auth.c
+++ b/drivers/gpu/drm/drm_auth.c
@@ -63,9 +63,9 @@
static bool drm_is_current_master_locked(struct drm_file *fpriv)
{
- /* Either drm_device.master_mutex or drm_file.master_lookup_lock
- * should be held here.
- */
+ lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
+ lockdep_is_held(&fpriv->minor->dev->master_mutex));
+
return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
}
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 726cfe0ff5f5..a3acb7ac3550 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -233,6 +233,10 @@ struct drm_file {
* this only matches &drm_device.master if the master is the currently
* active one.
*
+ * To update @master, both &drm_device.master_mutex and
+ * @master_lookup_lock need to be held, therefore holding either of
+ * them is safe and enough for the read side.
+ *
* When dereferencing this pointer, either hold struct
* &drm_device.master_mutex for the duration of the pointer's use, or
* use drm_file_get_master() if struct &drm_device.master_mutex is not
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
@ 2021-08-02 10:59 ` Desmond Cheong Zhi Xi
0 siblings, 0 replies; 17+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-08-02 10:59 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig
Cc: Desmond Cheong Zhi Xi, dri-devel, linux-kernel, intel-gfx,
linux-media, linaro-mm-sig, skhan, gregkh, linux-kernel-mentees
In drm_is_current_master_locked, accessing drm_file.master should be
protected by either drm_file.master_lookup_lock or
drm_device.master_mutex. This was previously awkward to assert with
lockdep.
Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
helpers"), this assertion is now convenient. So we add in the
assertion and explain this lock design in the kerneldoc.
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Acked-by: Waiman Long <longman@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
drivers/gpu/drm/drm_auth.c | 6 +++---
include/drm/drm_file.h | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
index 9c24b8cc8e36..6f4d7ff23c80 100644
--- a/drivers/gpu/drm/drm_auth.c
+++ b/drivers/gpu/drm/drm_auth.c
@@ -63,9 +63,9 @@
static bool drm_is_current_master_locked(struct drm_file *fpriv)
{
- /* Either drm_device.master_mutex or drm_file.master_lookup_lock
- * should be held here.
- */
+ lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
+ lockdep_is_held(&fpriv->minor->dev->master_mutex));
+
return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
}
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 726cfe0ff5f5..a3acb7ac3550 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -233,6 +233,10 @@ struct drm_file {
* this only matches &drm_device.master if the master is the currently
* active one.
*
+ * To update @master, both &drm_device.master_mutex and
+ * @master_lookup_lock need to be held, therefore holding either of
+ * them is safe and enough for the read side.
+ *
* When dereferencing this pointer, either hold struct
* &drm_device.master_mutex for the duration of the pointer's use, or
* use drm_file_get_master() if struct &drm_device.master_mutex is not
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for locking/lockdep, drm: apply new lockdep assert in drm_auth.c
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
` (3 preceding siblings ...)
(?)
@ 2021-08-02 13:28 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-08-02 13:28 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi; +Cc: intel-gfx
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
60bc4f495a48 locking/lockdep: Provide lockdep_assert{, _once}() helpers
-:30: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#30: FILE: include/linux/lockdep.h:309:
+#define lockdep_assert(cond) \
+ do { WARN_ON(debug_locks && !(cond)); } while (0)
-:37: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#37: FILE: include/linux/lockdep.h:312:
+#define lockdep_assert_once(cond) \
+ do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
-:81: CHECK:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email comments mismatch: 'From: Peter Zijlstra <peterz@infradead.org>' != 'Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>'
total: 0 errors, 2 warnings, 1 checks, 58 lines checked
e5ac42473801 drm: add lockdep assert to drm_is_current_master_locked
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for locking/lockdep, drm: apply new lockdep assert in drm_auth.c
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
` (4 preceding siblings ...)
(?)
@ 2021-08-02 13:32 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-08-02 13:32 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi; +Cc: intel-gfx
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+drivers/gpu/drm/amd/amdgpu/amdgpu_ioc32.c:37:6: warning: symbol 'amdgpu_kms_compat_ioctl' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1137:38: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1139:51: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1145:53: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1147:49: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1153:51: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1154:51: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1155:50: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1156:49: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1157:48: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1273:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1802:9: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1811:31: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1812:30: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1816:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1818:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1820:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1822:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1824:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1826:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1828:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1838:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1842:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1846:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1849:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1858:33: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2017:9: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2026:31: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2027:30: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2031:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2041:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2045:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2049:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2052:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2061:33: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2128:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2130:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2132:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2144:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2146:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2148:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2177:9: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2186:31: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2187:30: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2191:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2201:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2205:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2209:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2212:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2221:33: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2228:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2230:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2232:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2244:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2246:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:2248:9: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:370:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:378:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:412:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:460:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:518:27: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:540:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:549:36: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1037:21: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1060:25: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1062:35: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1064:36: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1132:23: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1152:35: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1237:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1240:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1246:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1249:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1255:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1257:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1259:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1261:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1263:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1289:30: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1355:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1358:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1364:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1367:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1373:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1375:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1377:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1379:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1381:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1512:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:154:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1658:23: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:167:19: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1715:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1751:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1797:27: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1803:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1811:36: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:183:14: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1847:27: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1854:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1867:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1869:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1871:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1873:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1875:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1877:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1879:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1881:25: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1958:26: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1962:26: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1966:26: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1972:26: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1988:49: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2005:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2238:38: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2239:34: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2240:35: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2245:25: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2248:25: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2252:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2254:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2264:31: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2265:30: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2267:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2269:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2273:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2276:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2279:47: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2280:47: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2282:28: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2284:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2286:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2287:34: warning: too many warnings
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:235:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:298:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:358:29: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:360:44: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:438:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:440:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:442:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:444:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:446:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:489:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:491:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:493:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:495:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:497:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:499:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:501:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:575:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:577:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:579:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:581:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:583:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:585:17: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:587:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:642:37: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:668:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:715:33: warning: cast to restricted __le32
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:717:43: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:719:44: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:862:17: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:876:18: warning: cast to restricted __le16
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:205:34: expected unsigned short [usertype] usPixelClock
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:205:34: got restricted __le16 [usertype]
+drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:205:34: warning: incorrect type in assignment (different base types)
+drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:739:14: warning: symbol 'get_highest_allowed_voltage_level' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn10/rv1_clk_mgr.c:37:6: warning: symbol 'rv1_init_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c:102:5: warning: symbol 'rv1_vbios_smu_send_msg_with_param' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c:123:5: warning: symbol 'rv1_vbios_smu_set_dispclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c:146:5: warning: symbol 'rv1_vbios_smu_set_dprefclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c:402:6: warning: symbol 'dcn2_enable_pme_wa' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:124:6: warning: symbol 'rn_update_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:431:6: warning: symbol 'rn_get_clk_states' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:441:6: warning: symbol 'rn_enable_pme_wa' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:448:6: warning: symbol 'rn_init_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:58:5: warning: symbol 'rn_get_active_display_cnt_wa' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:90:6: warning: symbol 'rn_set_low_power_state' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:110:5: warning: symbol 'rn_vbios_smu_get_smu_version' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:119:5: warning: symbol 'rn_vbios_smu_set_dispclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:146:5: warning: symbol 'rn_vbios_smu_set_dprefclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:160:5: warning: symbol 'rn_vbios_smu_set_hard_min_dcfclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:175:5: warning: symbol 'rn_vbios_smu_set_min_deep_sleep_dcfclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:190:6: warning: symbol 'rn_vbios_smu_set_phyclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:198:5: warning: symbol 'rn_vbios_smu_set_dppclk' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:214:6: warning: symbol 'rn_vbios_smu_set_dcn_low_power_state' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:229:6: warning: symbol 'rn_vbios_smu_enable_48mhz_tmdp_refclk_pwrdwn' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:237:6: warning: symbol 'rn_vbios_smu_enable_pme_wa' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:245:5: warning: symbol 'rn_vbios_smu_is_periodic_retraining_disabled' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:89:5: warning: symbol 'rn_vbios_smu_send_msg_with_param' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/dcn301_smu.c:91:5: warning: symbol 'dcn301_smu_send_msg_with_param' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:371:6: warning: symbol 'vg_get_clk_states' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:389:6: warning: symbol 'vg_init_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:756:43: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:92:6: warning: symbol 'vg_update_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c:522:22: warning: symbol 'dcn3_fpga_funcs' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:531:6: warning: symbol 'dcn31_clk_mgr_helper_populate_bw_params' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:643:43: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:69:5: warning: symbol 'dcn31_get_active_display_cnt_wa' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn31/dcn31_smu.c:98:5: warning: symbol 'dcn31_smu_send_msg_with_param' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1365:16: warning: symbol 'configure_lttpr_mode_transparent' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1376:16: warning: symbol 'configure_lttpr_mode_non_transparent' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1627:16: warning: symbol 'dpcd_configure_channel_coding' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1736:16: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1156:6: warning: symbol 'dce110_disable_stream' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1182:6: warning: symbol 'dce110_unblank_stream' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1529:84: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1808:6: warning: symbol 'dce110_set_safe_displaymarks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2589:6: warning: symbol 'dce110_prepare_bandwidth' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2603:6: warning: symbol 'dce110_optimize_bandwidth' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2659:84: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2886:6: warning: symbol 'dce110_set_backlight_level' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2920:6: warning: symbol 'dce110_set_abm_immediate_disable' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2933:6: warning: symbol 'dce110_set_pipe' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2999:6: warning: symbol 'dce110_hw_sequencer_construct' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:661:6: warning: symbol 'dce110_enable_stream' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:865:16: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:547:62: warning: dubious: x | !y
+drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:460:62: warning: dubious: x | !y
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_dpp.c:123:6: warning: symbol 'dpp_set_gamut_remap_bypass' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_dpp_dscl.c:546:6: warning: symbol 'dpp1_dscl_set_scaler_auto_scale' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol 'aperture_default_system' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol 'context0_default_system' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:135:6: warning: symbol 'dcn10_log_hubbub_state' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1902:10: warning: symbol 'reduceSizeAndFraction' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1953:6: warning: symbol 'is_low_refresh_rate' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1962:9: warning: symbol 'get_clock_divider' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1982:5: warning: symbol 'dcn10_align_pixel_clocks' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2274:6: warning: symbol 'dcn10_program_pte_vm' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:80:6: warning: symbol 'print_microsec' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_opp.c:351:6: warning: symbol 'opp1_program_oppbuf' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_optc.c:139:6: warning: symbol 'optc1_set_vupdate_keepout' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_optc.c:879:6: warning: symbol 'optc1_setup_manual_trigger' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_optc.c:897:6: warning: symbol 'optc1_program_manual_trigger' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1131:16: warning: symbol 'dcn10_add_stream_to_ctx' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:113:43: warning: symbol 'dcn1_0_soc' was not declared. Should it be static?
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:319:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:319:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:320:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:320:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:321:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:321:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:322:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:322:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:346:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:346:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:350:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:350:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:414:9: also defined here
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:414:9: warning: Initializer entry defined twice
+drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:415:9:
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for locking/lockdep, drm: apply new lockdep assert in drm_auth.c
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
` (5 preceding siblings ...)
(?)
@ 2021-08-02 13:57 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-08-02 13:57 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3665 bytes --]
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437 -> Patchwork_20757
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/index.html
Known issues
------------
Here are the changes found in Patchwork_20757 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([i915#1372])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-tgl-1115g4: [PASS][3] -> [DMESG-WARN][4] ([i915#1887])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/fi-tgl-1115g4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/fi-tgl-1115g4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@runner@aborted:
- fi-tgl-1115g4: NOTRUN -> [FAIL][5] ([i915#1602])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/fi-tgl-1115g4/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][6] ([i915#3303]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@runner@aborted:
- fi-bsw-nick: [FAIL][8] ([fdo#109271] / [i915#1436] / [i915#2722]) -> [FAIL][9] ([fdo#109271] / [i915#1436])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/fi-bsw-nick/igt@runner@aborted.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/fi-bsw-nick/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
Participating hosts (37 -> 33)
------------------------------
Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10437 -> Patchwork_20757
CI-20190529: 20190529
CI_DRM_10437: fe234200649024b4fb5164d99eca74d62ae696d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6159: 6135b9cc319ed965e3aafb5b2ae2abf4762a06b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20757: e5ac4247380127f8c096980bf09829f0ee291d4d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e5ac42473801 drm: add lockdep assert to drm_is_current_master_locked
60bc4f495a48 locking/lockdep: Provide lockdep_assert{, _once}() helpers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/index.html
[-- Attachment #2: Type: text/html, Size: 4513 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for locking/lockdep, drm: apply new lockdep assert in drm_auth.c
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
` (6 preceding siblings ...)
(?)
@ 2021-08-02 21:24 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-08-02 21:24 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30283 bytes --]
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437_full -> Patchwork_20757_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20757_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2410])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk7/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk7/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2410])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@in-flight-suspend:
- shard-apl: [PASS][6] -> [DMESG-WARN][7] ([i915#180])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-apl2/igt@gem_eio@in-flight-suspend.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl2/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][8] -> [TIMEOUT][9] ([i915#2369] / [i915#3063] / [i915#3648])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-tglb8/igt@gem_eio@unwedge-stress.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb7/igt@gem_eio@unwedge-stress.html
- shard-iclb: [PASS][10] -> [TIMEOUT][11] ([i915#2369] / [i915#2481] / [i915#3070])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb6/igt@gem_eio@unwedge-stress.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-kbl2/igt@gem_exec_fair@basic-none@vecs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl6/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2842]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2428])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-snb7/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl3/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#3297])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: NOTRUN -> [DMESG-WARN][24] ([i915#180])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl4/igt@gem_workarounds@suspend-resume-context.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: NOTRUN -> [DMESG-WARN][25] ([i915#180])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl2/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#2856])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][27] -> [FAIL][28] ([i915#454])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-iclb: [PASS][29] -> [INCOMPLETE][30] ([i915#1185])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb2/igt@i915_suspend@fence-restore-tiled2untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl2/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +28 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271]) +324 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][36] ([fdo#109271]) +445 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-snb2/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-glk: NOTRUN -> [SKIP][37] ([fdo#109271]) +18 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +22 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl3/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl3/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_color@pipe-d-ctm-0-5:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271]) +111 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl1/igt@kms_color@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +10 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl9/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_color_chamelium@pipe-b-ctm-negative:
- shard-snb: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +20 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-snb7/igt@kms_color_chamelium@pipe-b-ctm-negative.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109284] / [fdo#111827])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb8/igt@kms_color_chamelium@pipe-c-gamma.html
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109284] / [fdo#111827])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb6/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_content_protection@legacy:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#111828])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][47] ([i915#1319]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl2/igt@kms_content_protection@lic.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][48] ([i915#2105])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][49] -> [DMESG-WARN][50] ([i915#180]) +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [FAIL][52] ([i915#2346] / [i915#533])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#3451])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl8/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109274])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb8/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@busy-flip@a-edp1:
- shard-skl: [PASS][56] -> [DMESG-WARN][57] ([i915#1982])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl3/igt@kms_flip@busy-flip@a-edp1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl9/igt@kms_flip@busy-flip@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [INCOMPLETE][58] ([i915#3699])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#2587])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2672])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#111825]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-rte:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109280]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-rte.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][63] -> [FAIL][64] ([i915#1188])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][65] ([fdo#108145] / [i915#265]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][66] ([i915#265])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-skl: NOTRUN -> [FAIL][67] ([i915#265])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][68] -> [FAIL][69] ([fdo#108145] / [i915#265])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +6 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl10/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
- shard-glk: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][74] -> [SKIP][75] ([fdo#109441])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl8/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2437]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl7/igt@kms_writeback@writeback-invalid-parameters.html
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#2530])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb6/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#2530])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb8/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html
* igt@sysfs_clients@recycle-many:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl7/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2994])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl9/igt@sysfs_clients@split-10.html
#### Possible fixes ####
* igt@fbdev@write:
- {shard-rkl}: [SKIP][82] ([i915#2582]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@fbdev@write.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@fbdev@write.html
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][84] ([i915#658]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@feature_discovery@psr1.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-iclb: [FAIL][86] ([i915#2410]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb6/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][88] ([i915#2410]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-5/igt@gem_ctx_persistence@many-contexts.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][90] ([i915#2846]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
- shard-glk: [FAIL][92] ([i915#2846]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk6/igt@gem_exec_fair@basic-deadline.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][94] ([i915#2842]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [FAIL][96] ([i915#2842]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk6/igt@gem_exec_fair@basic-none-vip@rcs0.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][98] ([i915#2842]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][100] ([i915#2849]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-iclb: [INCOMPLETE][102] ([i915#1895] / [i915#2405]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-iclb2/igt@gem_exec_whisper@basic-queues-forked.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-iclb1/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_workarounds@suspend-resume:
- shard-skl: [INCOMPLETE][104] ([i915#146] / [i915#198]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl7/igt@gem_workarounds@suspend-resume.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl10/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_rpm@reg-read-ioctl:
- {shard-rkl}: [SKIP][106] ([i915#3844] / [i915#579]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-6/igt@i915_pm_rpm@reg-read-ioctl.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-1/igt@i915_pm_rpm@reg-read-ioctl.html
* igt@kms_big_fb@linear-16bpp-rotate-180:
- {shard-rkl}: [SKIP][108] ([i915#3638]) -> [PASS][109] +4 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_big_fb@linear-16bpp-rotate-180.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_big_fb@linear-16bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][110] ([i915#118] / [i915#95]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- {shard-rkl}: [SKIP][112] ([i915#3721]) -> [PASS][113] +4 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [FAIL][114] ([i915#3678]) -> [PASS][115] +4 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-5/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [DMESG-WARN][116] ([i915#1982]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl8/igt@kms_color@pipe-a-ctm-0-25.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl4/igt@kms_color@pipe-a-ctm-0-25.html
* igt@kms_color@pipe-c-ctm-max:
- {shard-rkl}: [SKIP][118] ([i915#1149] / [i915#1849]) -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_color@pipe-c-ctm-max.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_color@pipe-c-ctm-max.html
* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- {shard-rkl}: [SKIP][120] ([fdo#112022]) -> [PASS][121] +10 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- {shard-rkl}: [SKIP][122] ([fdo#111825]) -> [PASS][123] +4 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- {shard-rkl}: [SKIP][124] ([fdo#111314]) -> [PASS][125] +3 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][126] ([i915#79]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-tglb: [FAIL][128] ([i915#79]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][130] ([i915#180]) -> [PASS][131] +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133] +3 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite:
- {shard-rkl}: [SKIP][134] ([i915#1849] / [i915#3180]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- {shard-rkl}: [SKIP][136] ([i915#1849]) -> [PASS][137] +34 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-5/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][138] ([i915#3558]) -> [PASS][139] +3 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-1/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][140] ([fdo#108145] / [i915#265]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- {shard-rkl}: [SKIP][142] ([i915#1849] / [i915#3558]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10437/shard-rkl-5/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html
* igt@kms_psr@cursor_mmap_gtt:
- {shard-rkl}: [SKIP][144] ([i915#1072]) -> [PASS][145] +1 similar issue
[144]: https://intel-gfx-ci.01.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20757/index.html
[-- Attachment #2: Type: text/html, Size: 33458 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
(?)
@ 2021-08-05 10:08 ` Daniel Vetter
-1 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2021-08-05 10:08 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig,
dri-devel, linux-kernel, intel-gfx, linux-media, linaro-mm-sig,
skhan, gregkh, linux-kernel-mentees
On Mon, Aug 02, 2021 at 06:59:57PM +0800, Desmond Cheong Zhi Xi wrote:
> In drm_is_current_master_locked, accessing drm_file.master should be
> protected by either drm_file.master_lookup_lock or
> drm_device.master_mutex. This was previously awkward to assert with
> lockdep.
>
> Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
> helpers"), this assertion is now convenient. So we add in the
> assertion and explain this lock design in the kerneldoc.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
> Acked-by: Waiman Long <longman@redhat.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Both patches pushed to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_auth.c | 6 +++---
> include/drm/drm_file.h | 4 ++++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
> index 9c24b8cc8e36..6f4d7ff23c80 100644
> --- a/drivers/gpu/drm/drm_auth.c
> +++ b/drivers/gpu/drm/drm_auth.c
> @@ -63,9 +63,9 @@
>
> static bool drm_is_current_master_locked(struct drm_file *fpriv)
> {
> - /* Either drm_device.master_mutex or drm_file.master_lookup_lock
> - * should be held here.
> - */
> + lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
> + lockdep_is_held(&fpriv->minor->dev->master_mutex));
> +
> return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
> }
>
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index 726cfe0ff5f5..a3acb7ac3550 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -233,6 +233,10 @@ struct drm_file {
> * this only matches &drm_device.master if the master is the currently
> * active one.
> *
> + * To update @master, both &drm_device.master_mutex and
> + * @master_lookup_lock need to be held, therefore holding either of
> + * them is safe and enough for the read side.
> + *
> * When dereferencing this pointer, either hold struct
> * &drm_device.master_mutex for the duration of the pointer's use, or
> * use drm_file_get_master() if struct &drm_device.master_mutex is not
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
@ 2021-08-05 10:08 ` Daniel Vetter
0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2021-08-05 10:08 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi
Cc: tzimmermann, airlied, boqun.feng, maarten.lankhorst,
linux-kernel, mripard, christian.koenig, linaro-mm-sig, peterz,
mingo, dri-devel, daniel, intel-gfx, longman, will, sumit.semwal,
linux-kernel-mentees, linux-media
On Mon, Aug 02, 2021 at 06:59:57PM +0800, Desmond Cheong Zhi Xi wrote:
> In drm_is_current_master_locked, accessing drm_file.master should be
> protected by either drm_file.master_lookup_lock or
> drm_device.master_mutex. This was previously awkward to assert with
> lockdep.
>
> Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
> helpers"), this assertion is now convenient. So we add in the
> assertion and explain this lock design in the kerneldoc.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
> Acked-by: Waiman Long <longman@redhat.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Both patches pushed to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_auth.c | 6 +++---
> include/drm/drm_file.h | 4 ++++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
> index 9c24b8cc8e36..6f4d7ff23c80 100644
> --- a/drivers/gpu/drm/drm_auth.c
> +++ b/drivers/gpu/drm/drm_auth.c
> @@ -63,9 +63,9 @@
>
> static bool drm_is_current_master_locked(struct drm_file *fpriv)
> {
> - /* Either drm_device.master_mutex or drm_file.master_lookup_lock
> - * should be held here.
> - */
> + lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
> + lockdep_is_held(&fpriv->minor->dev->master_mutex));
> +
> return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
> }
>
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index 726cfe0ff5f5..a3acb7ac3550 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -233,6 +233,10 @@ struct drm_file {
> * this only matches &drm_device.master if the master is the currently
> * active one.
> *
> + * To update @master, both &drm_device.master_mutex and
> + * @master_lookup_lock need to be held, therefore holding either of
> + * them is safe and enough for the read side.
> + *
> * When dereferencing this pointer, either hold struct
> * &drm_device.master_mutex for the duration of the pointer's use, or
> * use drm_file_get_master() if struct &drm_device.master_mutex is not
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked
@ 2021-08-05 10:08 ` Daniel Vetter
0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2021-08-05 10:08 UTC (permalink / raw)
To: Desmond Cheong Zhi Xi
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, peterz,
mingo, will, longman, boqun.feng, sumit.semwal, christian.koenig,
dri-devel, linux-kernel, intel-gfx, linux-media, linaro-mm-sig,
skhan, gregkh, linux-kernel-mentees
On Mon, Aug 02, 2021 at 06:59:57PM +0800, Desmond Cheong Zhi Xi wrote:
> In drm_is_current_master_locked, accessing drm_file.master should be
> protected by either drm_file.master_lookup_lock or
> drm_device.master_mutex. This was previously awkward to assert with
> lockdep.
>
> Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
> helpers"), this assertion is now convenient. So we add in the
> assertion and explain this lock design in the kerneldoc.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
> Acked-by: Waiman Long <longman@redhat.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Both patches pushed to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_auth.c | 6 +++---
> include/drm/drm_file.h | 4 ++++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
> index 9c24b8cc8e36..6f4d7ff23c80 100644
> --- a/drivers/gpu/drm/drm_auth.c
> +++ b/drivers/gpu/drm/drm_auth.c
> @@ -63,9 +63,9 @@
>
> static bool drm_is_current_master_locked(struct drm_file *fpriv)
> {
> - /* Either drm_device.master_mutex or drm_file.master_lookup_lock
> - * should be held here.
> - */
> + lockdep_assert_once(lockdep_is_held(&fpriv->master_lookup_lock) ||
> + lockdep_is_held(&fpriv->minor->dev->master_mutex));
> +
> return fpriv->is_master && drm_lease_owner(fpriv->master) == fpriv->minor->dev->master;
> }
>
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index 726cfe0ff5f5..a3acb7ac3550 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -233,6 +233,10 @@ struct drm_file {
> * this only matches &drm_device.master if the master is the currently
> * active one.
> *
> + * To update @master, both &drm_device.master_mutex and
> + * @master_lookup_lock need to be held, therefore holding either of
> + * them is safe and enough for the read side.
> + *
> * When dereferencing this pointer, either hold struct
> * &drm_device.master_mutex for the duration of the pointer's use, or
> * use drm_file_get_master() if struct &drm_device.master_mutex is not
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-08-05 10:08 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 10:59 [RESEND PATCH v2 0/2] locking/lockdep, drm: apply new lockdep assert in drm_auth.c Desmond Cheong Zhi Xi
2021-08-02 10:59 ` [Intel-gfx] " Desmond Cheong Zhi Xi
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
2021-08-02 10:59 ` [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{,_once}() helpers Desmond Cheong Zhi Xi
2021-08-02 10:59 ` [Intel-gfx] [RESEND PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{, _once}() helpers Desmond Cheong Zhi Xi
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
2021-08-02 10:59 ` [RESEND PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked Desmond Cheong Zhi Xi
2021-08-02 10:59 ` [Intel-gfx] " Desmond Cheong Zhi Xi
2021-08-02 10:59 ` Desmond Cheong Zhi Xi
2021-08-05 10:08 ` Daniel Vetter
2021-08-05 10:08 ` [Intel-gfx] " Daniel Vetter
2021-08-05 10:08 ` Daniel Vetter
2021-08-02 13:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for locking/lockdep, drm: apply new lockdep assert in drm_auth.c Patchwork
2021-08-02 13:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-02 13:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-02 21:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.