* unexport memcg locking helpers
@ 2021-08-20 9:58 Christoph Hellwig
2021-08-20 9:58 ` Christoph Hellwig
2021-08-20 9:58 ` Christoph Hellwig
0 siblings, 2 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-08-20 9:58 UTC (permalink / raw)
To: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton
Cc: Matthew Wilcox, cgroups, linux-mm
Hi all,
neither the old page-based nor the new folio-based memcg locking
helpers are used in modular code at all, so drop the exports.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] mm: unexport folio_memcg_{,un}lock
@ 2021-08-20 9:58 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-08-20 9:58 UTC (permalink / raw)
To: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton
Cc: Matthew Wilcox, cgroups, linux-mm
These are only used in built-in core mm code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
mm/memcontrol.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 45a160894a035..4cb4349065931 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2014,7 +2014,6 @@ void folio_memcg_lock(struct folio *folio)
memcg->move_lock_task = current;
memcg->move_lock_flags = flags;
}
-EXPORT_SYMBOL(folio_memcg_lock);
void lock_page_memcg(struct page *page)
{
@@ -2048,7 +2047,6 @@ void folio_memcg_unlock(struct folio *folio)
{
__folio_memcg_unlock(folio_memcg(folio));
}
-EXPORT_SYMBOL(folio_memcg_unlock);
void unlock_page_memcg(struct page *page)
{
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] mm: unexport folio_memcg_{,un}lock
@ 2021-08-20 9:58 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-08-20 9:58 UTC (permalink / raw)
To: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton
Cc: Matthew Wilcox, cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg
These are only used in built-in core mm code.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
mm/memcontrol.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 45a160894a035..4cb4349065931 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2014,7 +2014,6 @@ void folio_memcg_lock(struct folio *folio)
memcg->move_lock_task = current;
memcg->move_lock_flags = flags;
}
-EXPORT_SYMBOL(folio_memcg_lock);
void lock_page_memcg(struct page *page)
{
@@ -2048,7 +2047,6 @@ void folio_memcg_unlock(struct folio *folio)
{
__folio_memcg_unlock(folio_memcg(folio));
}
-EXPORT_SYMBOL(folio_memcg_unlock);
void unlock_page_memcg(struct page *page)
{
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] mm: unexport {,un}lock_page_memcg
@ 2021-08-20 9:58 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-08-20 9:58 UTC (permalink / raw)
To: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton
Cc: Matthew Wilcox, cgroups, linux-mm
These are only used in built-in core mm code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
mm/memcontrol.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 4cb4349065931..6a74a180e3eae 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2019,7 +2019,6 @@ void lock_page_memcg(struct page *page)
{
folio_memcg_lock(page_folio(page));
}
-EXPORT_SYMBOL(lock_page_memcg);
static void __folio_memcg_unlock(struct mem_cgroup *memcg)
{
@@ -2052,7 +2051,6 @@ void unlock_page_memcg(struct page *page)
{
folio_memcg_unlock(page_folio(page));
}
-EXPORT_SYMBOL(unlock_page_memcg);
struct obj_stock {
#ifdef CONFIG_MEMCG_KMEM
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] mm: unexport {,un}lock_page_memcg
@ 2021-08-20 9:58 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-08-20 9:58 UTC (permalink / raw)
To: Johannes Weiner, Michal Hocko, Vladimir Davydov, Andrew Morton
Cc: Matthew Wilcox, cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg
These are only used in built-in core mm code.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
mm/memcontrol.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 4cb4349065931..6a74a180e3eae 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2019,7 +2019,6 @@ void lock_page_memcg(struct page *page)
{
folio_memcg_lock(page_folio(page));
}
-EXPORT_SYMBOL(lock_page_memcg);
static void __folio_memcg_unlock(struct mem_cgroup *memcg)
{
@@ -2052,7 +2051,6 @@ void unlock_page_memcg(struct page *page)
{
folio_memcg_unlock(page_folio(page));
}
-EXPORT_SYMBOL(unlock_page_memcg);
struct obj_stock {
#ifdef CONFIG_MEMCG_KMEM
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] mm: unexport {,un}lock_page_memcg
@ 2021-08-20 13:58 ` Johannes Weiner
0 siblings, 0 replies; 7+ messages in thread
From: Johannes Weiner @ 2021-08-20 13:58 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Michal Hocko, Vladimir Davydov, Andrew Morton, Matthew Wilcox,
cgroups, linux-mm
On Fri, Aug 20, 2021 at 11:58:15AM +0200, Christoph Hellwig wrote:
> These are only used in built-in core mm code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Good catch.
It was initially exported for xfs dirtying, and is no longer needed
after that switched to iomap (and now __set_page_dirty_nobuffers).
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] mm: unexport {,un}lock_page_memcg
@ 2021-08-20 13:58 ` Johannes Weiner
0 siblings, 0 replies; 7+ messages in thread
From: Johannes Weiner @ 2021-08-20 13:58 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Michal Hocko, Vladimir Davydov, Andrew Morton, Matthew Wilcox,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg
On Fri, Aug 20, 2021 at 11:58:15AM +0200, Christoph Hellwig wrote:
> These are only used in built-in core mm code.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Good catch.
It was initially exported for xfs dirtying, and is no longer needed
after that switched to iomap (and now __set_page_dirty_nobuffers).
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-20 13:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 9:58 unexport memcg locking helpers Christoph Hellwig
2021-08-20 9:58 ` [PATCH 1/2] mm: unexport folio_memcg_{,un}lock Christoph Hellwig
2021-08-20 9:58 ` Christoph Hellwig
2021-08-20 9:58 ` [PATCH 2/2] mm: unexport {,un}lock_page_memcg Christoph Hellwig
2021-08-20 9:58 ` Christoph Hellwig
2021-08-20 13:58 ` Johannes Weiner
2021-08-20 13:58 ` Johannes Weiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.