All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: haibo.chen@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
	ulf.hansson@linaro.org, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
Date: Wed, 18 Aug 2021 13:33:26 -0500	[thread overview]
Message-ID: <YR1SdhfM344Ii7BQ@robh.at.kernel.org> (raw)
In-Reply-To: <1629279984-7397-1-git-send-email-haibo.chen@nxp.com>

On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Change the pinctrl-names rule to cover all cases.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  .../bindings/mmc/fsl-imx-esdhc.yaml           | 21 +++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 17086f60f8a3..d324606a4f0a 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -116,12 +116,21 @@ properties:
>        - const: per
>  
>    pinctrl-names:
> -    minItems: 1
> -    items:
> -      - const: default
> -      - const: state_100mhz
> -      - const: state_200mhz
> -      - const: sleep
> +    oneOf:
> +      - items:
> +          - const: default
> +          - const: state_100mhz
> +          - const: state_200mhz
> +          - const: sleep
> +      - items:
> +          - const: default
> +          - const: state_100mhz
> +          - const: state_200mhz

You can drop this one and add 'minItems: 3' to the first case.

> +      - items:
> +          - const: default
> +          - const: sleep
> +      - items:
> +          - const: default

Similar here too with the prior case. Or use 'minItems: 1' in the first 
case. That additional allows the 2 entry case, but why isn't that valid? 
Couldn't a board only support default+state_100mhz?

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: haibo.chen@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
	ulf.hansson@linaro.org, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
Date: Wed, 18 Aug 2021 13:33:26 -0500	[thread overview]
Message-ID: <YR1SdhfM344Ii7BQ@robh.at.kernel.org> (raw)
In-Reply-To: <1629279984-7397-1-git-send-email-haibo.chen@nxp.com>

On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Change the pinctrl-names rule to cover all cases.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  .../bindings/mmc/fsl-imx-esdhc.yaml           | 21 +++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 17086f60f8a3..d324606a4f0a 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -116,12 +116,21 @@ properties:
>        - const: per
>  
>    pinctrl-names:
> -    minItems: 1
> -    items:
> -      - const: default
> -      - const: state_100mhz
> -      - const: state_200mhz
> -      - const: sleep
> +    oneOf:
> +      - items:
> +          - const: default
> +          - const: state_100mhz
> +          - const: state_200mhz
> +          - const: sleep
> +      - items:
> +          - const: default
> +          - const: state_100mhz
> +          - const: state_200mhz

You can drop this one and add 'minItems: 3' to the first case.

> +      - items:
> +          - const: default
> +          - const: sleep
> +      - items:
> +          - const: default

Similar here too with the prior case. Or use 'minItems: 1' in the first 
case. That additional allows the 2 entry case, but why isn't that valid? 
Couldn't a board only support default+state_100mhz?

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-18 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  9:46 [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule haibo.chen
2021-08-18  9:46 ` haibo.chen
2021-08-18 18:33 ` Rob Herring [this message]
2021-08-18 18:33   ` Rob Herring
2021-08-19  3:30   ` Bough Chen
2021-08-19  3:30     ` Bough Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR1SdhfM344Ii7BQ@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.