All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: zynqmp: Fix serial compatible string
Date: Mon, 9 Aug 2021 04:57:03 +0300	[thread overview]
Message-ID: <YRCLb1grspPDh4vX@pendragon.ideasonboard.com> (raw)
In-Reply-To: <89b36e0a6187cc6b05b27a035efdf79173bd4486.1628240307.git.michal.simek@xilinx.com>

Hi Michal,

Thank you for the patch.

On Fri, Aug 06, 2021 at 10:58:29AM +0200, Michal Simek wrote:
> Based on commit 65a2c14d4f00 ("dt-bindings: serial: convert Cadence UART
> bindings to YAML") compatible string should look like differently that's
> why fix it to be aligned with dt binding.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 6f0fcec28ae2..b5fde9dddca5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -786,7 +786,7 @@ ttc3: timer@ff140000 {
>  		};
>  
>  		uart0: serial@ff000000 {
> -			compatible = "cdns,uart-r1p12", "xlnx,xuartps";
> +			compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>  			status = "disabled";
>  			interrupt-parent = <&gic>;
>  			interrupts = <0 21 4>;
> @@ -796,7 +796,7 @@ uart0: serial@ff000000 {
>  		};
>  
>  		uart1: serial@ff010000 {
> -			compatible = "cdns,uart-r1p12", "xlnx,xuartps";
> +			compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>  			status = "disabled";
>  			interrupt-parent = <&gic>;
>  			interrupts = <0 22 4>;

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: zynqmp: Fix serial compatible string
Date: Mon, 9 Aug 2021 04:57:03 +0300	[thread overview]
Message-ID: <YRCLb1grspPDh4vX@pendragon.ideasonboard.com> (raw)
In-Reply-To: <89b36e0a6187cc6b05b27a035efdf79173bd4486.1628240307.git.michal.simek@xilinx.com>

Hi Michal,

Thank you for the patch.

On Fri, Aug 06, 2021 at 10:58:29AM +0200, Michal Simek wrote:
> Based on commit 65a2c14d4f00 ("dt-bindings: serial: convert Cadence UART
> bindings to YAML") compatible string should look like differently that's
> why fix it to be aligned with dt binding.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 6f0fcec28ae2..b5fde9dddca5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -786,7 +786,7 @@ ttc3: timer@ff140000 {
>  		};
>  
>  		uart0: serial@ff000000 {
> -			compatible = "cdns,uart-r1p12", "xlnx,xuartps";
> +			compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>  			status = "disabled";
>  			interrupt-parent = <&gic>;
>  			interrupts = <0 21 4>;
> @@ -796,7 +796,7 @@ uart0: serial@ff000000 {
>  		};
>  
>  		uart1: serial@ff010000 {
> -			compatible = "cdns,uart-r1p12", "xlnx,xuartps";
> +			compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>  			status = "disabled";
>  			interrupt-parent = <&gic>;
>  			interrupts = <0 22 4>;

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-09  1:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  8:58 [PATCH] arm64: zynqmp: Fix serial compatible string Michal Simek
2021-08-06  8:58 ` Michal Simek
2021-08-09  1:57 ` Laurent Pinchart [this message]
2021-08-09  1:57   ` Laurent Pinchart
2021-08-25  6:21 ` Michal Simek
2021-08-25  6:21   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRCLb1grspPDh4vX@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.