All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs
@ 2021-08-06  8:59 ` Paul Barker
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Barker @ 2021-08-06  8:59 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, linux-omap
  Cc: Paul Barker, Robert Nelson, devicetree, linux-arm-kernel

pinctrl settings for the USB hub, barometer & accelerometer need to be
referenced from the relevant nodes to work.

Signed-off-by: Paul Barker <paul.barker@sancloud.com>
---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 2 ++
 arch/arm/boot/dts/am335x-sancloud-bbe.dts         | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
index 627c18d23f94..55952fe8687c 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
@@ -58,6 +58,8 @@ &cpsw_port1 {
 
 &i2c0 {
 	usb2512b: usb-hub@2c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb_hub_ctrl>;
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
index 2a0ac9f5dda7..efbe93135dbe 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
@@ -32,6 +32,8 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_A10, PIN_INPUT, MUX_MODE7)     /* gpmc_a10.gpio1_
 
 &i2c0 {
 	lps331ap: barometer@5c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&lps3331ap_pins>;
 		compatible = "st,lps331ap-press";
 		st,drdy-int-pin = <1>;
 		reg = <0x5c>;
@@ -40,6 +42,8 @@ lps331ap: barometer@5c {
 	};
 
 	mpu6050: accelerometer@68 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&mpu6050_pins>;
 		compatible = "invensense,mpu6050";
 		reg = <0x68>;
 		interrupt-parent = <&gpio0>;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs
@ 2021-08-06  8:59 ` Paul Barker
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Barker @ 2021-08-06  8:59 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, linux-omap
  Cc: Paul Barker, Robert Nelson, devicetree, linux-arm-kernel

pinctrl settings for the USB hub, barometer & accelerometer need to be
referenced from the relevant nodes to work.

Signed-off-by: Paul Barker <paul.barker@sancloud.com>
---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 2 ++
 arch/arm/boot/dts/am335x-sancloud-bbe.dts         | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
index 627c18d23f94..55952fe8687c 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
@@ -58,6 +58,8 @@ &cpsw_port1 {
 
 &i2c0 {
 	usb2512b: usb-hub@2c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb_hub_ctrl>;
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
index 2a0ac9f5dda7..efbe93135dbe 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
@@ -32,6 +32,8 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_A10, PIN_INPUT, MUX_MODE7)     /* gpmc_a10.gpio1_
 
 &i2c0 {
 	lps331ap: barometer@5c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&lps3331ap_pins>;
 		compatible = "st,lps331ap-press";
 		st,drdy-int-pin = <1>;
 		reg = <0x5c>;
@@ -40,6 +42,8 @@ lps331ap: barometer@5c {
 	};
 
 	mpu6050: accelerometer@68 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&mpu6050_pins>;
 		compatible = "invensense,mpu6050";
 		reg = <0x68>;
 		interrupt-parent = <&gpio0>;
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: am335x-sancloud-bbe: Drop usb wifi comment
  2021-08-06  8:59 ` Paul Barker
@ 2021-08-06  8:59   ` Paul Barker
  -1 siblings, 0 replies; 6+ messages in thread
From: Paul Barker @ 2021-08-06  8:59 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, linux-omap
  Cc: Paul Barker, Robert Nelson, devicetree, linux-arm-kernel

The wifi chip on USB port 4 may not be present on all BBE variants.

Signed-off-by: Paul Barker <paul.barker@sancloud.com>
---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
index 55952fe8687c..f9b7e774ac48 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
@@ -63,6 +63,5 @@ usb2512b: usb-hub@2c {
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-		/* wifi on port 4 */
 	};
 };
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: am335x-sancloud-bbe: Drop usb wifi comment
@ 2021-08-06  8:59   ` Paul Barker
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Barker @ 2021-08-06  8:59 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, linux-omap
  Cc: Paul Barker, Robert Nelson, devicetree, linux-arm-kernel

The wifi chip on USB port 4 may not be present on all BBE variants.

Signed-off-by: Paul Barker <paul.barker@sancloud.com>
---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
index 55952fe8687c..f9b7e774ac48 100644
--- a/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi
@@ -63,6 +63,5 @@ usb2512b: usb-hub@2c {
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-		/* wifi on port 4 */
 	};
 };
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs
  2021-08-06  8:59 ` Paul Barker
@ 2021-08-10  6:59   ` Tony Lindgren
  -1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2021-08-10  6:59 UTC (permalink / raw)
  To: Paul Barker
  Cc: Benoît Cousson, linux-omap, Robert Nelson, devicetree,
	linux-arm-kernel

* Paul Barker <paul.barker@sancloud.com> [210806 11:59]:
> pinctrl settings for the USB hub, barometer & accelerometer need to be
> referenced from the relevant nodes to work.

Thanks applying both into omap-for-v5.15/dt.

Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs
@ 2021-08-10  6:59   ` Tony Lindgren
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2021-08-10  6:59 UTC (permalink / raw)
  To: Paul Barker
  Cc: Benoît Cousson, linux-omap, Robert Nelson, devicetree,
	linux-arm-kernel

* Paul Barker <paul.barker@sancloud.com> [210806 11:59]:
> pinctrl settings for the USB hub, barometer & accelerometer need to be
> referenced from the relevant nodes to work.

Thanks applying both into omap-for-v5.15/dt.

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-10  7:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06  8:59 [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs Paul Barker
2021-08-06  8:59 ` Paul Barker
2021-08-06  8:59 ` [PATCH 2/2] ARM: dts: am335x-sancloud-bbe: Drop usb wifi comment Paul Barker
2021-08-06  8:59   ` Paul Barker
2021-08-10  6:59 ` [PATCH 1/2] ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs Tony Lindgren
2021-08-10  6:59   ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.