All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per clock
Date: Wed, 11 Aug 2021 12:04:38 -0600	[thread overview]
Message-ID: <YRQRNrLXIYERa6FT@robh.at.kernel.org> (raw)
In-Reply-To: <20210803072958.4815-1-o.rempel@pengutronix.de>

On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote:
> Add optional osc_per and fix dts validation warnings on imx6 SoCs.
> 
> Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema")

I don't think you can say the above commit was broken.

> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/timer/fsl,imxgpt.yaml   | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..e496dd9f4988 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -43,11 +43,15 @@ properties:
>      items:
>        - description: SoC GPT ipg clock
>        - description: SoC GPT per clock
> +      - description: optional SoC GPT oscillator
> +    minItems: 2

The 3rd clock is valid on every version of the h/w?

>  
>    clock-names:
>      items:
>        - const: ipg
>        - const: per
> +      - const: osc_per
> +    minItems: 2
>  
>  required:
>    - compatible
> @@ -70,3 +74,16 @@ examples:
>                   <&clks IMX27_CLK_PER1_GATE>;
>          clock-names = "ipg", "per";
>      };
> +
> +  - |
> +    #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> +    timer@2098000 {
> +        compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt";
> +        reg = <0x02098000 0x4000>;
> +        interrupts = <26>;
> +        clocks = <&clks IMX6QDL_CLK_GPT_IPG>,
> +                 <&clks IMX6QDL_CLK_GPT_IPG_PER>,
> +                 <&clks IMX6QDL_CLK_GPT_3M>;
> +        clock-names = "ipg", "per", "osc_per";
> +    };
> -- 
> 2.30.2
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per clock
Date: Wed, 11 Aug 2021 12:04:38 -0600	[thread overview]
Message-ID: <YRQRNrLXIYERa6FT@robh.at.kernel.org> (raw)
In-Reply-To: <20210803072958.4815-1-o.rempel@pengutronix.de>

On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote:
> Add optional osc_per and fix dts validation warnings on imx6 SoCs.
> 
> Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema")

I don't think you can say the above commit was broken.

> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/timer/fsl,imxgpt.yaml   | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..e496dd9f4988 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -43,11 +43,15 @@ properties:
>      items:
>        - description: SoC GPT ipg clock
>        - description: SoC GPT per clock
> +      - description: optional SoC GPT oscillator
> +    minItems: 2

The 3rd clock is valid on every version of the h/w?

>  
>    clock-names:
>      items:
>        - const: ipg
>        - const: per
> +      - const: osc_per
> +    minItems: 2
>  
>  required:
>    - compatible
> @@ -70,3 +74,16 @@ examples:
>                   <&clks IMX27_CLK_PER1_GATE>;
>          clock-names = "ipg", "per";
>      };
> +
> +  - |
> +    #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> +    timer@2098000 {
> +        compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt";
> +        reg = <0x02098000 0x4000>;
> +        interrupts = <26>;
> +        clocks = <&clks IMX6QDL_CLK_GPT_IPG>,
> +                 <&clks IMX6QDL_CLK_GPT_IPG_PER>,
> +                 <&clks IMX6QDL_CLK_GPT_3M>;
> +        clock-names = "ipg", "per", "osc_per";
> +    };
> -- 
> 2.30.2
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-11 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  7:29 [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per clock Oleksij Rempel
2021-08-03  7:29 ` [PATCH v1] dt-bindings: timer: fsl, imxgpt: " Oleksij Rempel
2021-08-11 18:04 ` Rob Herring [this message]
2021-08-11 18:04   ` [PATCH v1] dt-bindings: timer: fsl,imxgpt: " Rob Herring
2021-08-12  5:18   ` Oleksij Rempel
2021-08-12  5:18     ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRQRNrLXIYERa6FT@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.