[PATCH] perf test: Do not compare overheads in the zstd comp test

[PATCH] perf test: Do not compare overheads in the zstd comp test

[Namhyung Kim]

The overhead can vary on each run so it'd make the test failed
sometimes.  Also order of hist entry can change.

Use perf report -F option to omit the overhead field and sort the
result alphabetically.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 045723b3d992..8a168cf8bacc 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -25,8 +25,8 @@ check_compressed_stats() {
 
 check_compressed_output() {
 	$perf_tool inject -i $trace_file -o $trace_file.decomp &&
-	$perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
-	$perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
+	$perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
+	$perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
 	diff $trace_file.comp.output $trace_file.decomp.output
 }
 
-- 
2.33.0.rc1.237.g0d66db33f3-goog

Re: [PATCH] perf test: Do not compare overheads in the zstd comp test

[Ian Rogers]

On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The overhead can vary on each run so it'd make the test failed
> sometimes.  Also order of hist entry can change.
>
> Use perf report -F option to omit the overhead field and sort the
> result alphabetically.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 045723b3d992..8a168cf8bacc 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -25,8 +25,8 @@ check_compressed_stats() {
>
>  check_compressed_output() {
>         $perf_tool inject -i $trace_file -o $trace_file.decomp &&
> -       $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
> -       $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
> +       $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
> +       $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
>         diff $trace_file.comp.output $trace_file.decomp.output
>  }
>
> --
> 2.33.0.rc1.237.g0d66db33f3-goog
>

Re: [PATCH] perf test: Do not compare overheads in the zstd comp test

[Arnaldo Carvalho de Melo]

Em Thu, Aug 12, 2021 at 05:09:20PM -0700, Ian Rogers escreveu:
> On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > The overhead can vary on each run so it'd make the test failed
> > sometimes.  Also order of hist entry can change.
> >
> > Use perf report -F option to omit the overhead field and sort the
> > result alphabetically.
> >
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > index 045723b3d992..8a168cf8bacc 100755
> > --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > @@ -25,8 +25,8 @@ check_compressed_stats() {
> >
> >  check_compressed_output() {
> >         $perf_tool inject -i $trace_file -o $trace_file.decomp &&
> > -       $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
> > -       $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
> > +       $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
> > +       $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
> >         diff $trace_file.comp.output $trace_file.decomp.output
> >  }
> >
> > --
> > 2.33.0.rc1.237.g0d66db33f3-goog
> >

-- 

- Arnaldo