[PATCH 4.4 4.9 4.14 4.19 5.4 5.10] net: xilinx_emaclite: Do not print real IOMEM pointer

[PATCH 4.4 4.9 4.14 4.19 5.4 5.10] net: xilinx_emaclite: Do not print real IOMEM pointer

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

From: YueHaibing <yuehaibing@huawei.com>

Commit d0d62baa7f505bd4c59cd169692ff07ec49dde37 upstream.

Printing kernel pointers is discouraged because they might leak kernel
memory layout.  This fixes smatch warning:

drivers/net/ethernet/xilinx/xilinx_emaclite.c:1191 xemaclite_of_probe() warn:
 argument 4 to %08lX specifier is cast from pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 909a008f9927..26cd42bfef0c 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1180,9 +1180,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
 	}
 
 	dev_info(dev,
-		 "Xilinx EmacLite at 0x%08X mapped to 0x%08X, irq=%d\n",
-		 (unsigned int __force)ndev->mem_start,
-		 (unsigned int __force)lp->base_addr, ndev->irq);
+		 "Xilinx EmacLite at 0x%08X mapped to 0x%p, irq=%d\n",
+		 (unsigned int __force)ndev->mem_start, lp->base_addr, ndev->irq);
 	return 0;
 
 error:

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH 4.4 4.9 4.14 4.19 5.4 5.10] net: xilinx_emaclite: Do not print real IOMEM pointer

[Greg KH]

On Fri, Aug 13, 2021 at 12:28:40PM +0200, Pavel Machek wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Commit d0d62baa7f505bd4c59cd169692ff07ec49dde37 upstream.
> 
> Printing kernel pointers is discouraged because they might leak kernel
> memory layout.  This fixes smatch warning:
> 
> drivers/net/ethernet/xilinx/xilinx_emaclite.c:1191 xemaclite_of_probe() warn:
>  argument 4 to %08lX specifier is cast from pointer
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Now queued up, thanks.

greg k-h