* [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 5:55 Cai Huoqing
2021-09-01 11:07 ` Kieran Bingham
2021-09-01 18:15 ` Niklas Söderlund
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 5:55 UTC (permalink / raw)
To: caihuoqing
Cc: Niklas Söderlund, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index 711b52ba42b5..a4952711b7b1 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -1238,11 +1238,9 @@ static const struct media_entity_operations rcar_csi2_entity_ops = {
static int rcsi2_probe_resources(struct rcar_csi2 *priv,
struct platform_device *pdev)
{
- struct resource *res;
int irq, ret;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:55 [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 11:07 ` Kieran Bingham
2021-09-01 18:15 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-09-01 11:07 UTC (permalink / raw)
To: Cai Huoqing
Cc: Niklas Söderlund, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index 711b52ba42b5..a4952711b7b1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -1238,11 +1238,9 @@ static const struct media_entity_operations rcar_csi2_entity_ops = {
> static int rcsi2_probe_resources(struct rcar_csi2 *priv,
> struct platform_device *pdev)
> {
> - struct resource *res;
> int irq, ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:55 [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 11:07 ` Kieran Bingham
@ 2021-09-01 18:15 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2021-09-01 18:15 UTC (permalink / raw)
To: Cai Huoqing
Cc: Mauro Carvalho Chehab, linux-media, linux-renesas-soc, linux-kernel
Hello Cai,
Thanks for your work.
On 2021-09-01 13:55:09 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index 711b52ba42b5..a4952711b7b1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -1238,11 +1238,9 @@ static const struct media_entity_operations rcar_csi2_entity_ops = {
> static int rcsi2_probe_resources(struct rcar_csi2 *priv,
> struct platform_device *pdev)
> {
> - struct resource *res;
> int irq, ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-01 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:55 [PATCH] media: rcar-csi2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 11:07 ` Kieran Bingham
2021-09-01 18:15 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.