All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Upton <oupton@google.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Reiji Watanabe <reijiw@google.com>,
	Jing Zhang <jingzhangos@google.com>,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH v3 01/12] KVM: arm64: selftests: Add MMIO readl/writel support
Date: Wed, 1 Sep 2021 21:23:25 +0000	[thread overview]
Message-ID: <YS/vTVPi7Iam+ZXX@google.com> (raw)
In-Reply-To: <20210901211412.4171835-2-rananta@google.com>

On Wed, Sep 01, 2021 at 09:14:01PM +0000, Raghavendra Rao Ananta wrote:
> Define the readl() and writel() functions for the guests to
> access (4-byte) the MMIO region.
> 
> The routines, and their dependents, are inspired from the kernel's
> arch/arm64/include/asm/io.h and arch/arm64/include/asm/barrier.h.
> 
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
>  .../selftests/kvm/include/aarch64/processor.h | 45 ++++++++++++++++++-
>  1 file changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
> index c0273aefa63d..3cbaf5c1e26b 100644
> --- a/tools/testing/selftests/kvm/include/aarch64/processor.h
> +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
> @@ -130,6 +130,49 @@ void vm_install_sync_handler(struct kvm_vm *vm,
>  	val;								  \
>  })
>  
> -#define isb()	asm volatile("isb" : : : "memory")
> +#define isb()		asm volatile("isb" : : : "memory")

Is this a stray diff?

Otherwise:

Reviewed-by: Oliver Upton <oupton@google.com>

WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oupton@google.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Peter Shier <pshier@google.com>,
	linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 01/12] KVM: arm64: selftests: Add MMIO readl/writel support
Date: Wed, 1 Sep 2021 21:23:25 +0000	[thread overview]
Message-ID: <YS/vTVPi7Iam+ZXX@google.com> (raw)
In-Reply-To: <20210901211412.4171835-2-rananta@google.com>

On Wed, Sep 01, 2021 at 09:14:01PM +0000, Raghavendra Rao Ananta wrote:
> Define the readl() and writel() functions for the guests to
> access (4-byte) the MMIO region.
> 
> The routines, and their dependents, are inspired from the kernel's
> arch/arm64/include/asm/io.h and arch/arm64/include/asm/barrier.h.
> 
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
>  .../selftests/kvm/include/aarch64/processor.h | 45 ++++++++++++++++++-
>  1 file changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
> index c0273aefa63d..3cbaf5c1e26b 100644
> --- a/tools/testing/selftests/kvm/include/aarch64/processor.h
> +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
> @@ -130,6 +130,49 @@ void vm_install_sync_handler(struct kvm_vm *vm,
>  	val;								  \
>  })
>  
> -#define isb()	asm volatile("isb" : : : "memory")
> +#define isb()		asm volatile("isb" : : : "memory")

Is this a stray diff?

Otherwise:

Reviewed-by: Oliver Upton <oupton@google.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oupton@google.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Reiji Watanabe <reijiw@google.com>,
	Jing Zhang <jingzhangos@google.com>,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH v3 01/12] KVM: arm64: selftests: Add MMIO readl/writel support
Date: Wed, 1 Sep 2021 21:23:25 +0000	[thread overview]
Message-ID: <YS/vTVPi7Iam+ZXX@google.com> (raw)
In-Reply-To: <20210901211412.4171835-2-rananta@google.com>

On Wed, Sep 01, 2021 at 09:14:01PM +0000, Raghavendra Rao Ananta wrote:
> Define the readl() and writel() functions for the guests to
> access (4-byte) the MMIO region.
> 
> The routines, and their dependents, are inspired from the kernel's
> arch/arm64/include/asm/io.h and arch/arm64/include/asm/barrier.h.
> 
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
>  .../selftests/kvm/include/aarch64/processor.h | 45 ++++++++++++++++++-
>  1 file changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
> index c0273aefa63d..3cbaf5c1e26b 100644
> --- a/tools/testing/selftests/kvm/include/aarch64/processor.h
> +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
> @@ -130,6 +130,49 @@ void vm_install_sync_handler(struct kvm_vm *vm,
>  	val;								  \
>  })
>  
> -#define isb()	asm volatile("isb" : : : "memory")
> +#define isb()		asm volatile("isb" : : : "memory")

Is this a stray diff?

Otherwise:

Reviewed-by: Oliver Upton <oupton@google.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-01 21:23 UTC|newest]

Thread overview: 159+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 21:14 [PATCH v3 00/12] KVM: arm64: selftests: Introduce arch_timer selftest Raghavendra Rao Ananta
2021-09-01 21:14 ` Raghavendra Rao Ananta
2021-09-01 21:14 ` Raghavendra Rao Ananta
2021-09-01 21:14 ` [PATCH v3 01/12] KVM: arm64: selftests: Add MMIO readl/writel support Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:23   ` Oliver Upton [this message]
2021-09-01 21:23     ` Oliver Upton
2021-09-01 21:23     ` Oliver Upton
2021-09-01 22:43     ` Raghavendra Rao Ananta
2021-09-01 22:43       ` Raghavendra Rao Ananta
2021-09-01 22:43       ` Raghavendra Rao Ananta
2021-09-02 20:17       ` Oliver Upton
2021-09-02 20:17         ` Oliver Upton
2021-09-02 20:17         ` Oliver Upton
2021-09-02 13:21   ` Andrew Jones
2021-09-02 13:21     ` Andrew Jones
2021-09-02 13:21     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 02/12] KVM: arm64: selftests: Add write_sysreg_s and read_sysreg_s Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:28   ` Oliver Upton
2021-09-01 21:28     ` Oliver Upton
2021-09-01 21:28     ` Oliver Upton
2021-09-01 22:08     ` Oliver Upton
2021-09-01 22:08       ` Oliver Upton
2021-09-01 22:08       ` Oliver Upton
2021-09-01 22:48       ` Raghavendra Rao Ananta
2021-09-01 22:48         ` Raghavendra Rao Ananta
2021-09-01 22:48         ` Raghavendra Rao Ananta
2021-09-01 23:06         ` Oliver Upton
2021-09-01 23:06           ` Oliver Upton
2021-09-01 23:06           ` Oliver Upton
2021-09-02 12:31           ` Andrew Jones
2021-09-02 12:31             ` Andrew Jones
2021-09-02 12:31             ` Andrew Jones
2021-09-02 17:55             ` Raghavendra Rao Ananta
2021-09-02 17:55               ` Raghavendra Rao Ananta
2021-09-02 17:55               ` Raghavendra Rao Ananta
2021-09-02 13:44   ` Andrew Jones
2021-09-02 13:44     ` Andrew Jones
2021-09-02 13:44     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 03/12] KVM: arm64: selftests: Add support for cpu_relax Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:29   ` Oliver Upton
2021-09-01 21:29     ` Oliver Upton
2021-09-01 21:29     ` Oliver Upton
2021-09-01 22:10   ` Oliver Upton
2021-09-01 22:10     ` Oliver Upton
2021-09-01 22:10     ` Oliver Upton
2021-09-02 13:46   ` Andrew Jones
2021-09-02 13:46     ` Andrew Jones
2021-09-02 13:46     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 04/12] KVM: arm64: selftests: Add basic support for arch_timers Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-02 14:12   ` Andrew Jones
2021-09-02 14:12     ` Andrew Jones
2021-09-02 14:12     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 05/12] KVM: arm64: selftests: Add basic support to generate delays Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-02 14:35   ` Andrew Jones
2021-09-02 14:35     ` Andrew Jones
2021-09-02 14:35     ` Andrew Jones
2021-09-02 20:20   ` Oliver Upton
2021-09-02 20:20     ` Oliver Upton
2021-09-02 20:20     ` Oliver Upton
2021-09-01 21:14 ` [PATCH v3 06/12] KVM: arm64: selftests: Add support to disable and enable local IRQs Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 23:26   ` Oliver Upton
2021-09-01 23:26     ` Oliver Upton
2021-09-01 23:26     ` Oliver Upton
2021-09-02 14:43   ` Andrew Jones
2021-09-02 14:43     ` Andrew Jones
2021-09-02 14:43     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 07/12] KVM: arm64: selftests: Add support to get the vcpuid from MPIDR_EL1 Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 23:48   ` Oliver Upton
2021-09-01 23:48     ` Oliver Upton
2021-09-01 23:48     ` Oliver Upton
2021-09-02 12:36     ` Andrew Jones
2021-09-02 12:36       ` Andrew Jones
2021-09-02 12:36       ` Andrew Jones
2021-09-02 17:52       ` Raghavendra Rao Ananta
2021-09-02 17:52         ` Raghavendra Rao Ananta
2021-09-02 17:52         ` Raghavendra Rao Ananta
2021-09-01 21:14 ` [PATCH v3 08/12] KVM: arm64: selftests: Add light-weight spinlock support Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-02 21:06   ` Oliver Upton
2021-09-02 21:06     ` Oliver Upton
2021-09-02 21:06     ` Oliver Upton
2021-09-03  8:25   ` Andrew Jones
2021-09-03  8:25     ` Andrew Jones
2021-09-03  8:25     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 09/12] KVM: arm64: selftests: Add basic GICv3 support Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-03  9:37   ` Andrew Jones
2021-09-03  9:37     ` Andrew Jones
2021-09-03  9:37     ` Andrew Jones
2021-09-01 21:14 ` [PATCH v3 10/12] KVM: arm64: selftests: Add host support for vGIC Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-02 17:28   ` Ricardo Koller
2021-09-02 17:28     ` Ricardo Koller
2021-09-02 17:28     ` Ricardo Koller
2021-09-02 17:59     ` Raghavendra Rao Ananta
2021-09-02 17:59       ` Raghavendra Rao Ananta
2021-09-02 17:59       ` Raghavendra Rao Ananta
2021-09-03 10:00   ` Andrew Jones
2021-09-03 10:00     ` Andrew Jones
2021-09-03 10:00     ` Andrew Jones
2021-09-03 20:45     ` Raghavendra Rao Ananta
2021-09-03 20:45       ` Raghavendra Rao Ananta
2021-09-03 20:45       ` Raghavendra Rao Ananta
2021-09-03 10:51   ` Andrew Jones
2021-09-03 10:51     ` Andrew Jones
2021-09-03 10:51     ` Andrew Jones
2021-09-03 20:48     ` Raghavendra Rao Ananta
2021-09-03 20:48       ` Raghavendra Rao Ananta
2021-09-03 20:48       ` Raghavendra Rao Ananta
2021-09-01 21:14 ` [PATCH v3 11/12] KVM: arm64: selftests: Add arch_timer test Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-03 10:48   ` Andrew Jones
2021-09-03 10:48     ` Andrew Jones
2021-09-03 10:48     ` Andrew Jones
2021-09-03 20:42     ` Raghavendra Rao Ananta
2021-09-03 20:42       ` Raghavendra Rao Ananta
2021-09-03 20:42       ` Raghavendra Rao Ananta
2021-09-01 21:14 ` [PATCH v3 12/12] KVM: arm64: selftests: arch_timer: Support vCPU migration Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-01 21:14   ` Raghavendra Rao Ananta
2021-09-03 11:05   ` Andrew Jones
2021-09-03 11:05     ` Andrew Jones
2021-09-03 11:05     ` Andrew Jones
2021-09-03 20:53     ` Raghavendra Rao Ananta
2021-09-03 20:53       ` Raghavendra Rao Ananta
2021-09-03 20:53       ` Raghavendra Rao Ananta
2021-09-06  6:39       ` Andrew Jones
2021-09-06  6:39         ` Andrew Jones
2021-09-06  6:39         ` Andrew Jones
2021-09-07 16:14         ` Raghavendra Rao Ananta
2021-09-07 16:14           ` Raghavendra Rao Ananta
2021-09-07 16:14           ` Raghavendra Rao Ananta
2021-09-07 16:20           ` Andrew Jones
2021-09-07 16:20             ` Andrew Jones
2021-09-07 16:20             ` Andrew Jones
2021-09-01 22:04 ` [PATCH v3 00/12] KVM: arm64: selftests: Introduce arch_timer selftest Oliver Upton
2021-09-01 22:04   ` Oliver Upton
2021-09-01 22:04   ` Oliver Upton
2021-09-01 22:05 ` Oliver Upton
2021-09-01 22:05   ` Oliver Upton
2021-09-01 22:05   ` Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YS/vTVPi7Iam+ZXX@google.com \
    --to=oupton@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=jingzhangos@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=pshier@google.com \
    --cc=rananta@google.com \
    --cc=reijiw@google.com \
    --cc=ricarkol@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.