From: Patrick Steinhardt <ps@pks.im>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
Glenn Washburn <development@efficientek.com>,
grub-devel@gnu.org
Subject: Re: [PATCH 00/12] Grub-shell improvements
Date: Mon, 30 Aug 2021 19:50:51 +0200 [thread overview]
Message-ID: <YS0aezAQ3/J5ckXh@tanuki> (raw)
In-Reply-To: <20210830183315.65b020ab@primarylaptop.localdomain>
[-- Attachment #1: Type: text/plain, Size: 4711 bytes --]
On Mon, Aug 30, 2021 at 06:33:15PM +0200, Denis 'GNUtoo' Carikli wrote:
> On Mon, 30 Aug 2021 17:23:44 +0200
> Daniel Kiper <daniel.kiper@oracle.com> wrote:
>
> > CC-ing Denis and Patrick...
> >
> > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote:
> > > Hi Daniel,
> > >
> > > On Thu, 26 Aug 2021 20:00:32 +0200
> > > Daniel Kiper <daniel.kiper@oracle.com> wrote:
> > >
> > > > Hi Glenn,
> > > >
> > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote:
> > > > > Hi Daniel,
> > > > >
> > > > > What are the chances this patch series can be reviewed in the
> > > > > near future? Some feedback would be greatly appreciated.
> > > >
> > > > I can see the following patches from you waiting in my review
> > > > queue:
> > > > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for
> > > > cryptodisks+luks2 and a few other things.
> > > > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html
> > > > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount
> > > > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html
> > > > - [PATCH 0/5] Testing improvements
> > > > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html
> > > > - [CI 00/17] Gitlab CI and test framework improvements
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html
> > > > - [PROCFS 0/5] Add and improve (proc) entries
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html
> > > > - [PATCH 0/4] Various LUKS2 improvements
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html
> > > > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html
> > > > - [PATCH] fs: Allow number of blocks in block list to be
> > > > optional, defaulting length to device length
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html
> > > > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a
> > > > dash-insensitive manner
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html
> > > > - [PATCH] command: Add silent mode to read command to suppress
> > > > input echo
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html
> > > > - [PATCH 0/2] Allow overriding commands
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html
> > > > - [PATCH 00/12] Grub-shell improvements
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html
> > > > - [PATCH v2 0/8] Various fixes/improvements for tests
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html
> > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to
> > > > crypto modules
> > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html
> > > >
> > > > Please sort them in the order of importance/preference/... Then I
> > > > will be looking at them (more or less) in that order, one patch
> > > > set at a time.
> > > >
> > > > I hope I did not miss any of your patches.
> > >
> > > As far as I can tell, this is the full list.
> >
> > Great!
> >
> > > My order preference is as follows:
> > >
> > > These two patches are only first because it should be a quick
> > > review.
> > > - [PATCH] command: Add silent mode to read command to suppress
> > > input echo
> > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html
> > > - [PATCH] fs: Allow number of blocks in block list to be optional,
> > > defaulting length to device length
> > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html
> >
> > OK.
> >
> > > This is a high priority because I think it should be merged before
> > > the keyfile and detached header support patch series. If this is
> > > merged, I'll submit and updated keyfile and detached header patch
> > > series that works with this patch series.
> > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto
> > > modules
> > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html
> >
> > Denis, Patrick, are you both OK with this?
> I'm OK with it.
>
> The "Refactor/improve cryptomount data passing to crypto modules" looks
> way cleaner than what we had before: it can scale better than the
> previous design because it's more generic, it can be extended more
> easily, and we can have more fine grained communication between the
> cryptodisk and the backends.
Agreed, this has been a pain point in the current architecture.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-30 17:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 1:57 [PATCH 00/12] Grub-shell improvements Glenn Washburn
2021-04-01 1:57 ` [PATCH 01/12] grub-shell: Allow specifying non-default trim line contents Glenn Washburn
2021-04-01 1:57 ` [PATCH 02/12] grub-shell: Trim line should always be matched from the beginning of the line Glenn Washburn
2021-04-01 1:57 ` [PATCH 03/12] grub-shell: Only show grub-mkrescue output if it returns an error Glenn Washburn
2021-04-01 1:57 ` [PATCH 04/12] grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar Glenn Washburn
2021-04-01 1:57 ` [PATCH 05/12] grub-shell: Put all generated files into working dir and use better file names Glenn Washburn
2021-04-01 1:57 ` [PATCH 06/12] grub-shell: Add grub output logfile with grub-shell --debug Glenn Washburn
2021-04-01 1:57 ` [PATCH 07/12] grub-shell: Set exit status to qemu exit status Glenn Washburn
2021-04-01 1:57 ` [PATCH 08/12] tests: Allow turning on shell tracing from environment variables Glenn Washburn
2021-04-01 1:57 ` [PATCH 09/12] grub-shell: Add --verbose to mkrescue when $debug is greater than 2 Glenn Washburn
2021-04-01 1:57 ` [PATCH 10/12] grub-shell: Only turn on qemu head when large debug value is specified Glenn Washburn
2021-04-01 1:57 ` [PATCH 11/12] grub-shell: Use malta qemu-mips machine type instead off non-existant indy Glenn Washburn
2021-04-01 1:57 ` [PATCH 12/12] grub-shell: Update qemu UEFI firmware names to be more generic Glenn Washburn
2021-08-25 23:06 ` [PATCH 00/12] Grub-shell improvements Glenn Washburn
2021-08-26 18:00 ` Daniel Kiper
2021-08-26 22:08 ` Glenn Washburn
2021-08-30 15:23 ` Daniel Kiper
2021-08-30 16:33 ` Denis 'GNUtoo' Carikli
2021-08-30 17:50 ` Patrick Steinhardt [this message]
2021-09-14 11:04 ` IS: Glenn's patches status WAS: " Daniel Kiper
2021-09-14 17:27 ` Glenn Washburn
2021-09-15 16:15 ` Daniel Kiper
2021-09-15 16:18 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS0aezAQ3/J5ckXh@tanuki \
--to=ps@pks.im \
--cc=GNUtoo@cyberdimension.org \
--cc=daniel.kiper@oracle.com \
--cc=development@efficientek.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.