All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>
Cc: Glenn Washburn <development@efficientek.com>
Subject: [PATCH 12/12] grub-shell: Update qemu UEFI firmware names to be more generic
Date: Wed, 31 Mar 2021 20:57:51 -0500	[thread overview]
Message-ID: <ce8684c763317ab4a2a91034e1e8e153815ebd2b.1617240986.git.development@efficientek.com> (raw)
In-Reply-To: <cover.1617240986.git.development@efficientek.com>

The current qemu firmware paths for arm-efi and arm64-efi are hardcoded
and not available on Ubuntu/Debian. Make these paths relative and basenames
generic. The idea is that regardless where or what names firmware images
are installed under they can be copied and renamed into a temporary
directory. Then use the -L argument to qemu to point to that directory.

For convenience, the GRUB source directory which build grub-shell will be
added to the list of firmware paths that qemu will search. So all that is
needed is to copy the firmwares to the source directory with potential
renames.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/util/grub-shell.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index c69fbd080..1bdfbbeba 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -74,7 +74,7 @@ exec_show_error () {
 work_directory=${WORKDIR:-`mktemp -d "${TMPDIR:-/tmp}/grub-shell.XXXXXXXXXX"`} || exit 1
 
 . "${builddir}/grub-core/modinfo.sh"
-qemuopts="${GRUB_QEMU_OPTS}"
+qemuopts="${GRUB_QEMU_OPTS} -L ${srcdir}"
 serial_port=com0
 serial_null=
 halt_cmd=halt
@@ -194,7 +194,7 @@ case "${grub_modinfo_target_cpu}-${grub_modinfo_platform}" in
 	boot=hd
 	console=console
 	trim=1
-	qemuopts="-machine virt -cpu cortex-a57 -bios /usr/share/qemu-efi/QEMU_EFI.fd $qemuopts"
+	qemuopts="-machine virt -cpu cortex-a57 -bios OVMF-aarch64.fd $qemuopts"
 	disk="device virtio-blk-device,drive=hd1 -drive if=none,id=hd1,file="
 	serial_port=
 	;;
@@ -203,7 +203,7 @@ case "${grub_modinfo_target_cpu}-${grub_modinfo_platform}" in
 	boot=hd
 	console=console
 	trim=1
-	qemuopts="-machine virt -bios /usr/share/ovmf-arm/QEMU_EFI.fd $qemuopts"
+	qemuopts="-machine virt -bios OVMF-arm.fd $qemuopts"
 	disk="device virtio-blk-device,drive=hd1 -drive if=none,id=hd1,file="
 	serial_port=efi0
 	;;
-- 
2.27.0



  parent reply	other threads:[~2021-04-01  1:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  1:57 [PATCH 00/12] Grub-shell improvements Glenn Washburn
2021-04-01  1:57 ` [PATCH 01/12] grub-shell: Allow specifying non-default trim line contents Glenn Washburn
2021-04-01  1:57 ` [PATCH 02/12] grub-shell: Trim line should always be matched from the beginning of the line Glenn Washburn
2021-04-01  1:57 ` [PATCH 03/12] grub-shell: Only show grub-mkrescue output if it returns an error Glenn Washburn
2021-04-01  1:57 ` [PATCH 04/12] grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar Glenn Washburn
2021-04-01  1:57 ` [PATCH 05/12] grub-shell: Put all generated files into working dir and use better file names Glenn Washburn
2021-04-01  1:57 ` [PATCH 06/12] grub-shell: Add grub output logfile with grub-shell --debug Glenn Washburn
2021-04-01  1:57 ` [PATCH 07/12] grub-shell: Set exit status to qemu exit status Glenn Washburn
2021-04-01  1:57 ` [PATCH 08/12] tests: Allow turning on shell tracing from environment variables Glenn Washburn
2021-04-01  1:57 ` [PATCH 09/12] grub-shell: Add --verbose to mkrescue when $debug is greater than 2 Glenn Washburn
2021-04-01  1:57 ` [PATCH 10/12] grub-shell: Only turn on qemu head when large debug value is specified Glenn Washburn
2021-04-01  1:57 ` [PATCH 11/12] grub-shell: Use malta qemu-mips machine type instead off non-existant indy Glenn Washburn
2021-04-01  1:57 ` Glenn Washburn [this message]
2021-08-25 23:06 ` [PATCH 00/12] Grub-shell improvements Glenn Washburn
2021-08-26 18:00   ` Daniel Kiper
2021-08-26 22:08     ` Glenn Washburn
2021-08-30 15:23       ` Daniel Kiper
2021-08-30 16:33         ` Denis 'GNUtoo' Carikli
2021-08-30 17:50           ` Patrick Steinhardt
2021-09-14 11:04         ` IS: Glenn's patches status WAS: " Daniel Kiper
2021-09-14 17:27           ` Glenn Washburn
2021-09-15 16:15             ` Daniel Kiper
2021-09-15 16:18               ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce8684c763317ab4a2a91034e1e8e153815ebd2b.1617240986.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.