From: Andrew Lunn <andrew@lunn.ch>
To: Saravana Kannan <saravanak@google.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
netdev@vger.kernel.org, kernel-team@android.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property
Date: Mon, 23 Aug 2021 21:58:12 +0200 [thread overview]
Message-ID: <YSP91FfbzUHKiv+L@lunn.ch> (raw)
In-Reply-To: <CAGETcx_xJCqOWtwZ9Ee2+0sPGNLM5=F=djtbdYENkAYZa0ynqQ@mail.gmail.com>
> PHY seems to be one of those cases where it's okay to have the
> compatible property but also okay to not have it.
Correct. They are like PCI or USB devices. You can ask it, what are
you? There are two registers in standard locations which give you a
vendor and product ID. We use that to find the correct driver.
You only need a compatible when things are not so simple.
1) The IDs are wrong. Some silicon vendors do stupid things
2) Chicken/egg problems, you cannot read the ID registers until you
load the driver and some resource is enabled.
3) It is a C45 devices, e.g. part of clause 45 of 802.3, which
requires a different protocol to be talked over the bus. So the
compatible string tells you to talk C45 to get the IDs.
4) It is not a PHY, but some sort of other MDIO device, and hence
there are no ID registers.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Saravana Kannan <saravanak@google.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
netdev@vger.kernel.org, kernel-team@android.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property
Date: Mon, 23 Aug 2021 21:58:12 +0200 [thread overview]
Message-ID: <YSP91FfbzUHKiv+L@lunn.ch> (raw)
In-Reply-To: <CAGETcx_xJCqOWtwZ9Ee2+0sPGNLM5=F=djtbdYENkAYZa0ynqQ@mail.gmail.com>
> PHY seems to be one of those cases where it's okay to have the
> compatible property but also okay to not have it.
Correct. They are like PCI or USB devices. You can ask it, what are
you? There are two registers in standard locations which give you a
vendor and product ID. We use that to find the correct driver.
You only need a compatible when things are not so simple.
1) The IDs are wrong. Some silicon vendors do stupid things
2) Chicken/egg problems, you cannot read the ID registers until you
load the driver and some resource is enabled.
3) It is a C45 devices, e.g. part of clause 45 of 802.3, which
requires a different protocol to be talked over the bus. So the
compatible string tells you to talk C45 to get the IDs.
4) It is not a PHY, but some sort of other MDIO device, and hence
there are no ID registers.
Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-08-23 19:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 2:17 [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property Saravana Kannan
2021-08-18 17:00 ` Rob Herring
[not found] ` <CGME20210823120849eucas1p11d3919886444358472be3edd1c662755@eucas1p1.samsung.com>
2021-08-23 12:08 ` Marek Szyprowski
2021-08-23 12:08 ` Marek Szyprowski
2021-08-23 12:42 ` Rob Herring
2021-08-23 12:42 ` Rob Herring
2021-08-23 13:16 ` Andrew Lunn
2021-08-23 13:16 ` Andrew Lunn
2021-08-23 18:13 ` Saravana Kannan
2021-08-23 18:13 ` Saravana Kannan
2021-08-23 19:50 ` Andrew Lunn
2021-08-23 19:50 ` Andrew Lunn
2021-08-24 6:52 ` Marek Szyprowski
2021-08-24 6:52 ` Marek Szyprowski
2021-08-23 18:22 ` Saravana Kannan
2021-08-23 18:22 ` Saravana Kannan
2021-08-23 19:58 ` Andrew Lunn [this message]
2021-08-23 19:58 ` Andrew Lunn
2021-08-23 20:48 ` Saravana Kannan
2021-08-23 20:48 ` Saravana Kannan
2021-08-23 22:01 ` Andrew Lunn
2021-08-23 22:01 ` Andrew Lunn
2021-08-23 22:08 ` Rob Herring
2021-08-23 22:08 ` Rob Herring
2021-08-24 7:03 ` Marek Szyprowski
2021-08-24 7:03 ` Marek Szyprowski
2021-08-24 7:31 ` Saravana Kannan
2021-08-24 7:31 ` Saravana Kannan
2021-09-01 2:37 ` Saravana Kannan
2021-09-01 2:37 ` Saravana Kannan
2021-09-01 7:22 ` Marek Szyprowski
2021-09-01 7:22 ` Marek Szyprowski
2021-09-08 21:58 ` [PATCH v1] RFC: of: property: fix phy-hanlde issue Saravana Kannan
2021-09-09 8:03 ` Marek Szyprowski
2021-09-14 0:54 ` Saravana Kannan
2021-09-14 4:44 ` Saravana Kannan
2021-09-14 6:15 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSP91FfbzUHKiv+L@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.