From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com,
beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com,
swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com,
josef@toxicpanda.com, hch@infradead.org, hare@suse.de,
bvanassche@acm.org, ming.lei@redhat.com,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-mmc@vger.kernel.org, dm-devel@redhat.com,
nbd@other.debian.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()
Date: Tue, 24 Aug 2021 06:52:53 +0100 [thread overview]
Message-ID: <YSSJNTxyLHu/LsNJ@infradead.org> (raw)
In-Reply-To: <20210823202930.137278-2-mcgrof@kernel.org>
On Mon, Aug 23, 2021 at 01:29:21PM -0700, Luis Chamberlain wrote:
> The single put_disk() is useful if you know you're not doing
> a cleanup after add_disk(), but since we want to add support
> for that, just use the normal form of blk_cleanup_disk() to
> cleanup the queue and put the disk.
Hmm, I don't think this is correct. The request_queue is owned by the
core SCSI code.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com,
beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com,
swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com,
josef@toxicpanda.com, hch@infradead.org, hare@suse.de,
bvanassche@acm.org, ming.lei@redhat.com,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-mmc@vger.kernel.org, dm-devel@redhat.com,
nbd@other.debian.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()
Date: Tue, 24 Aug 2021 06:52:53 +0100 [thread overview]
Message-ID: <YSSJNTxyLHu/LsNJ@infradead.org> (raw)
In-Reply-To: <20210823202930.137278-2-mcgrof@kernel.org>
On Mon, Aug 23, 2021 at 01:29:21PM -0700, Luis Chamberlain wrote:
> The single put_disk() is useful if you know you're not doing
> a cleanup after add_disk(), but since we want to add support
> for that, just use the normal form of blk_cleanup_disk() to
> cleanup the queue and put the disk.
Hmm, I don't think this is correct. The request_queue is owned by the
core SCSI code.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: ulf.hansson@linaro.org, snitzer@redhat.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, agk@redhat.com, beanhuo@micron.com,
ming.lei@redhat.com, sagi@grimberg.me,
linux-scsi@vger.kernel.org, hch@infradead.org,
jejb@linux.ibm.com, josef@toxicpanda.com, nbd@other.debian.org,
linux-block@vger.kernel.org, avri.altman@wdc.com,
kbusch@kernel.org, swboyd@chromium.org, bvanassche@acm.org,
axboe@kernel.dk, martin.petersen@oracle.com,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com
Subject: Re: [dm-devel] [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()
Date: Tue, 24 Aug 2021 06:52:53 +0100 [thread overview]
Message-ID: <YSSJNTxyLHu/LsNJ@infradead.org> (raw)
In-Reply-To: <20210823202930.137278-2-mcgrof@kernel.org>
On Mon, Aug 23, 2021 at 01:29:21PM -0700, Luis Chamberlain wrote:
> The single put_disk() is useful if you know you're not doing
> a cleanup after add_disk(), but since we want to add support
> for that, just use the normal form of blk_cleanup_disk() to
> cleanup the queue and put the disk.
Hmm, I don't think this is correct. The request_queue is owned by the
core SCSI code.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-24 5:57 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 20:29 [PATCH 00/10] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 5:52 ` Christoph Hellwig [this message]
2021-08-24 5:52 ` [dm-devel] " Christoph Hellwig
2021-08-24 5:52 ` Christoph Hellwig
2021-08-27 18:27 ` Luis Chamberlain
2021-08-27 18:27 ` [dm-devel] " Luis Chamberlain
2021-08-27 18:27 ` Luis Chamberlain
2021-08-28 7:26 ` Christoph Hellwig
2021-08-28 7:26 ` [dm-devel] " Christoph Hellwig
2021-08-28 7:26 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 02/10] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 5:58 ` Christoph Hellwig
2021-08-24 5:58 ` Christoph Hellwig
2021-08-24 5:58 ` [dm-devel] " Christoph Hellwig
2021-08-23 20:29 ` [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:00 ` Christoph Hellwig
2021-08-24 6:00 ` [dm-devel] " Christoph Hellwig
2021-08-24 6:00 ` Christoph Hellwig
2021-08-27 18:28 ` Luis Chamberlain
2021-08-27 18:28 ` [dm-devel] " Luis Chamberlain
2021-08-27 18:28 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 04/10] scsi/sr: add error handling support for add_disk() Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:04 ` Christoph Hellwig
2021-08-24 6:04 ` [dm-devel] " Christoph Hellwig
2021-08-24 6:04 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 05/10] nvme: " Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:09 ` Christoph Hellwig
2021-08-24 6:09 ` Christoph Hellwig
2021-08-24 6:09 ` [dm-devel] " Christoph Hellwig
2021-08-27 18:32 ` Luis Chamberlain
2021-08-27 18:32 ` [dm-devel] " Luis Chamberlain
2021-08-27 18:32 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 06/10] mmc/core/block: " Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:13 ` Christoph Hellwig
2021-08-24 6:13 ` [dm-devel] " Christoph Hellwig
2021-08-24 6:13 ` Christoph Hellwig
2021-08-27 18:42 ` Luis Chamberlain
2021-08-27 18:42 ` [dm-devel] " Luis Chamberlain
2021-08-27 18:42 ` Luis Chamberlain
2021-08-28 7:32 ` Christoph Hellwig
2021-08-28 7:32 ` [dm-devel] " Christoph Hellwig
2021-08-28 7:32 ` Christoph Hellwig
2021-08-30 20:42 ` Luis Chamberlain
2021-08-30 20:42 ` [dm-devel] " Luis Chamberlain
2021-08-30 20:42 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 07/10] md: " Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:15 ` Christoph Hellwig
2021-08-24 6:15 ` [dm-devel] " Christoph Hellwig
2021-08-24 6:15 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 08/10] dm: add add_disk() error handling Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:21 ` Christoph Hellwig
2021-08-24 6:21 ` Christoph Hellwig
2021-08-24 6:21 ` [dm-devel] " Christoph Hellwig
2021-08-27 18:55 ` Luis Chamberlain
2021-08-27 18:55 ` [dm-devel] " Luis Chamberlain
2021-08-27 18:55 ` Luis Chamberlain
2021-08-28 7:35 ` Christoph Hellwig
2021-08-28 7:35 ` [dm-devel] " Christoph Hellwig
2021-08-28 7:35 ` Christoph Hellwig
2021-08-30 21:00 ` Luis Chamberlain
2021-08-30 21:00 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:00 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 09/10] loop: add error handling support for add_disk() Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:25 ` Christoph Hellwig
2021-08-24 6:25 ` Christoph Hellwig
2021-08-24 6:25 ` [dm-devel] " Christoph Hellwig
2021-08-23 20:29 ` [PATCH 10/10] nbd: " Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] " Luis Chamberlain
2021-08-23 20:29 ` Luis Chamberlain
2021-08-24 6:27 ` Christoph Hellwig
2021-08-24 6:27 ` [dm-devel] " Christoph Hellwig
2021-08-24 6:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSSJNTxyLHu/LsNJ@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=agk@redhat.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.