From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <chao.yu@linux.dev>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix wrong option name printed by parse_options()
Date: Tue, 24 Aug 2021 10:26:45 -0700 [thread overview]
Message-ID: <YSUr1GS0M7weoRTt@google.com> (raw)
In-Reply-To: <20210824011948.15408-1-chao@kernel.org>
On 08/24, Chao Yu wrote:
> It prints below kernel message during mounting w/ checkpoint=disable
> option:
>
> "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable"
>
> Fix typo "checkpoint=merge" w/ "checkpoint_merge"
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/super.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 49e153fd8183..88c66e46bd5c 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1289,6 +1289,12 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> return -EINVAL;
> }
>
> + if (test_opt(sbi, DISABLE_CHECKPOINT) &&
> + test_opt(sbi, MERGE_CHECKPOINT)) {
> + f2fs_err(sbi, "checkpoint_merge cannot be used with checkpoint=disable\n");
> + return -EINVAL;
What about disabling MERGE_CHECKPOINT autmatically?
> + }
> +
> /* Not pass down write hints if the number of active logs is lesser
> * than NR_CURSEG_PERSIST_TYPE.
> */
> --
> 2.32.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao.yu@linux.dev>
Subject: Re: [PATCH] f2fs: fix wrong option name printed by parse_options()
Date: Tue, 24 Aug 2021 10:26:45 -0700 [thread overview]
Message-ID: <YSUr1GS0M7weoRTt@google.com> (raw)
In-Reply-To: <20210824011948.15408-1-chao@kernel.org>
On 08/24, Chao Yu wrote:
> It prints below kernel message during mounting w/ checkpoint=disable
> option:
>
> "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable"
>
> Fix typo "checkpoint=merge" w/ "checkpoint_merge"
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/super.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 49e153fd8183..88c66e46bd5c 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1289,6 +1289,12 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> return -EINVAL;
> }
>
> + if (test_opt(sbi, DISABLE_CHECKPOINT) &&
> + test_opt(sbi, MERGE_CHECKPOINT)) {
> + f2fs_err(sbi, "checkpoint_merge cannot be used with checkpoint=disable\n");
> + return -EINVAL;
What about disabling MERGE_CHECKPOINT autmatically?
> + }
> +
> /* Not pass down write hints if the number of active logs is lesser
> * than NR_CURSEG_PERSIST_TYPE.
> */
> --
> 2.32.0
next prev parent reply other threads:[~2021-08-24 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 1:19 [PATCH] f2fs: fix wrong option name printed by parse_options() Chao Yu
2021-08-24 1:19 ` [f2fs-dev] " Chao Yu
2021-08-24 1:31 ` Chao Yu
2021-08-24 1:31 ` Chao Yu
2021-08-24 17:26 ` Jaegeuk Kim [this message]
2021-08-24 17:26 ` Jaegeuk Kim
2021-08-24 23:35 ` Chao Yu
2021-08-24 23:35 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSUr1GS0M7weoRTt@google.com \
--to=jaegeuk@kernel.org \
--cc=chao.yu@linux.dev \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.