* [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path
@ 2021-08-25 7:14 Petr Vorel
2021-08-25 7:29 ` Leo Liang
2021-08-25 14:54 ` Cyril Hrubis
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2021-08-25 7:14 UTC (permalink / raw)
To: ltp
Document changed behavior in 205a43dfb ("Make argument to tst_umount an
absolute path").
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
doc/shell-test-api.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/shell-test-api.txt b/doc/shell-test-api.txt
index ecdbe9e6a..afc01dd01 100644
--- a/doc/shell-test-api.txt
+++ b/doc/shell-test-api.txt
@@ -515,8 +515,8 @@ The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
'$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
exist prior to the function call.
-If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
-not mounted (present in '/proc/mounts') it's noop.
+If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')
+to the 'tst_umount' is not mounted (present in '/proc/mounts') it's noop.
Otherwise it retries to umount the filesystem a few times on failure.
This is a workaround since there are daemons dumb enough to probe all newly
mounted filesystems, and prevents them from being umounted shortly after they
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path
2021-08-25 7:14 [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path Petr Vorel
@ 2021-08-25 7:29 ` Leo Liang
2021-08-25 14:54 ` Cyril Hrubis
1 sibling, 0 replies; 4+ messages in thread
From: Leo Liang @ 2021-08-25 7:29 UTC (permalink / raw)
To: ltp
On Wed, Aug 25, 2021 at 09:14:20AM +0200, Petr Vorel wrote:
> Document changed behavior in 205a43dfb ("Make argument to tst_umount an
> absolute path").
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> doc/shell-test-api.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path
2021-08-25 7:14 [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path Petr Vorel
2021-08-25 7:29 ` Leo Liang
@ 2021-08-25 14:54 ` Cyril Hrubis
2021-08-27 7:03 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2021-08-25 14:54 UTC (permalink / raw)
To: ltp
Hi!
> Document changed behavior in 205a43dfb ("Make argument to tst_umount an
> absolute path").
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> doc/shell-test-api.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/shell-test-api.txt b/doc/shell-test-api.txt
> index ecdbe9e6a..afc01dd01 100644
> --- a/doc/shell-test-api.txt
> +++ b/doc/shell-test-api.txt
> @@ -515,8 +515,8 @@ The 'tst_mount' mounts '$TST_DEVICE' of '$TST_FS_TYPE' (optional) to
> '$TST_MNT_PARAMS'. The '$TST_MNTPOINT' directory is created if it didn't
> exist prior to the function call.
>
> -If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
> -not mounted (present in '/proc/mounts') it's noop.
> +If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')
^ ^
must absolute
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path
2021-08-25 14:54 ` Cyril Hrubis
@ 2021-08-27 7:03 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-08-27 7:03 UTC (permalink / raw)
To: ltp
Hi Cyril,
> > -If the path passed (optional, defaults to '$TST_MNTPOINT') to the 'tst_umount' is
> > -not mounted (present in '/proc/mounts') it's noop.
> > +If the path passed (optional, should be full path, defaults to '$TST_MNTPOINT')
> ^ ^
> must absolute
I used 'should' because the warning, but 'must' is more appropriate.
Fixed and merged.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-27 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 7:14 [LTP] [PATCH 1/1] doc: TST_MNTPOINT should be full path Petr Vorel
2021-08-25 7:29 ` Leo Liang
2021-08-25 14:54 ` Cyril Hrubis
2021-08-27 7:03 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.