From: Andrew Lunn <andrew@lunn.ch>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Adam Ford <aford173@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
Date: Thu, 26 Aug 2021 21:09:35 +0200 [thread overview]
Message-ID: <YSfm7zKz5BTNUXDz@lunn.ch> (raw)
In-Reply-To: <cc3f0ae7-c1c5-12b3-46b4-0c7d1857a615@omp.ru>
On Thu, Aug 26, 2021 at 10:02:07PM +0300, Sergey Shtylyov wrote:
> On 8/26/21 9:57 PM, Andrew Lunn wrote:
>
> >>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC mode register(CCC) present only in R-Car Gen3?
> >>
> >> Yes.
> >> But you feature naming is totally misguiding, nevertheless...
> >
> > It can still be changed.
>
> Thank goodness, yea!
We have to live with the first version of this in the git history, but
we can add more patches fixing up whatever is broken in the unreviewed
code which got merged.
> > Just suggest a new name.
>
> I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for the gPTP working also in CONFIG mode
> (CCC.GAC controls this feature).
Biju, please could you work on a couple of patches to change the names.
I also suggest you post further refactoring patches as RFC. We might
get a chance to review them then.
Andrew
next prev parent reply other threads:[~2021-08-26 19:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 7:01 [PATCH net-next 00/13] Add Factorisation code to support Gigabit Ethernet driver Biju Das
2021-08-25 7:01 ` [PATCH net-next 01/13] ravb: Remove the macros NUM_TX_DESC_GEN[23] Biju Das
2021-08-25 14:30 ` Sergey Shtylyov
2021-08-25 7:01 ` [PATCH net-next 02/13] ravb: Add multi_irq to struct ravb_hw_info Biju Das
2021-08-25 18:49 ` Sergey Shtylyov
2021-08-25 19:10 ` Sergey Shtylyov
2021-08-25 7:01 ` [PATCH net-next 03/13] ravb: Add no_ptp_cfg_active " Biju Das
2021-08-25 20:17 ` Sergey Shtylyov
2021-08-25 7:01 ` [PATCH net-next 04/13] ravb: Add ptp_cfg_active " Biju Das
2021-08-25 20:38 ` Sergey Shtylyov
2021-08-26 6:20 ` Biju Das
2021-08-26 10:29 ` Sergey Shtylyov
2021-08-26 10:34 ` Biju Das
2021-08-26 10:42 ` Sergey Shtylyov
2021-08-26 10:52 ` Biju Das
2021-08-26 18:06 ` Sergei Shtylyov
2021-08-26 18:57 ` Andrew Lunn
2021-08-26 19:02 ` Sergey Shtylyov
2021-08-26 19:09 ` Andrew Lunn [this message]
2021-08-26 19:37 ` Biju Das
2021-08-26 20:03 ` Sergey Shtylyov
2021-08-27 6:36 ` Biju Das
2021-08-27 15:48 ` Sergey Shtylyov
2021-08-27 15:55 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 05/13] ravb: Factorise ravb_ring_free function Biju Das
2021-08-25 20:53 ` Sergey Shtylyov
2021-08-25 7:01 ` [PATCH net-next 06/13] ravb: Factorise ravb_ring_format function Biju Das
2021-08-26 18:54 ` Sergey Shtylyov
2021-08-26 19:34 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 07/13] ravb: Factorise ravb_ring_init function Biju Das
2021-08-26 20:27 ` Sergey Shtylyov
2021-08-25 7:01 ` [PATCH net-next 08/13] ravb: Factorise ravb_rx function Biju Das
2021-08-26 20:41 ` Sergey Shtylyov
2021-08-27 6:28 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 09/13] ravb: Factorise ravb_adjust_link function Biju Das
2021-08-25 7:01 ` [PATCH net-next 10/13] ravb: Factorise ravb_set_features Biju Das
2021-08-27 19:16 ` Sergey Shtylyov
2021-08-28 9:20 ` Biju Das
2021-08-28 11:35 ` Sergey Shtylyov
2021-08-28 12:45 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 11/13] ravb: Factorise ravb_dmac_init function Biju Das
2021-08-27 19:36 ` Sergey Shtylyov
2021-08-28 9:28 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 12/13] ravb: Factorise ravb_emac_init function Biju Das
2021-08-27 19:52 ` Sergey Shtylyov
2021-08-28 9:34 ` Biju Das
2021-08-25 7:01 ` [PATCH net-next 13/13] ravb: Add reset support Biju Das
2021-08-27 20:17 ` Sergey Shtylyov
2021-08-28 9:41 ` Biju Das
2021-08-25 10:30 ` [PATCH net-next 00/13] Add Factorisation code to support Gigabit Ethernet driver patchwork-bot+netdevbpf
2021-08-25 10:57 ` Sergey Shtylyov
2021-08-25 13:46 ` Andrew Lunn
2021-08-25 14:06 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSfm7zKz5BTNUXDz@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.