* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-10 13:09 ` [PATCH 1/3] drm/bridge: Add a function to abstract away panels Maxime Ripard
@ 2021-09-12 19:42 ` Sam Ravnborg
2021-09-12 19:50 ` Sam Ravnborg
` (2 subsequent siblings)
3 siblings, 0 replies; 16+ messages in thread
From: Sam Ravnborg @ 2021-09-12 19:42 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, Neil Armstrong, Jonas Karlman, dri-devel
Hi Maxime,
On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functions or create a drm panel bridge through drm_panel_bridge_add.
>
> In order to reduce the boilerplate and hopefully create a path of least
> resistance towards using the DRM panel bridge layer, let's create the
> function devm_drm_of_get_next to reduce that boilerplate.
s/devm_drm_of_get_next/devm_drm_of_get_bridge/
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
I like how this makes panels and bridges much more alike for the display
drivers.
With the changelog fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
(I assume you will apply yourself - otherwise tell me to do it).
> ---
> drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/drm_of.c | 3 +++
> include/drm/drm_bridge.h | 2 ++
> 3 files changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index a8ed66751c2d..10ddca4638b0 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -28,6 +28,7 @@
> #include <drm/drm_atomic_state_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_encoder.h>
> +#include <drm/drm_of.h>
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> @@ -51,10 +52,8 @@
> *
> * Display drivers are responsible for linking encoders with the first bridge
> * in the chains. This is done by acquiring the appropriate bridge with
> - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> - * panel with drm_panel_bridge_add_typed() (or the managed version
> - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> - * attached to the encoder with a call to drm_bridge_attach().
> + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> + * encoder with a call to drm_bridge_attach().
> *
> * Bridges are responsible for linking themselves with the next bridge in the
> * chain, if any. This is done the same way as for encoders, with the call to
> @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> return NULL;
> }
> EXPORT_SYMBOL(of_drm_find_bridge);
> +
> +/**
> + * devm_drm_of_get_bridge - Return next bridge in the chain
> + * @dev: device to tie the bridge lifetime to
> + * @np: device tree node containing encoder output ports
> + * @port: port in the device tree node
> + * @endpoint: endpoint in the device tree node
> + *
> + * Given a DT node's port and endpoint number, finds the connected node
> + * and returns the associated bridge if any, or creates and returns a
> + * drm panel bridge instance if a panel is connected.
> + *
> + * Returns a pointer to the bridge if successful, or an error pointer
> + * otherwise.
> + */
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> + struct device_node *np,
> + unsigned int port,
> + unsigned int endpoint)
> +{
> + struct drm_bridge *bridge;
> + struct drm_panel *panel;
> + int ret;
> +
> + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> + &panel, &bridge);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + if (panel)
> + bridge = devm_drm_panel_bridge_add(dev, panel);
> +
> + return bridge;
> +}
> +EXPORT_SYMBOL(devm_drm_of_get_bridge);
> #endif
>
> MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>");
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 997b8827fed2..37c34146eea8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -231,6 +231,9 @@ EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> * return either the associated struct drm_panel or drm_bridge device. Either
> * @panel or @bridge must not be NULL.
> *
> + * This function is deprecated and should not be used in new drivers. Use
> + * devm_drm_of_get_bridge() instead.
> + *
> * Returns zero if successful, or one of the standard error codes if it fails.
> */
> int drm_of_find_panel_or_bridge(const struct device_node *np,
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 46bdfa48c413..f70c88ca96ef 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -911,6 +911,8 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
> struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
> struct drm_panel *panel,
> u32 connector_type);
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
> + unsigned int port, unsigned int endpoint);
> struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
> #endif
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-10 13:09 ` [PATCH 1/3] drm/bridge: Add a function to abstract away panels Maxime Ripard
2021-09-12 19:42 ` Sam Ravnborg
@ 2021-09-12 19:50 ` Sam Ravnborg
2021-09-21 12:47 ` Patrik Jakobsson
2021-09-23 0:29 ` Laurent Pinchart
3 siblings, 0 replies; 16+ messages in thread
From: Sam Ravnborg @ 2021-09-12 19:50 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, Neil Armstrong, Jonas Karlman, dri-devel
On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functions or create a drm panel bridge through drm_panel_bridge_add.
>
> In order to reduce the boilerplate and hopefully create a path of least
> resistance towards using the DRM panel bridge layer, let's create the
> function devm_drm_of_get_next to reduce that boilerplate.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/drm_of.c | 3 +++
> include/drm/drm_bridge.h | 2 ++
> 3 files changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index a8ed66751c2d..10ddca4638b0 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -28,6 +28,7 @@
> #include <drm/drm_atomic_state_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_encoder.h>
> +#include <drm/drm_of.h>
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> @@ -51,10 +52,8 @@
> *
> * Display drivers are responsible for linking encoders with the first bridge
> * in the chains. This is done by acquiring the appropriate bridge with
> - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> - * panel with drm_panel_bridge_add_typed() (or the managed version
> - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> - * attached to the encoder with a call to drm_bridge_attach().
> + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> + * encoder with a call to drm_bridge_attach().
> *
> * Bridges are responsible for linking themselves with the next bridge in the
> * chain, if any. This is done the same way as for encoders, with the call to
> @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> return NULL;
> }
> EXPORT_SYMBOL(of_drm_find_bridge);
> +
> +/**
> + * devm_drm_of_get_bridge - Return next bridge in the chain
> + * @dev: device to tie the bridge lifetime to
> + * @np: device tree node containing encoder output ports
> + * @port: port in the device tree node
> + * @endpoint: endpoint in the device tree node
> + *
> + * Given a DT node's port and endpoint number, finds the connected node
> + * and returns the associated bridge if any, or creates and returns a
> + * drm panel bridge instance if a panel is connected.
> + *
> + * Returns a pointer to the bridge if successful, or an error pointer
> + * otherwise.
> + */
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> + struct device_node *np,
> + unsigned int port,
> + unsigned int endpoint)
One extra comment.
In of_graph_get_remote_node() port is u32
In drm_of_find_panel_or_bridge() port is int
Here port is unsigned int
My OCD would benefit if we used u32 here - as this is consistent with
the base function of_graph_get_remote_node().
Sam
> +{
> + struct drm_bridge *bridge;
> + struct drm_panel *panel;
> + int ret;
> +
> + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> + &panel, &bridge);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + if (panel)
> + bridge = devm_drm_panel_bridge_add(dev, panel);
> +
> + return bridge;
> +}
> +EXPORT_SYMBOL(devm_drm_of_get_bridge);
> #endif
>
> MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>");
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 997b8827fed2..37c34146eea8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -231,6 +231,9 @@ EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> * return either the associated struct drm_panel or drm_bridge device. Either
> * @panel or @bridge must not be NULL.
> *
> + * This function is deprecated and should not be used in new drivers. Use
> + * devm_drm_of_get_bridge() instead.
> + *
> * Returns zero if successful, or one of the standard error codes if it fails.
> */
> int drm_of_find_panel_or_bridge(const struct device_node *np,
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 46bdfa48c413..f70c88ca96ef 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -911,6 +911,8 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
> struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
> struct drm_panel *panel,
> u32 connector_type);
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
> + unsigned int port, unsigned int endpoint);
> struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
> #endif
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-10 13:09 ` [PATCH 1/3] drm/bridge: Add a function to abstract away panels Maxime Ripard
2021-09-12 19:42 ` Sam Ravnborg
2021-09-12 19:50 ` Sam Ravnborg
@ 2021-09-21 12:47 ` Patrik Jakobsson
2021-09-22 8:22 ` Maxime Ripard
2021-09-23 0:29 ` Laurent Pinchart
3 siblings, 1 reply; 16+ messages in thread
From: Patrik Jakobsson @ 2021-09-21 12:47 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, Neil Armstrong, Jonas Karlman, dri-devel
On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functions or create a drm panel bridge through drm_panel_bridge_add.
>
> In order to reduce the boilerplate and hopefully create a path of least
> resistance towards using the DRM panel bridge layer, let's create the
> function devm_drm_of_get_next to reduce that boilerplate.
Hi Maxime,
This patch creates a dependency error for me:
depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
depmod: ERROR: Cycle detected: cec
depmod: ERROR: Found 2 modules in dependency cycles!
Cheers
Patrik
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/drm_of.c | 3 +++
> include/drm/drm_bridge.h | 2 ++
> 3 files changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index a8ed66751c2d..10ddca4638b0 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -28,6 +28,7 @@
> #include <drm/drm_atomic_state_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_encoder.h>
> +#include <drm/drm_of.h>
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> @@ -51,10 +52,8 @@
> *
> * Display drivers are responsible for linking encoders with the first bridge
> * in the chains. This is done by acquiring the appropriate bridge with
> - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> - * panel with drm_panel_bridge_add_typed() (or the managed version
> - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> - * attached to the encoder with a call to drm_bridge_attach().
> + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> + * encoder with a call to drm_bridge_attach().
> *
> * Bridges are responsible for linking themselves with the next bridge in the
> * chain, if any. This is done the same way as for encoders, with the call to
> @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> return NULL;
> }
> EXPORT_SYMBOL(of_drm_find_bridge);
> +
> +/**
> + * devm_drm_of_get_bridge - Return next bridge in the chain
> + * @dev: device to tie the bridge lifetime to
> + * @np: device tree node containing encoder output ports
> + * @port: port in the device tree node
> + * @endpoint: endpoint in the device tree node
> + *
> + * Given a DT node's port and endpoint number, finds the connected node
> + * and returns the associated bridge if any, or creates and returns a
> + * drm panel bridge instance if a panel is connected.
> + *
> + * Returns a pointer to the bridge if successful, or an error pointer
> + * otherwise.
> + */
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> + struct device_node *np,
> + unsigned int port,
> + unsigned int endpoint)
> +{
> + struct drm_bridge *bridge;
> + struct drm_panel *panel;
> + int ret;
> +
> + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> + &panel, &bridge);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + if (panel)
> + bridge = devm_drm_panel_bridge_add(dev, panel);
> +
> + return bridge;
> +}
> +EXPORT_SYMBOL(devm_drm_of_get_bridge);
> #endif
>
> MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>");
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 997b8827fed2..37c34146eea8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -231,6 +231,9 @@ EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> * return either the associated struct drm_panel or drm_bridge device. Either
> * @panel or @bridge must not be NULL.
> *
> + * This function is deprecated and should not be used in new drivers. Use
> + * devm_drm_of_get_bridge() instead.
> + *
> * Returns zero if successful, or one of the standard error codes if it fails.
> */
> int drm_of_find_panel_or_bridge(const struct device_node *np,
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 46bdfa48c413..f70c88ca96ef 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -911,6 +911,8 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
> struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
> struct drm_panel *panel,
> u32 connector_type);
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
> + unsigned int port, unsigned int endpoint);
> struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
> #endif
>
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-21 12:47 ` Patrik Jakobsson
@ 2021-09-22 8:22 ` Maxime Ripard
2021-09-22 8:30 ` Patrik Jakobsson
0 siblings, 1 reply; 16+ messages in thread
From: Maxime Ripard @ 2021-09-22 8:22 UTC (permalink / raw)
To: Patrik Jakobsson
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, Neil Armstrong, Jonas Karlman, dri-devel
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi Patrik,
On Tue, Sep 21, 2021 at 02:47:49PM +0200, Patrik Jakobsson wrote:
> On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > Display drivers so far need to have a lot of boilerplate to first
> > retrieve either the panel or bridge that they are connected to using
> > drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> > functions or create a drm panel bridge through drm_panel_bridge_add.
> >
> > In order to reduce the boilerplate and hopefully create a path of least
> > resistance towards using the DRM panel bridge layer, let's create the
> > function devm_drm_of_get_next to reduce that boilerplate.
>
> Hi Maxime,
>
> This patch creates a dependency error for me:
>
> depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> depmod: ERROR: Cycle detected: cec
> depmod: ERROR: Found 2 modules in dependency cycles!
I just pushed a fix to drm-misc-fixes that should address it
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-22 8:22 ` Maxime Ripard
@ 2021-09-22 8:30 ` Patrik Jakobsson
0 siblings, 0 replies; 16+ messages in thread
From: Patrik Jakobsson @ 2021-09-22 8:30 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, Neil Armstrong, Jonas Karlman, dri-devel
On Wed, Sep 22, 2021 at 10:23 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi Patrik,
>
> On Tue, Sep 21, 2021 at 02:47:49PM +0200, Patrik Jakobsson wrote:
> > On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > >
> > > Display drivers so far need to have a lot of boilerplate to first
> > > retrieve either the panel or bridge that they are connected to using
> > > drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> > > functions or create a drm panel bridge through drm_panel_bridge_add.
> > >
> > > In order to reduce the boilerplate and hopefully create a path of least
> > > resistance towards using the DRM panel bridge layer, let's create the
> > > function devm_drm_of_get_next to reduce that boilerplate.
> >
> > Hi Maxime,
> >
> > This patch creates a dependency error for me:
> >
> > depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
> > depmod: ERROR: Cycle detected: cec
> > depmod: ERROR: Found 2 modules in dependency cycles!
>
> I just pushed a fix to drm-misc-fixes that should address it
Great, thanks!
>
> Maxime
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-10 13:09 ` [PATCH 1/3] drm/bridge: Add a function to abstract away panels Maxime Ripard
` (2 preceding siblings ...)
2021-09-21 12:47 ` Patrik Jakobsson
@ 2021-09-23 0:29 ` Laurent Pinchart
2021-09-27 19:43 ` Maxime Ripard
2021-09-28 16:27 ` Andrzej Hajda
3 siblings, 2 replies; 16+ messages in thread
From: Laurent Pinchart @ 2021-09-23 0:29 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Jernej Skrabec, Andrzej Hajda, Neil Armstrong,
Jonas Karlman, dri-devel
Hi Maxime,
Thank you for the patch.
I know this has already been merged, but I have a question.
On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functions or create a drm panel bridge through drm_panel_bridge_add.
>
> In order to reduce the boilerplate and hopefully create a path of least
> resistance towards using the DRM panel bridge layer, let's create the
> function devm_drm_of_get_next to reduce that boilerplate.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/drm_of.c | 3 +++
> include/drm/drm_bridge.h | 2 ++
> 3 files changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index a8ed66751c2d..10ddca4638b0 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -28,6 +28,7 @@
> #include <drm/drm_atomic_state_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_encoder.h>
> +#include <drm/drm_of.h>
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> @@ -51,10 +52,8 @@
> *
> * Display drivers are responsible for linking encoders with the first bridge
> * in the chains. This is done by acquiring the appropriate bridge with
> - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> - * panel with drm_panel_bridge_add_typed() (or the managed version
> - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> - * attached to the encoder with a call to drm_bridge_attach().
> + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> + * encoder with a call to drm_bridge_attach().
> *
> * Bridges are responsible for linking themselves with the next bridge in the
> * chain, if any. This is done the same way as for encoders, with the call to
> @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> return NULL;
> }
> EXPORT_SYMBOL(of_drm_find_bridge);
> +
> +/**
> + * devm_drm_of_get_bridge - Return next bridge in the chain
> + * @dev: device to tie the bridge lifetime to
> + * @np: device tree node containing encoder output ports
> + * @port: port in the device tree node
> + * @endpoint: endpoint in the device tree node
> + *
> + * Given a DT node's port and endpoint number, finds the connected node
> + * and returns the associated bridge if any, or creates and returns a
> + * drm panel bridge instance if a panel is connected.
> + *
> + * Returns a pointer to the bridge if successful, or an error pointer
> + * otherwise.
> + */
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> + struct device_node *np,
> + unsigned int port,
> + unsigned int endpoint)
> +{
> + struct drm_bridge *bridge;
> + struct drm_panel *panel;
> + int ret;
> +
> + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> + &panel, &bridge);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + if (panel)
> + bridge = devm_drm_panel_bridge_add(dev, panel);
> +
> + return bridge;
I really like the idea, I've wanted to do something like this for a long
time. I however wonder if this is the best approach, or if we could get
the panel core to register the bridge itself. The part that bothers me
here is the assymetry in the lifetime of the bridges, the returned
pointer is either looked up or allocated.
Bridge lifetime is such a mess that it may not make a big difference,
but eventually we'll have to address that problem globally.
> +}
> +EXPORT_SYMBOL(devm_drm_of_get_bridge);
> #endif
>
> MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>");
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 997b8827fed2..37c34146eea8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -231,6 +231,9 @@ EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> * return either the associated struct drm_panel or drm_bridge device. Either
> * @panel or @bridge must not be NULL.
> *
> + * This function is deprecated and should not be used in new drivers. Use
> + * devm_drm_of_get_bridge() instead.
> + *
> * Returns zero if successful, or one of the standard error codes if it fails.
> */
> int drm_of_find_panel_or_bridge(const struct device_node *np,
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 46bdfa48c413..f70c88ca96ef 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -911,6 +911,8 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
> struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
> struct drm_panel *panel,
> u32 connector_type);
> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
> + unsigned int port, unsigned int endpoint);
> struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
> #endif
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-23 0:29 ` Laurent Pinchart
@ 2021-09-27 19:43 ` Maxime Ripard
2021-09-27 21:53 ` Laurent Pinchart
2021-09-28 16:27 ` Andrzej Hajda
1 sibling, 1 reply; 16+ messages in thread
From: Maxime Ripard @ 2021-09-27 19:43 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Jernej Skrabec, Andrzej Hajda, Neil Armstrong,
Jonas Karlman, dri-devel
[-- Attachment #1: Type: text/plain, Size: 4406 bytes --]
On Thu, Sep 23, 2021 at 03:29:37AM +0300, Laurent Pinchart wrote:
> Hi Maxime,
>
> Thank you for the patch.
>
> I know this has already been merged, but I have a question.
>
> On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
> > Display drivers so far need to have a lot of boilerplate to first
> > retrieve either the panel or bridge that they are connected to using
> > drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> > functions or create a drm panel bridge through drm_panel_bridge_add.
> >
> > In order to reduce the boilerplate and hopefully create a path of least
> > resistance towards using the DRM panel bridge layer, let's create the
> > function devm_drm_of_get_next to reduce that boilerplate.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> > drivers/gpu/drm/drm_of.c | 3 +++
> > include/drm/drm_bridge.h | 2 ++
> > 3 files changed, 43 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> > index a8ed66751c2d..10ddca4638b0 100644
> > --- a/drivers/gpu/drm/drm_bridge.c
> > +++ b/drivers/gpu/drm/drm_bridge.c
> > @@ -28,6 +28,7 @@
> > #include <drm/drm_atomic_state_helper.h>
> > #include <drm/drm_bridge.h>
> > #include <drm/drm_encoder.h>
> > +#include <drm/drm_of.h>
> > #include <drm/drm_print.h>
> >
> > #include "drm_crtc_internal.h"
> > @@ -51,10 +52,8 @@
> > *
> > * Display drivers are responsible for linking encoders with the first bridge
> > * in the chains. This is done by acquiring the appropriate bridge with
> > - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> > - * panel with drm_panel_bridge_add_typed() (or the managed version
> > - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> > - * attached to the encoder with a call to drm_bridge_attach().
> > + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> > + * encoder with a call to drm_bridge_attach().
> > *
> > * Bridges are responsible for linking themselves with the next bridge in the
> > * chain, if any. This is done the same way as for encoders, with the call to
> > @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> > return NULL;
> > }
> > EXPORT_SYMBOL(of_drm_find_bridge);
> > +
> > +/**
> > + * devm_drm_of_get_bridge - Return next bridge in the chain
> > + * @dev: device to tie the bridge lifetime to
> > + * @np: device tree node containing encoder output ports
> > + * @port: port in the device tree node
> > + * @endpoint: endpoint in the device tree node
> > + *
> > + * Given a DT node's port and endpoint number, finds the connected node
> > + * and returns the associated bridge if any, or creates and returns a
> > + * drm panel bridge instance if a panel is connected.
> > + *
> > + * Returns a pointer to the bridge if successful, or an error pointer
> > + * otherwise.
> > + */
> > +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> > + struct device_node *np,
> > + unsigned int port,
> > + unsigned int endpoint)
> > +{
> > + struct drm_bridge *bridge;
> > + struct drm_panel *panel;
> > + int ret;
> > +
> > + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> > + &panel, &bridge);
> > + if (ret)
> > + return ERR_PTR(ret);
> > +
> > + if (panel)
> > + bridge = devm_drm_panel_bridge_add(dev, panel);
> > +
> > + return bridge;
>
> I really like the idea, I've wanted to do something like this for a long
> time. I however wonder if this is the best approach, or if we could get
> the panel core to register the bridge itself. The part that bothers me
> here is the assymetry in the lifetime of the bridges, the returned
> pointer is either looked up or allocated.
>
> Bridge lifetime is such a mess that it may not make a big difference,
> but eventually we'll have to address that problem globally.
We can't have Rust soon enough :)
Does it really matter though? I thought the bridges couldn't be unloaded
from a DRM device anyway, so for all practical purposes this will be
removed at around the same time: when the whole DRM device is going to
be teared down?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-27 19:43 ` Maxime Ripard
@ 2021-09-27 21:53 ` Laurent Pinchart
0 siblings, 0 replies; 16+ messages in thread
From: Laurent Pinchart @ 2021-09-27 21:53 UTC (permalink / raw)
To: Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Jernej Skrabec, Andrzej Hajda, Neil Armstrong,
Jonas Karlman, dri-devel
On Mon, Sep 27, 2021 at 09:43:44PM +0200, Maxime Ripard wrote:
> On Thu, Sep 23, 2021 at 03:29:37AM +0300, Laurent Pinchart wrote:
> > Hi Maxime,
> >
> > Thank you for the patch.
> >
> > I know this has already been merged, but I have a question.
> >
> > On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
> > > Display drivers so far need to have a lot of boilerplate to first
> > > retrieve either the panel or bridge that they are connected to using
> > > drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> > > functions or create a drm panel bridge through drm_panel_bridge_add.
> > >
> > > In order to reduce the boilerplate and hopefully create a path of least
> > > resistance towards using the DRM panel bridge layer, let's create the
> > > function devm_drm_of_get_next to reduce that boilerplate.
> > >
> > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > ---
> > > drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
> > > drivers/gpu/drm/drm_of.c | 3 +++
> > > include/drm/drm_bridge.h | 2 ++
> > > 3 files changed, 43 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> > > index a8ed66751c2d..10ddca4638b0 100644
> > > --- a/drivers/gpu/drm/drm_bridge.c
> > > +++ b/drivers/gpu/drm/drm_bridge.c
> > > @@ -28,6 +28,7 @@
> > > #include <drm/drm_atomic_state_helper.h>
> > > #include <drm/drm_bridge.h>
> > > #include <drm/drm_encoder.h>
> > > +#include <drm/drm_of.h>
> > > #include <drm/drm_print.h>
> > >
> > > #include "drm_crtc_internal.h"
> > > @@ -51,10 +52,8 @@
> > > *
> > > * Display drivers are responsible for linking encoders with the first bridge
> > > * in the chains. This is done by acquiring the appropriate bridge with
> > > - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
> > > - * panel with drm_panel_bridge_add_typed() (or the managed version
> > > - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
> > > - * attached to the encoder with a call to drm_bridge_attach().
> > > + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
> > > + * encoder with a call to drm_bridge_attach().
> > > *
> > > * Bridges are responsible for linking themselves with the next bridge in the
> > > * chain, if any. This is done the same way as for encoders, with the call to
> > > @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
> > > return NULL;
> > > }
> > > EXPORT_SYMBOL(of_drm_find_bridge);
> > > +
> > > +/**
> > > + * devm_drm_of_get_bridge - Return next bridge in the chain
> > > + * @dev: device to tie the bridge lifetime to
> > > + * @np: device tree node containing encoder output ports
> > > + * @port: port in the device tree node
> > > + * @endpoint: endpoint in the device tree node
> > > + *
> > > + * Given a DT node's port and endpoint number, finds the connected node
> > > + * and returns the associated bridge if any, or creates and returns a
> > > + * drm panel bridge instance if a panel is connected.
> > > + *
> > > + * Returns a pointer to the bridge if successful, or an error pointer
> > > + * otherwise.
> > > + */
> > > +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
> > > + struct device_node *np,
> > > + unsigned int port,
> > > + unsigned int endpoint)
> > > +{
> > > + struct drm_bridge *bridge;
> > > + struct drm_panel *panel;
> > > + int ret;
> > > +
> > > + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
> > > + &panel, &bridge);
> > > + if (ret)
> > > + return ERR_PTR(ret);
> > > +
> > > + if (panel)
> > > + bridge = devm_drm_panel_bridge_add(dev, panel);
> > > +
> > > + return bridge;
> >
> > I really like the idea, I've wanted to do something like this for a long
> > time. I however wonder if this is the best approach, or if we could get
> > the panel core to register the bridge itself. The part that bothers me
> > here is the assymetry in the lifetime of the bridges, the returned
> > pointer is either looked up or allocated.
> >
> > Bridge lifetime is such a mess that it may not make a big difference,
> > but eventually we'll have to address that problem globally.
>
> We can't have Rust soon enough :)
:-) Jokes aside, Rust or C, this would need a design overhaul as a first
step.
> Does it really matter though? I thought the bridges couldn't be unloaded
> from a DRM device anyway, so for all practical purposes this will be
> removed at around the same time: when the whole DRM device is going to
> be teared down?
Try to unbind a bridge device from its driver in sysfs, and it won't be
pretty.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels
2021-09-23 0:29 ` Laurent Pinchart
2021-09-27 19:43 ` Maxime Ripard
@ 2021-09-28 16:27 ` Andrzej Hajda
1 sibling, 0 replies; 16+ messages in thread
From: Andrzej Hajda @ 2021-09-28 16:27 UTC (permalink / raw)
To: Laurent Pinchart, Maxime Ripard
Cc: Robert Foss, Daniel Vetter, David Airlie, Maarten Lankhorst,
Thomas Zimmermann, Jernej Skrabec, Neil Armstrong, Jonas Karlman,
dri-devel
W dniu 23.09.2021 o 02:29, Laurent Pinchart pisze:
> Hi Maxime,
>
> Thank you for the patch.
>
> I know this has already been merged, but I have a question.
>
> On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote:
>> Display drivers so far need to have a lot of boilerplate to first
>> retrieve either the panel or bridge that they are connected to using
>> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
>> functions or create a drm panel bridge through drm_panel_bridge_add.
>>
>> In order to reduce the boilerplate and hopefully create a path of least
>> resistance towards using the DRM panel bridge layer, let's create the
>> function devm_drm_of_get_next to reduce that boilerplate.
>>
>> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>> ---
>> drivers/gpu/drm/drm_bridge.c | 42 ++++++++++++++++++++++++++++++++----
>> drivers/gpu/drm/drm_of.c | 3 +++
>> include/drm/drm_bridge.h | 2 ++
>> 3 files changed, 43 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
>> index a8ed66751c2d..10ddca4638b0 100644
>> --- a/drivers/gpu/drm/drm_bridge.c
>> +++ b/drivers/gpu/drm/drm_bridge.c
>> @@ -28,6 +28,7 @@
>> #include <drm/drm_atomic_state_helper.h>
>> #include <drm/drm_bridge.h>
>> #include <drm/drm_encoder.h>
>> +#include <drm/drm_of.h>
>> #include <drm/drm_print.h>
>>
>> #include "drm_crtc_internal.h"
>> @@ -51,10 +52,8 @@
>> *
>> * Display drivers are responsible for linking encoders with the first bridge
>> * in the chains. This is done by acquiring the appropriate bridge with
>> - * of_drm_find_bridge() or drm_of_find_panel_or_bridge(), or creating it for a
>> - * panel with drm_panel_bridge_add_typed() (or the managed version
>> - * devm_drm_panel_bridge_add_typed()). Once acquired, the bridge shall be
>> - * attached to the encoder with a call to drm_bridge_attach().
>> + * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the
>> + * encoder with a call to drm_bridge_attach().
>> *
>> * Bridges are responsible for linking themselves with the next bridge in the
>> * chain, if any. This is done the same way as for encoders, with the call to
>> @@ -1233,6 +1232,41 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
>> return NULL;
>> }
>> EXPORT_SYMBOL(of_drm_find_bridge);
>> +
>> +/**
>> + * devm_drm_of_get_bridge - Return next bridge in the chain
>> + * @dev: device to tie the bridge lifetime to
>> + * @np: device tree node containing encoder output ports
>> + * @port: port in the device tree node
>> + * @endpoint: endpoint in the device tree node
>> + *
>> + * Given a DT node's port and endpoint number, finds the connected node
>> + * and returns the associated bridge if any, or creates and returns a
>> + * drm panel bridge instance if a panel is connected.
>> + *
>> + * Returns a pointer to the bridge if successful, or an error pointer
>> + * otherwise.
>> + */
>> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
>> + struct device_node *np,
>> + unsigned int port,
>> + unsigned int endpoint)
>> +{
>> + struct drm_bridge *bridge;
>> + struct drm_panel *panel;
>> + int ret;
>> +
>> + ret = drm_of_find_panel_or_bridge(np, port, endpoint,
>> + &panel, &bridge);
>> + if (ret)
>> + return ERR_PTR(ret);
>> +
>> + if (panel)
>> + bridge = devm_drm_panel_bridge_add(dev, panel);
>> +
>> + return bridge;
> I really like the idea, I've wanted to do something like this for a long
> time. I however wonder if this is the best approach, or if we could get
> the panel core to register the bridge itself. The part that bothers me
> here is the assymetry in the lifetime of the bridges, the returned
> pointer is either looked up or allocated.
When drm_panel_bridge was proposed 1st time I suggested that instead of
it we should just merge panels with bridges (maybe with new name, my
favorite is drm_sink), but I was outvoted :)
Apparently with this patch we go to the same direction: since panels
will be accessed only via drm_panel_bridge they will become actually
bridges :) Somebody could then clean-up the whole intermediate code.
Regards
Andrzej
>
> Bridge lifetime is such a mess that it may not make a big difference,
> but eventually we'll have to address that problem globally.
>
>> +}
>> +EXPORT_SYMBOL(devm_drm_of_get_bridge);
>> #endif
>>
>> MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>");
>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>> index 997b8827fed2..37c34146eea8 100644
>> --- a/drivers/gpu/drm/drm_of.c
>> +++ b/drivers/gpu/drm/drm_of.c
>> @@ -231,6 +231,9 @@ EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
>> * return either the associated struct drm_panel or drm_bridge device. Either
>> * @panel or @bridge must not be NULL.
>> *
>> + * This function is deprecated and should not be used in new drivers. Use
>> + * devm_drm_of_get_bridge() instead.
>> + *
>> * Returns zero if successful, or one of the standard error codes if it fails.
>> */
>> int drm_of_find_panel_or_bridge(const struct device_node *np,
>> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
>> index 46bdfa48c413..f70c88ca96ef 100644
>> --- a/include/drm/drm_bridge.h
>> +++ b/include/drm/drm_bridge.h
>> @@ -911,6 +911,8 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
>> struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
>> struct drm_panel *panel,
>> u32 connector_type);
>> +struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
>> + unsigned int port, unsigned int endpoint);
>> struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
>> #endif
>>
^ permalink raw reply [flat|nested] 16+ messages in thread