From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Yue Hu <zbestahu@gmail.com> Cc: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, huyue2@yulong.com, zhangwen@yulong.com, zbestahu@163.com Subject: Re: [PATCH] erofs: fix compacted_{4b_initial, 2b} when compacted_4b_initial > totalidx Date: Mon, 13 Sep 2021 16:48:45 +0800 [thread overview] Message-ID: <YT8QbaAEkqBw//R0@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20210913072405.1128-1-zbestahu@gmail.com> Hi Yue, On Mon, Sep 13, 2021 at 03:24:05PM +0800, Yue Hu wrote: > From: Yue Hu <huyue2@yulong.com> > > mkfs.erofs will treat compacted_4b_initial & compacted_2b as 0 if > compacted_4b_initial > totalidx, kernel should be aligned with it > accordingly. There is no difference between compacted_4b_initial or compacted_4b_end for compacted 4B. Since in this way totalidx for compact 2B won't larger than 16 (number of lclusters in a compacted 2B pack.) So it can be handled in either compacted_4b_initial or compacted_4b_end cases, because there are all compacted 4B. Thanks, Gao Xiang > > Signed-off-by: Yue Hu <huyue2@yulong.com> > --- > fs/erofs/zmap.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c > index 9fb98d8..4f941b6 100644 > --- a/fs/erofs/zmap.c > +++ b/fs/erofs/zmap.c > @@ -369,7 +369,10 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m, > if (compacted_4b_initial == 32 / 4) > compacted_4b_initial = 0; > > - if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) > + if (compacted_4b_initial > totalidx) { > + compacted_4b_initial = 0; > + compacted_2b = 0; > + } else if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) > compacted_2b = rounddown(totalidx - compacted_4b_initial, 16); > else > compacted_2b = 0; > -- > 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Yue Hu <zbestahu@gmail.com> Cc: linux-kernel@vger.kernel.org, zbestahu@163.com, huyue2@yulong.com, linux-erofs@lists.ozlabs.org, zhangwen@yulong.com Subject: Re: [PATCH] erofs: fix compacted_{4b_initial, 2b} when compacted_4b_initial > totalidx Date: Mon, 13 Sep 2021 16:48:45 +0800 [thread overview] Message-ID: <YT8QbaAEkqBw//R0@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20210913072405.1128-1-zbestahu@gmail.com> Hi Yue, On Mon, Sep 13, 2021 at 03:24:05PM +0800, Yue Hu wrote: > From: Yue Hu <huyue2@yulong.com> > > mkfs.erofs will treat compacted_4b_initial & compacted_2b as 0 if > compacted_4b_initial > totalidx, kernel should be aligned with it > accordingly. There is no difference between compacted_4b_initial or compacted_4b_end for compacted 4B. Since in this way totalidx for compact 2B won't larger than 16 (number of lclusters in a compacted 2B pack.) So it can be handled in either compacted_4b_initial or compacted_4b_end cases, because there are all compacted 4B. Thanks, Gao Xiang > > Signed-off-by: Yue Hu <huyue2@yulong.com> > --- > fs/erofs/zmap.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c > index 9fb98d8..4f941b6 100644 > --- a/fs/erofs/zmap.c > +++ b/fs/erofs/zmap.c > @@ -369,7 +369,10 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m, > if (compacted_4b_initial == 32 / 4) > compacted_4b_initial = 0; > > - if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) > + if (compacted_4b_initial > totalidx) { > + compacted_4b_initial = 0; > + compacted_2b = 0; > + } else if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) > compacted_2b = rounddown(totalidx - compacted_4b_initial, 16); > else > compacted_2b = 0; > -- > 1.9.1
next prev parent reply other threads:[~2021-09-13 8:49 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 7:24 [PATCH] erofs: fix compacted_{4b_initial, 2b} when compacted_4b_initial > totalidx Yue Hu 2021-09-13 7:24 ` Yue Hu 2021-09-13 8:48 ` Gao Xiang [this message] 2021-09-13 8:48 ` Gao Xiang 2021-09-13 9:00 ` Yue Hu 2021-09-13 9:00 ` Yue Hu 2021-09-13 9:11 ` Gao Xiang 2021-09-13 9:11 ` Gao Xiang 2021-09-13 10:58 ` Yue Hu 2021-09-13 10:58 ` Yue Hu 2021-09-13 11:19 ` Gao Xiang 2021-09-13 11:19 ` Gao Xiang 2021-09-13 12:22 ` Yue Hu 2021-09-13 12:22 ` Yue Hu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YT8QbaAEkqBw//R0@B-P7TQMD6M-0146.local \ --to=hsiangkao@linux.alibaba.com \ --cc=chao@kernel.org \ --cc=huyue2@yulong.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=xiang@kernel.org \ --cc=zbestahu@163.com \ --cc=zbestahu@gmail.com \ --cc=zhangwen@yulong.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.