From: Luis Chamberlain <mcgrof@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>
Subject: Re: [mcgrof-next:20210908-firmware-builtin-v4 2/11] drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin'
Date: Mon, 13 Sep 2021 08:56:46 -0700 [thread overview]
Message-ID: <YT90vvVi7oYH0xpb@bombadil.infradead.org> (raw)
In-Reply-To: <YTwLw+frJLbntgCJ@archlinux-ax161>
On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote:
> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > bool firmware_is_builtin(const struct firmware *fw)
> >
> > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>
> Unless I am missing something, you don't include the firmware_loader
> copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
> the source of the warning?
You would think, but nope, its there:
#include "firmware.h"
Luis
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [mcgrof-next:20210908-firmware-builtin-v4 2/11] drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin'
Date: Mon, 13 Sep 2021 08:56:46 -0700 [thread overview]
Message-ID: <YT90vvVi7oYH0xpb@bombadil.infradead.org> (raw)
In-Reply-To: <YTwLw+frJLbntgCJ@archlinux-ax161>
[-- Attachment #1: Type: text/plain, Size: 2179 bytes --]
On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote:
> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > bool firmware_is_builtin(const struct firmware *fw)
> >
> > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>
> Unless I am missing something, you don't include the firmware_loader
> copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
> the source of the warning?
You would think, but nope, its there:
#include "firmware.h"
Luis
next prev parent reply other threads:[~2021-09-13 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 7:41 [mcgrof-next:20210908-firmware-builtin-v4 2/11] drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' kernel test robot
2021-09-10 7:41 ` kernel test robot
2021-09-11 0:48 ` Luis Chamberlain
2021-09-11 0:48 ` Luis Chamberlain
2021-09-11 1:28 ` [kbuild-all] " Philip Li
2021-09-11 1:28 ` Philip Li
2021-09-13 15:59 ` [kbuild-all] " Luis Chamberlain
2021-09-13 15:59 ` Luis Chamberlain
2021-09-13 16:21 ` [kbuild-all] " Luis Chamberlain
2021-09-13 16:21 ` Luis Chamberlain
2021-09-15 8:15 ` [kbuild-all] " Chen, Rong A
2021-09-15 8:15 ` Chen, Rong A
2021-09-11 1:52 ` Nathan Chancellor
2021-09-11 1:52 ` Nathan Chancellor
2021-09-13 15:56 ` Luis Chamberlain [this message]
2021-09-13 15:56 ` Luis Chamberlain
2021-09-13 17:25 ` Nathan Chancellor
2021-09-13 17:25 ` Nathan Chancellor
2021-09-13 17:30 ` Luis Chamberlain
2021-09-13 17:30 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT90vvVi7oYH0xpb@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=bp@suse.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.