From: Greg KH <gregkh@linuxfoundation.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:MEDIATEK SWITCH DRIVER" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports
Date: Thu, 2 Sep 2021 07:58:37 +0200 [thread overview]
Message-ID: <YTBoDaYDJfBz3YzN@kroah.com> (raw)
In-Reply-To: <20210902053619.1824464-1-dqfext@gmail.com>
On Thu, Sep 02, 2021 at 01:36:19PM +0800, DENG Qingfang wrote:
> On Fri, Aug 27, 2021 at 12:19:23PM +0200, Greg KH wrote:
> > On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote:
> > > Standalone ports should have address learning disabled, according to
> > > the documentation:
> > > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer
> > > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags
> > > function so it has to be done differently.
> > >
> > > I've identified an issue related to this.
> >
> > What issue is that? Where was it reported?
>
> See Florian's message here
> https://lore.kernel.org/stable/20210317003549.3964522-2-f.fainelli@gmail.com/
THat is just the patch changelog text, or is it unique to this
stable-only patch? It is not obvious at all.
> > > > 2. A partial backport of this patch?
> > >
> > > The other part does not actually fix anything.
> >
> > Then why is it not ok to just take the whole thing?
> >
> > When backporting not-identical-patches, something almost always goes
> > wrong, so we prefer to take the original commit when ever possible.
>
> Okay. MDB and tag ops can be backported as is, and broadcast/multicast
> flooding can be implemented in .port_egress_floods.
So what are we supposed to do here?
totally confused,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:MEDIATEK SWITCH DRIVER" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports
Date: Thu, 2 Sep 2021 07:58:37 +0200 [thread overview]
Message-ID: <YTBoDaYDJfBz3YzN@kroah.com> (raw)
In-Reply-To: <20210902053619.1824464-1-dqfext@gmail.com>
On Thu, Sep 02, 2021 at 01:36:19PM +0800, DENG Qingfang wrote:
> On Fri, Aug 27, 2021 at 12:19:23PM +0200, Greg KH wrote:
> > On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote:
> > > Standalone ports should have address learning disabled, according to
> > > the documentation:
> > > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer
> > > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags
> > > function so it has to be done differently.
> > >
> > > I've identified an issue related to this.
> >
> > What issue is that? Where was it reported?
>
> See Florian's message here
> https://lore.kernel.org/stable/20210317003549.3964522-2-f.fainelli@gmail.com/
THat is just the patch changelog text, or is it unique to this
stable-only patch? It is not obvious at all.
> > > > 2. A partial backport of this patch?
> > >
> > > The other part does not actually fix anything.
> >
> > Then why is it not ok to just take the whole thing?
> >
> > When backporting not-identical-patches, something almost always goes
> > wrong, so we prefer to take the original commit when ever possible.
>
> Okay. MDB and tag ops can be backported as is, and broadcast/multicast
> flooding can be implemented in .port_egress_floods.
So what are we supposed to do here?
totally confused,
greg k-h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:MEDIATEK SWITCH DRIVER" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports
Date: Thu, 2 Sep 2021 07:58:37 +0200 [thread overview]
Message-ID: <YTBoDaYDJfBz3YzN@kroah.com> (raw)
In-Reply-To: <20210902053619.1824464-1-dqfext@gmail.com>
On Thu, Sep 02, 2021 at 01:36:19PM +0800, DENG Qingfang wrote:
> On Fri, Aug 27, 2021 at 12:19:23PM +0200, Greg KH wrote:
> > On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote:
> > > Standalone ports should have address learning disabled, according to
> > > the documentation:
> > > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer
> > > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags
> > > function so it has to be done differently.
> > >
> > > I've identified an issue related to this.
> >
> > What issue is that? Where was it reported?
>
> See Florian's message here
> https://lore.kernel.org/stable/20210317003549.3964522-2-f.fainelli@gmail.com/
THat is just the patch changelog text, or is it unique to this
stable-only patch? It is not obvious at all.
> > > > 2. A partial backport of this patch?
> > >
> > > The other part does not actually fix anything.
> >
> > Then why is it not ok to just take the whole thing?
> >
> > When backporting not-identical-patches, something almost always goes
> > wrong, so we prefer to take the original commit when ever possible.
>
> Okay. MDB and tag ops can be backported as is, and broadcast/multicast
> flooding can be implemented in .port_egress_floods.
So what are we supposed to do here?
totally confused,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-02 5:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 5:55 [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports DENG Qingfang
2021-08-24 5:55 ` DENG Qingfang
2021-08-24 5:55 ` DENG Qingfang
2021-08-24 15:29 ` Sasha Levin
2021-08-24 15:29 ` Sasha Levin
2021-08-24 15:29 ` Sasha Levin
2021-08-24 15:57 ` DENG Qingfang
2021-08-24 15:57 ` DENG Qingfang
2021-08-24 15:57 ` DENG Qingfang
2021-08-27 10:19 ` Greg KH
2021-08-27 10:19 ` Greg KH
2021-08-27 10:19 ` Greg KH
2021-09-02 5:36 ` DENG Qingfang
2021-09-02 5:36 ` DENG Qingfang
2021-09-02 5:36 ` DENG Qingfang
2021-09-02 5:58 ` Greg KH [this message]
2021-09-02 5:58 ` Greg KH
2021-09-02 5:58 ` Greg KH
2021-09-03 9:14 ` DENG Qingfang
2021-09-03 9:14 ` DENG Qingfang
2021-09-03 9:14 ` DENG Qingfang
2021-09-07 15:18 ` Greg KH
2021-09-07 15:18 ` Greg KH
2021-09-07 15:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTBoDaYDJfBz3YzN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.