* [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-03 14:03 ` Joerg Roedel
0 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2021-09-03 14:03 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Will Deacon, linux-kernel, iommu
[-- Attachment #1: Type: text/plain, Size: 10954 bytes --]
Hi Linus,
The tree is a bit more messy this time, mostly because there are many
IOMMU core changes included and driver patches which depend on them
living in different branches. So some cross-merging between branches was
necessary. With that said:
The following changes since commit 7c60610d476766e128cc4284bb6349732cbd6606:
Linux 5.14-rc6 (2021-08-15 13:40:53 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
for you to fetch changes up to d8768d7eb9c21ef928adb93402d9348bcc4a6915:
Merge branches 'apple/dart', 'arm/smmu', 'iommu/fixes', 'x86/amd', 'x86/vt-d' and 'core' into next (2021-08-20 17:14:35 +0200)
----------------------------------------------------------------
IOMMU Updates for Linux v5.15
Including:
- New DART IOMMU driver for Apple Silicon M1 chips.
- Optimizations for iommu_[map/unmap] performance
- Selective TLB flush support for the AMD IOMMU driver to make
it more efficient on emulated IOMMUs.
- Rework IOVA setup and default domain type setting to move more
code out of IOMMU drivers and to support runtime switching
between certain types of default domains.
- VT-d Updates from Lu Baolu:
- Update the virtual command related registers
- Enable Intel IOMMU scalable mode by default
- Preset A/D bits for user space DMA usage
- Allow devices to have more than 32 outstanding PRs
- Various cleanups
- ARM SMMU Updates from Will Deacon:
- SMMUv3: Minor optimisation to avoid zeroing struct members on CMD submission
- SMMUv3: Increased use of batched commands to reduce submission latency
- SMMUv3: Refactoring in preparation for ECMDQ support
- SMMUv2: Fix races when probing devices with identical StreamIDs
- SMMUv2: Optimise walk cache flushing for Qualcomm implementations
- SMMUv2: Allow deep sleep states for some Qualcomm SoCs with shared clocks
- Various smaller optimizations, cleanups, and fixes
----------------------------------------------------------------
Andy Shevchenko (1):
iommu/vt-d: Drop the kernel doc annotation
Ashish Mhetre (1):
iommu: Fix race condition during default domain allocation
Ezequiel Garcia (1):
iommu/dma: Fix leak in non-contiguous API
Fenghua Yu (1):
iommu/vt-d: Fix PASID reference leak
Frank Wunderlich (1):
iommu: Check if group is NULL before remove device
Geert Uytterhoeven (1):
iommu/dart: APPLE_DART should depend on ARCH_APPLE
Isaac J. Manjarres (12):
iommu/io-pgtable: Introduce unmap_pages() as a page table op
iommu: Add an unmap_pages() op for IOMMU drivers
iommu/io-pgtable: Introduce map_pages() as a page table op
iommu: Add a map_pages() op for IOMMU drivers
iommu: Add support for the map_pages() callback
iommu/io-pgtable-arm: Prepare PTE methods for handling multiple entries
iommu/io-pgtable-arm: Implement arm_lpae_unmap_pages()
iommu/io-pgtable-arm: Implement arm_lpae_map_pages()
iommu/io-pgtable-arm-v7s: Implement arm_v7s_unmap_pages()
iommu/io-pgtable-arm-v7s: Implement arm_v7s_map_pages()
iommu/arm-smmu: Implement the unmap_pages() IOMMU driver callback
iommu/arm-smmu: Implement the map_pages() IOMMU driver callback
Joerg Roedel (4):
Merge remote-tracking branch 'korg/core' into x86/amd
iommu/amd: Remove stale amd_iommu_unmap_flush usage
Merge tag 'arm-smmu-updates' of git://git.kernel.org/pub/scm/linux/kernel/git/will/linux into arm/smmu
Merge branches 'apple/dart', 'arm/smmu', 'iommu/fixes', 'x86/amd', 'x86/vt-d' and 'core' into next
John Garry (5):
iommu: Deprecate Intel and AMD cmdline methods to enable strict mode
iommu: Print strict or lazy mode at init time
iommu: Remove mode argument from iommu_set_dma_strict()
iommu/arm-smmu-v3: Remove some unneeded init in arm_smmu_cmdq_issue_cmdlist()
iommu/arm-smmu-v3: Stop pre-zeroing batch commands
Krishna Reddy (1):
iommu/arm-smmu: Fix race condition during iommu_group creation
Lennert Buytenhek (1):
iommu/amd: Fix printing of IOMMU events when rate limiting kicks in
Liu Yi L (3):
iommu/vt-d: Fix incomplete cache flush in intel_pasid_tear_down_entry()
iommu/vt-d: Use pasid_pte_is_present() helper function
iommu/vt-d: Add present bit check in pasid entry setup helpers
Lu Baolu (8):
iommu/vt-d: Report real pgsize bitmap to iommu core
iommu/vt-d: Implement map/unmap_pages() iommu_ops callback
iommu/vt-d: Move clflush'es from iotlb_sync_map() to map_pages()
iommu/vt-d: Update the virtual command related registers
iommu/vt-d: Refactor Kconfig a bit
iommu/vt-d: Enable Intel IOMMU scalable mode by default
iommu/vt-d: Preset A/D bits for user space DMA usage
iommu/vt-d: Allow devices to have more than 32 outstanding PRs
Nadav Amit (6):
iommu/amd: Selective flush on unmap
iommu/amd: Do not use flush-queue when NpCache is on
iommu: Factor iommu_iotlb_gather_is_disjoint() out
iommu/amd: Tailored gather logic for AMD
iommu/amd: Sync once for scatter-gather operations
iommu/amd: Use only natural aligned flushes in a VM
Robin Murphy (26):
iommu: Streamline iommu_iova_to_phys()
iommu: Improve iommu_iotlb_gather helpers
iommu: Pull IOVA cookie management into the core
iommu/amd: Drop IOVA cookie management
iommu/arm-smmu: Drop IOVA cookie management
iommu/vt-d: Drop IOVA cookie management
iommu/exynos: Drop IOVA cookie management
iommu/ipmmu-vmsa: Drop IOVA cookie management
iommu/mtk: Drop IOVA cookie management
iommu/rockchip: Drop IOVA cookie management
iommu/sprd: Drop IOVA cookie management
iommu/sun50i: Drop IOVA cookie management
iommu/virtio: Drop IOVA cookie management
iommu/dma: Remove redundant "!dev" checks
iommu: Indicate queued flushes via gather data
iommu/io-pgtable: Remove non-strict quirk
iommu: Introduce explicit type for non-strict DMA domains
iommu/amd: Prepare for multiple DMA domain types
iommu/arm-smmu: Prepare for multiple DMA domain types
iommu/vt-d: Prepare for multiple DMA domain types
iommu: Express DMA strictness via the domain type
iommu: Expose DMA domain strictness via sysfs
iommu: Only log strictness for DMA domains
iommu: Merge strictness and domain type configs
iommu: Allow enabling non-strict mode dynamically
iommu/io-pgtable: Abstract iommu_iotlb_gather access
Sai Prakash Ranjan (2):
iommu/arm-smmu: Add clk_bulk_{prepare/unprepare} to system pm callbacks
iommu/arm-smmu: Optimize ->tlb_flush_walk() for qcom implementation
Sven Peter (3):
iommu/io-pgtable: Add DART pagetable format
dt-bindings: iommu: add DART iommu bindings
iommu/dart: Add DART iommu driver
Will Deacon (3):
iommu: Use bitmap to calculate page size in iommu_pgsize()
iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts
iommu: Hook up '->unmap_pages' driver callback
Xiang Chen (2):
iommu/arm-smmu-v3: Implement the unmap_pages() IOMMU driver callback
iommu/arm-smmu-v3: Implement the map_pages() IOMMU driver callback
Xiyu Yang via iommu (1):
iommu/amd: Convert from atomic_t to refcount_t on pasid_state->count
Yang Yingliang (1):
iommu/arm-smmu: Fix missing unlock on error in arm_smmu_device_group()
Zhen Lei (8):
iommu: Enhance IOMMU default DMA mode build options
iommu/vt-d: Add support for IOMMU default DMA mode build options
iommu/amd: Add support for IOMMU default DMA mode build options
iommu/arm-smmu-v3: Use command queue batching helpers to improve performance
iommu/arm-smmu-v3: Add and use static helper function arm_smmu_cmdq_issue_cmd_with_sync()
iommu/arm-smmu-v3: Add and use static helper function arm_smmu_get_cmdq()
iommu/arm-smmu-v3: Extract reusable function __arm_smmu_cmdq_skip_err()
iommu/vt-d: Remove unnecessary oom message
.../ABI/testing/sysfs-kernel-iommu_groups | 6 +-
Documentation/admin-guide/kernel-parameters.txt | 29 +-
.../devicetree/bindings/iommu/apple,dart.yaml | 81 ++
MAINTAINERS | 7 +
drivers/iommu/Kconfig | 69 +-
drivers/iommu/Makefile | 1 +
drivers/iommu/amd/amd_iommu_types.h | 6 -
drivers/iommu/amd/init.c | 12 +-
drivers/iommu/amd/io_pgtable.c | 3 -
drivers/iommu/amd/iommu.c | 151 +++-
drivers/iommu/amd/iommu_v2.c | 13 +-
drivers/iommu/apple-dart.c | 923 +++++++++++++++++++++
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 121 +--
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 11 +
drivers/iommu/arm/arm-smmu/arm-smmu.c | 89 +-
drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 +
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 9 -
drivers/iommu/dma-iommu.c | 52 +-
drivers/iommu/exynos-iommu.c | 19 +-
drivers/iommu/intel/Kconfig | 19 +-
drivers/iommu/intel/dmar.c | 2 -
drivers/iommu/intel/iommu.c | 197 ++---
drivers/iommu/intel/pasid.c | 28 +-
drivers/iommu/intel/pasid.h | 16 +-
drivers/iommu/intel/perf.c | 2 +-
drivers/iommu/intel/svm.c | 7 +-
drivers/iommu/io-pgtable-arm-v7s.c | 62 +-
drivers/iommu/io-pgtable-arm.c | 282 +++++--
drivers/iommu/io-pgtable.c | 1 +
drivers/iommu/iommu.c | 198 +++--
drivers/iommu/iova.c | 14 +-
drivers/iommu/ipmmu-vmsa.c | 28 +-
drivers/iommu/mtk_iommu.c | 13 +-
drivers/iommu/mtk_iommu_v1.c | 1 -
drivers/iommu/rockchip-iommu.c | 12 +-
drivers/iommu/sprd-iommu.c | 7 -
drivers/iommu/sun50i-iommu.c | 13 +-
drivers/iommu/virtio-iommu.c | 8 -
include/linux/dma-iommu.h | 6 +
include/linux/intel-iommu.h | 6 +-
include/linux/intel-svm.h | 5 +
include/linux/io-pgtable.h | 20 +-
include/linux/iommu.h | 114 ++-
43 files changed, 2054 insertions(+), 610 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iommu/apple,dart.yaml
create mode 100644 drivers/iommu/apple-dart.c
Please pull.
Thanks,
Joerg
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-03 14:03 ` Joerg Roedel
0 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2021-09-03 14:03 UTC (permalink / raw)
To: Linus Torvalds; +Cc: iommu, Will Deacon, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 10954 bytes --]
Hi Linus,
The tree is a bit more messy this time, mostly because there are many
IOMMU core changes included and driver patches which depend on them
living in different branches. So some cross-merging between branches was
necessary. With that said:
The following changes since commit 7c60610d476766e128cc4284bb6349732cbd6606:
Linux 5.14-rc6 (2021-08-15 13:40:53 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
for you to fetch changes up to d8768d7eb9c21ef928adb93402d9348bcc4a6915:
Merge branches 'apple/dart', 'arm/smmu', 'iommu/fixes', 'x86/amd', 'x86/vt-d' and 'core' into next (2021-08-20 17:14:35 +0200)
----------------------------------------------------------------
IOMMU Updates for Linux v5.15
Including:
- New DART IOMMU driver for Apple Silicon M1 chips.
- Optimizations for iommu_[map/unmap] performance
- Selective TLB flush support for the AMD IOMMU driver to make
it more efficient on emulated IOMMUs.
- Rework IOVA setup and default domain type setting to move more
code out of IOMMU drivers and to support runtime switching
between certain types of default domains.
- VT-d Updates from Lu Baolu:
- Update the virtual command related registers
- Enable Intel IOMMU scalable mode by default
- Preset A/D bits for user space DMA usage
- Allow devices to have more than 32 outstanding PRs
- Various cleanups
- ARM SMMU Updates from Will Deacon:
- SMMUv3: Minor optimisation to avoid zeroing struct members on CMD submission
- SMMUv3: Increased use of batched commands to reduce submission latency
- SMMUv3: Refactoring in preparation for ECMDQ support
- SMMUv2: Fix races when probing devices with identical StreamIDs
- SMMUv2: Optimise walk cache flushing for Qualcomm implementations
- SMMUv2: Allow deep sleep states for some Qualcomm SoCs with shared clocks
- Various smaller optimizations, cleanups, and fixes
----------------------------------------------------------------
Andy Shevchenko (1):
iommu/vt-d: Drop the kernel doc annotation
Ashish Mhetre (1):
iommu: Fix race condition during default domain allocation
Ezequiel Garcia (1):
iommu/dma: Fix leak in non-contiguous API
Fenghua Yu (1):
iommu/vt-d: Fix PASID reference leak
Frank Wunderlich (1):
iommu: Check if group is NULL before remove device
Geert Uytterhoeven (1):
iommu/dart: APPLE_DART should depend on ARCH_APPLE
Isaac J. Manjarres (12):
iommu/io-pgtable: Introduce unmap_pages() as a page table op
iommu: Add an unmap_pages() op for IOMMU drivers
iommu/io-pgtable: Introduce map_pages() as a page table op
iommu: Add a map_pages() op for IOMMU drivers
iommu: Add support for the map_pages() callback
iommu/io-pgtable-arm: Prepare PTE methods for handling multiple entries
iommu/io-pgtable-arm: Implement arm_lpae_unmap_pages()
iommu/io-pgtable-arm: Implement arm_lpae_map_pages()
iommu/io-pgtable-arm-v7s: Implement arm_v7s_unmap_pages()
iommu/io-pgtable-arm-v7s: Implement arm_v7s_map_pages()
iommu/arm-smmu: Implement the unmap_pages() IOMMU driver callback
iommu/arm-smmu: Implement the map_pages() IOMMU driver callback
Joerg Roedel (4):
Merge remote-tracking branch 'korg/core' into x86/amd
iommu/amd: Remove stale amd_iommu_unmap_flush usage
Merge tag 'arm-smmu-updates' of git://git.kernel.org/pub/scm/linux/kernel/git/will/linux into arm/smmu
Merge branches 'apple/dart', 'arm/smmu', 'iommu/fixes', 'x86/amd', 'x86/vt-d' and 'core' into next
John Garry (5):
iommu: Deprecate Intel and AMD cmdline methods to enable strict mode
iommu: Print strict or lazy mode at init time
iommu: Remove mode argument from iommu_set_dma_strict()
iommu/arm-smmu-v3: Remove some unneeded init in arm_smmu_cmdq_issue_cmdlist()
iommu/arm-smmu-v3: Stop pre-zeroing batch commands
Krishna Reddy (1):
iommu/arm-smmu: Fix race condition during iommu_group creation
Lennert Buytenhek (1):
iommu/amd: Fix printing of IOMMU events when rate limiting kicks in
Liu Yi L (3):
iommu/vt-d: Fix incomplete cache flush in intel_pasid_tear_down_entry()
iommu/vt-d: Use pasid_pte_is_present() helper function
iommu/vt-d: Add present bit check in pasid entry setup helpers
Lu Baolu (8):
iommu/vt-d: Report real pgsize bitmap to iommu core
iommu/vt-d: Implement map/unmap_pages() iommu_ops callback
iommu/vt-d: Move clflush'es from iotlb_sync_map() to map_pages()
iommu/vt-d: Update the virtual command related registers
iommu/vt-d: Refactor Kconfig a bit
iommu/vt-d: Enable Intel IOMMU scalable mode by default
iommu/vt-d: Preset A/D bits for user space DMA usage
iommu/vt-d: Allow devices to have more than 32 outstanding PRs
Nadav Amit (6):
iommu/amd: Selective flush on unmap
iommu/amd: Do not use flush-queue when NpCache is on
iommu: Factor iommu_iotlb_gather_is_disjoint() out
iommu/amd: Tailored gather logic for AMD
iommu/amd: Sync once for scatter-gather operations
iommu/amd: Use only natural aligned flushes in a VM
Robin Murphy (26):
iommu: Streamline iommu_iova_to_phys()
iommu: Improve iommu_iotlb_gather helpers
iommu: Pull IOVA cookie management into the core
iommu/amd: Drop IOVA cookie management
iommu/arm-smmu: Drop IOVA cookie management
iommu/vt-d: Drop IOVA cookie management
iommu/exynos: Drop IOVA cookie management
iommu/ipmmu-vmsa: Drop IOVA cookie management
iommu/mtk: Drop IOVA cookie management
iommu/rockchip: Drop IOVA cookie management
iommu/sprd: Drop IOVA cookie management
iommu/sun50i: Drop IOVA cookie management
iommu/virtio: Drop IOVA cookie management
iommu/dma: Remove redundant "!dev" checks
iommu: Indicate queued flushes via gather data
iommu/io-pgtable: Remove non-strict quirk
iommu: Introduce explicit type for non-strict DMA domains
iommu/amd: Prepare for multiple DMA domain types
iommu/arm-smmu: Prepare for multiple DMA domain types
iommu/vt-d: Prepare for multiple DMA domain types
iommu: Express DMA strictness via the domain type
iommu: Expose DMA domain strictness via sysfs
iommu: Only log strictness for DMA domains
iommu: Merge strictness and domain type configs
iommu: Allow enabling non-strict mode dynamically
iommu/io-pgtable: Abstract iommu_iotlb_gather access
Sai Prakash Ranjan (2):
iommu/arm-smmu: Add clk_bulk_{prepare/unprepare} to system pm callbacks
iommu/arm-smmu: Optimize ->tlb_flush_walk() for qcom implementation
Sven Peter (3):
iommu/io-pgtable: Add DART pagetable format
dt-bindings: iommu: add DART iommu bindings
iommu/dart: Add DART iommu driver
Will Deacon (3):
iommu: Use bitmap to calculate page size in iommu_pgsize()
iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts
iommu: Hook up '->unmap_pages' driver callback
Xiang Chen (2):
iommu/arm-smmu-v3: Implement the unmap_pages() IOMMU driver callback
iommu/arm-smmu-v3: Implement the map_pages() IOMMU driver callback
Xiyu Yang via iommu (1):
iommu/amd: Convert from atomic_t to refcount_t on pasid_state->count
Yang Yingliang (1):
iommu/arm-smmu: Fix missing unlock on error in arm_smmu_device_group()
Zhen Lei (8):
iommu: Enhance IOMMU default DMA mode build options
iommu/vt-d: Add support for IOMMU default DMA mode build options
iommu/amd: Add support for IOMMU default DMA mode build options
iommu/arm-smmu-v3: Use command queue batching helpers to improve performance
iommu/arm-smmu-v3: Add and use static helper function arm_smmu_cmdq_issue_cmd_with_sync()
iommu/arm-smmu-v3: Add and use static helper function arm_smmu_get_cmdq()
iommu/arm-smmu-v3: Extract reusable function __arm_smmu_cmdq_skip_err()
iommu/vt-d: Remove unnecessary oom message
.../ABI/testing/sysfs-kernel-iommu_groups | 6 +-
Documentation/admin-guide/kernel-parameters.txt | 29 +-
.../devicetree/bindings/iommu/apple,dart.yaml | 81 ++
MAINTAINERS | 7 +
drivers/iommu/Kconfig | 69 +-
drivers/iommu/Makefile | 1 +
drivers/iommu/amd/amd_iommu_types.h | 6 -
drivers/iommu/amd/init.c | 12 +-
drivers/iommu/amd/io_pgtable.c | 3 -
drivers/iommu/amd/iommu.c | 151 +++-
drivers/iommu/amd/iommu_v2.c | 13 +-
drivers/iommu/apple-dart.c | 923 +++++++++++++++++++++
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 121 +--
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 11 +
drivers/iommu/arm/arm-smmu/arm-smmu.c | 89 +-
drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 +
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 9 -
drivers/iommu/dma-iommu.c | 52 +-
drivers/iommu/exynos-iommu.c | 19 +-
drivers/iommu/intel/Kconfig | 19 +-
drivers/iommu/intel/dmar.c | 2 -
drivers/iommu/intel/iommu.c | 197 ++---
drivers/iommu/intel/pasid.c | 28 +-
drivers/iommu/intel/pasid.h | 16 +-
drivers/iommu/intel/perf.c | 2 +-
drivers/iommu/intel/svm.c | 7 +-
drivers/iommu/io-pgtable-arm-v7s.c | 62 +-
drivers/iommu/io-pgtable-arm.c | 282 +++++--
drivers/iommu/io-pgtable.c | 1 +
drivers/iommu/iommu.c | 198 +++--
drivers/iommu/iova.c | 14 +-
drivers/iommu/ipmmu-vmsa.c | 28 +-
drivers/iommu/mtk_iommu.c | 13 +-
drivers/iommu/mtk_iommu_v1.c | 1 -
drivers/iommu/rockchip-iommu.c | 12 +-
drivers/iommu/sprd-iommu.c | 7 -
drivers/iommu/sun50i-iommu.c | 13 +-
drivers/iommu/virtio-iommu.c | 8 -
include/linux/dma-iommu.h | 6 +
include/linux/intel-iommu.h | 6 +-
include/linux/intel-svm.h | 5 +
include/linux/io-pgtable.h | 20 +-
include/linux/iommu.h | 114 ++-
43 files changed, 2054 insertions(+), 610 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iommu/apple,dart.yaml
create mode 100644 drivers/iommu/apple-dart.c
Please pull.
Thanks,
Joerg
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
2021-09-03 14:03 ` Joerg Roedel
@ 2021-09-03 18:43 ` Linus Torvalds
-1 siblings, 0 replies; 10+ messages in thread
From: Linus Torvalds @ 2021-09-03 18:43 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Will Deacon, Linux Kernel Mailing List, iommu
On Fri, Sep 3, 2021 at 7:03 AM Joerg Roedel <joro@8bytes.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
So I've merged this, but I'm not entirely happy with some of the
rather insane Kconfig choices.
In particular, the defaults for this:
choice
prompt "IOMMU default domain type"
depends on IOMMU_API
default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
default IOMMU_DEFAULT_DMA_STRICT
seems fundamentally confused about what the h*ll is going on.
Why? Because a choice like "AMD_IOMMU" or "INTEL_IOMMU" isn't some
exclusive thing. You can have one or the other - or both. Or you could
have another IOMMU entirely, despite _also_ having AMD/INTEL_IOMMU
enabled as a config option.
IOW, maybe INTEL or AMD_IOMMU is enabled in the kernel configuration,
but that might not be the IOMMU that is then actually *active*.
The active IOMMU might be VIRTIO_IOMMU, for example.
See what I'm saying? Making the default be based on some random "this
driver is enabled" when it can then affect *other* drivers that are
also enabled and not part of the decision seems to be a fundamental
confusion about what is going on, when it's not at all clear which
driver will actually be IN USE.
Now, I don't think this _matters_ that much in practice, and as
mentioned, I already merged things.
But I think people should seriously think about either
(a) make that default something that is actually *reliable*, so that
the fact that you have possibly enabled iommu X doesn't affect iommu Y
that is actually the one in use
or
(b) make the defaults be actually per-driver, and set when the driver
is in *use* rather than this incorrect model of "enabled but maybe not
even used".
IOW, the fix might be to just say "the default is always lazy".
Or the fix might be something that is global to a configuration and
doesn't rely on which iommu is in use (eg "on x86, the default is
always LAZY")
Or the fix is to make that 'iommu_dma_strict' variable - and the
default value for it - be a per-IOMMU thing rather than be a global.
Hmm?
Linus
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-03 18:43 ` Linus Torvalds
0 siblings, 0 replies; 10+ messages in thread
From: Linus Torvalds @ 2021-09-03 18:43 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, Will Deacon, Linux Kernel Mailing List
On Fri, Sep 3, 2021 at 7:03 AM Joerg Roedel <joro@8bytes.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
So I've merged this, but I'm not entirely happy with some of the
rather insane Kconfig choices.
In particular, the defaults for this:
choice
prompt "IOMMU default domain type"
depends on IOMMU_API
default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
default IOMMU_DEFAULT_DMA_STRICT
seems fundamentally confused about what the h*ll is going on.
Why? Because a choice like "AMD_IOMMU" or "INTEL_IOMMU" isn't some
exclusive thing. You can have one or the other - or both. Or you could
have another IOMMU entirely, despite _also_ having AMD/INTEL_IOMMU
enabled as a config option.
IOW, maybe INTEL or AMD_IOMMU is enabled in the kernel configuration,
but that might not be the IOMMU that is then actually *active*.
The active IOMMU might be VIRTIO_IOMMU, for example.
See what I'm saying? Making the default be based on some random "this
driver is enabled" when it can then affect *other* drivers that are
also enabled and not part of the decision seems to be a fundamental
confusion about what is going on, when it's not at all clear which
driver will actually be IN USE.
Now, I don't think this _matters_ that much in practice, and as
mentioned, I already merged things.
But I think people should seriously think about either
(a) make that default something that is actually *reliable*, so that
the fact that you have possibly enabled iommu X doesn't affect iommu Y
that is actually the one in use
or
(b) make the defaults be actually per-driver, and set when the driver
is in *use* rather than this incorrect model of "enabled but maybe not
even used".
IOW, the fix might be to just say "the default is always lazy".
Or the fix might be something that is global to a configuration and
doesn't rely on which iommu is in use (eg "on x86, the default is
always LAZY")
Or the fix is to make that 'iommu_dma_strict' variable - and the
default value for it - be a per-IOMMU thing rather than be a global.
Hmm?
Linus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
2021-09-03 14:03 ` Joerg Roedel
@ 2021-09-03 18:45 ` pr-tracker-bot
-1 siblings, 0 replies; 10+ messages in thread
From: pr-tracker-bot @ 2021-09-03 18:45 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Linus Torvalds, Will Deacon, linux-kernel, iommu
The pull request you sent on Fri, 3 Sep 2021 16:03:11 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/69a5c49a9147e9daca76201e3d6edfea5ed8403a
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-03 18:45 ` pr-tracker-bot
0 siblings, 0 replies; 10+ messages in thread
From: pr-tracker-bot @ 2021-09-03 18:45 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Will Deacon, iommu, Linus Torvalds, linux-kernel
The pull request you sent on Fri, 3 Sep 2021 16:03:11 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-updates-v5.15
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/69a5c49a9147e9daca76201e3d6edfea5ed8403a
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
2021-09-03 18:43 ` Linus Torvalds
@ 2021-09-03 21:44 ` Joerg Roedel
-1 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2021-09-03 21:44 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Will Deacon, Linux Kernel Mailing List, iommu
On Fri, Sep 03, 2021 at 11:43:31AM -0700, Linus Torvalds wrote:
> choice
> prompt "IOMMU default domain type"
> depends on IOMMU_API
> default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
> default IOMMU_DEFAULT_DMA_STRICT
Huh, yeah, that is bogus. Seems like I overlooked that part of the
patch-set because I was so amazed by the simplifications and cleanups in
the rest of it.
> See what I'm saying? Making the default be based on some random "this
> driver is enabled" when it can then affect *other* drivers that are
> also enabled and not part of the decision seems to be a fundamental
> confusion about what is going on, when it's not at all clear which
> driver will actually be IN USE.
The Kconfig option itself was actually my suggestion, but how the
default value is chosen certainly needs improvement. I will sort this
out with the people involved.
> IOW, the fix might be to just say "the default is always lazy".
>
> Or the fix might be something that is global to a configuration and
> doesn't rely on which iommu is in use (eg "on x86, the default is
> always LAZY")
>
> Or the fix is to make that 'iommu_dma_strict' variable - and the
> default value for it - be a per-IOMMU thing rather than be a global.
My preference would be to make 'lazy' or 'strict' the default for all,
but the ARM folks might disagree. On the other side it also doesn't make
sense to let IOMMU drivers override the users Kconfig choice at runtime.
We will discuss this and come up with something better.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-03 21:44 ` Joerg Roedel
0 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2021-09-03 21:44 UTC (permalink / raw)
To: Linus Torvalds; +Cc: iommu, Will Deacon, Linux Kernel Mailing List
On Fri, Sep 03, 2021 at 11:43:31AM -0700, Linus Torvalds wrote:
> choice
> prompt "IOMMU default domain type"
> depends on IOMMU_API
> default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
> default IOMMU_DEFAULT_DMA_STRICT
Huh, yeah, that is bogus. Seems like I overlooked that part of the
patch-set because I was so amazed by the simplifications and cleanups in
the rest of it.
> See what I'm saying? Making the default be based on some random "this
> driver is enabled" when it can then affect *other* drivers that are
> also enabled and not part of the decision seems to be a fundamental
> confusion about what is going on, when it's not at all clear which
> driver will actually be IN USE.
The Kconfig option itself was actually my suggestion, but how the
default value is chosen certainly needs improvement. I will sort this
out with the people involved.
> IOW, the fix might be to just say "the default is always lazy".
>
> Or the fix might be something that is global to a configuration and
> doesn't rely on which iommu is in use (eg "on x86, the default is
> always LAZY")
>
> Or the fix is to make that 'iommu_dma_strict' variable - and the
> default value for it - be a per-IOMMU thing rather than be a global.
My preference would be to make 'lazy' or 'strict' the default for all,
but the ARM folks might disagree. On the other side it also doesn't make
sense to let IOMMU drivers override the users Kconfig choice at runtime.
We will discuss this and come up with something better.
Thanks,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
2021-09-03 21:44 ` Joerg Roedel
@ 2021-09-06 11:06 ` Robin Murphy
-1 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2021-09-06 11:06 UTC (permalink / raw)
To: Joerg Roedel, Linus Torvalds
Cc: iommu, Will Deacon, Linux Kernel Mailing List
On 2021-09-03 22:44, Joerg Roedel wrote:
> On Fri, Sep 03, 2021 at 11:43:31AM -0700, Linus Torvalds wrote:
>> choice
>> prompt "IOMMU default domain type"
>> depends on IOMMU_API
>> default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
>> default IOMMU_DEFAULT_DMA_STRICT
>
> Huh, yeah, that is bogus. Seems like I overlooked that part of the
> patch-set because I was so amazed by the simplifications and cleanups in
> the rest of it.
Mad as it looks, this does in fact capture the existing behaviour. What
we've consolidated here was previously a weird mix of driver- and
subsystem-level controls, and it is specifically those two drivers which
have a long-standing expectation of using lazy behaviour by default.
>> See what I'm saying? Making the default be based on some random "this
>> driver is enabled" when it can then affect *other* drivers that are
>> also enabled and not part of the decision seems to be a fundamental
>> confusion about what is going on, when it's not at all clear which
>> driver will actually be IN USE.
>
> The Kconfig option itself was actually my suggestion, but how the
> default value is chosen certainly needs improvement. I will sort this
> out with the people involved.
>
>> IOW, the fix might be to just say "the default is always lazy".
>>
>> Or the fix might be something that is global to a configuration and
>> doesn't rely on which iommu is in use (eg "on x86, the default is
>> always LAZY")
We could certainly express it as "default IOMMU_DEFAULT_DMA_LAZY if X86"
if people would prefer - virtio-iommu doesn't support lazy mode either
way, so the end result will still be equivalent.
Robin.
>> Or the fix is to make that 'iommu_dma_strict' variable - and the
>> default value for it - be a per-IOMMU thing rather than be a global.
>
> My preference would be to make 'lazy' or 'strict' the default for all,
> but the ARM folks might disagree. On the other side it also doesn't make
> sense to let IOMMU drivers override the users Kconfig choice at runtime.
> We will discuss this and come up with something better. >
> Thanks,
>
> Joerg
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [git pull] IOMMU Updates for Linux v5.15
@ 2021-09-06 11:06 ` Robin Murphy
0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2021-09-06 11:06 UTC (permalink / raw)
To: Joerg Roedel, Linus Torvalds
Cc: iommu, Will Deacon, Linux Kernel Mailing List
On 2021-09-03 22:44, Joerg Roedel wrote:
> On Fri, Sep 03, 2021 at 11:43:31AM -0700, Linus Torvalds wrote:
>> choice
>> prompt "IOMMU default domain type"
>> depends on IOMMU_API
>> default IOMMU_DEFAULT_DMA_LAZY if AMD_IOMMU || INTEL_IOMMU
>> default IOMMU_DEFAULT_DMA_STRICT
>
> Huh, yeah, that is bogus. Seems like I overlooked that part of the
> patch-set because I was so amazed by the simplifications and cleanups in
> the rest of it.
Mad as it looks, this does in fact capture the existing behaviour. What
we've consolidated here was previously a weird mix of driver- and
subsystem-level controls, and it is specifically those two drivers which
have a long-standing expectation of using lazy behaviour by default.
>> See what I'm saying? Making the default be based on some random "this
>> driver is enabled" when it can then affect *other* drivers that are
>> also enabled and not part of the decision seems to be a fundamental
>> confusion about what is going on, when it's not at all clear which
>> driver will actually be IN USE.
>
> The Kconfig option itself was actually my suggestion, but how the
> default value is chosen certainly needs improvement. I will sort this
> out with the people involved.
>
>> IOW, the fix might be to just say "the default is always lazy".
>>
>> Or the fix might be something that is global to a configuration and
>> doesn't rely on which iommu is in use (eg "on x86, the default is
>> always LAZY")
We could certainly express it as "default IOMMU_DEFAULT_DMA_LAZY if X86"
if people would prefer - virtio-iommu doesn't support lazy mode either
way, so the end result will still be equivalent.
Robin.
>> Or the fix is to make that 'iommu_dma_strict' variable - and the
>> default value for it - be a per-IOMMU thing rather than be a global.
>
> My preference would be to make 'lazy' or 'strict' the default for all,
> but the ARM folks might disagree. On the other side it also doesn't make
> sense to let IOMMU drivers override the users Kconfig choice at runtime.
> We will discuss this and come up with something better. >
> Thanks,
>
> Joerg
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-09-06 11:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 14:03 [git pull] IOMMU Updates for Linux v5.15 Joerg Roedel
2021-09-03 14:03 ` Joerg Roedel
2021-09-03 18:43 ` Linus Torvalds
2021-09-03 18:43 ` Linus Torvalds
2021-09-03 21:44 ` Joerg Roedel
2021-09-03 21:44 ` Joerg Roedel
2021-09-06 11:06 ` Robin Murphy
2021-09-06 11:06 ` Robin Murphy
2021-09-03 18:45 ` pr-tracker-bot
2021-09-03 18:45 ` pr-tracker-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.