* [PATCH] staging: r8188eu: include: remove duplicate declaration.
@ 2021-09-05 7:14 Saurav Girepunje
2021-09-06 9:48 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Saurav Girepunje @ 2021-09-05 7:14 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, saurav.girepunje, linux-kernel
Cc: saurav.girepunje
Remove below duplicate declaration from rtl8188e_led.h file
void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
index b00954198764..02cdc970bb17 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_led.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
@@ -12,7 +12,5 @@
/* */
void rtl8188eu_InitSwLeds(struct adapter *padapter);
void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
-void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
-void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.
2021-09-05 7:14 [PATCH] staging: r8188eu: include: remove duplicate declaration Saurav Girepunje
@ 2021-09-06 9:48 ` Greg KH
2021-09-06 16:34 ` Saurav Girepunje
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-09-06 9:48 UTC (permalink / raw)
To: Saurav Girepunje; +Cc: Larry.Finger, phil, linux-kernel, saurav.girepunje
On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> Remove below duplicate declaration from rtl8188e_led.h file
>
> void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> index b00954198764..02cdc970bb17 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> @@ -12,7 +12,5 @@
> /* */
> void rtl8188eu_InitSwLeds(struct adapter *padapter);
> void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>
> #endif
> --
> 2.32.0
>
This email did not make it to lore.kernel.org again:
https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
Any ideas what is happening?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.
2021-09-06 9:48 ` Greg KH
@ 2021-09-06 16:34 ` Saurav Girepunje
2021-09-07 6:28 ` Greg KH
2021-09-07 6:40 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Saurav Girepunje @ 2021-09-06 16:34 UTC (permalink / raw)
To: Greg KH; +Cc: saurav.girepunje, Larry.Finger, phil, linux-kernel
On 06/09/21 3:18 pm, Greg KH wrote:
> On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
>> Remove below duplicate declaration from rtl8188e_led.h file
>>
>> void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
>> void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
>> index b00954198764..02cdc970bb17 100644
>> --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
>> +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
>> @@ -12,7 +12,5 @@
>> /* */
>> void rtl8188eu_InitSwLeds(struct adapter *padapter);
>> void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
>> -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
>> -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>>
>> #endif
>> --
>> 2.32.0
>>
>
> This email did not make it to lore.kernel.org again:
> https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
>
> Any ideas what is happening?
> linux-staging@lists.linux.dev
> thanks,
>
> greg k-h
>
I missed to add the linux-staging@lists.linux.dev. I will resend it v2
version of this patch.
However I am able to see it on https://lore.kernel.org .
https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/
Regards,
Saurav Girepunje
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.
2021-09-06 16:34 ` Saurav Girepunje
@ 2021-09-07 6:28 ` Greg KH
2021-09-07 6:40 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-09-07 6:28 UTC (permalink / raw)
To: Saurav Girepunje; +Cc: saurav.girepunje, Larry.Finger, phil, linux-kernel
On Mon, Sep 06, 2021 at 10:04:07PM +0530, Saurav Girepunje wrote:
>
>
> On 06/09/21 3:18 pm, Greg KH wrote:
> > On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> > > Remove below duplicate declaration from rtl8188e_led.h file
> > >
> > > void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > > drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > index b00954198764..02cdc970bb17 100644
> > > --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > @@ -12,7 +12,5 @@
> > > /* */
> > > void rtl8188eu_InitSwLeds(struct adapter *padapter);
> > > void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> > > -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > #endif
> > > --
> > > 2.32.0
> > >
> >
> > This email did not make it to lore.kernel.org again:
> > https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
> >
> > Any ideas what is happening?
> > linux-staging@lists.linux.dev
> > thanks,
> >
> > greg k-h
> >
>
> I missed to add the linux-staging@lists.linux.dev. I will resend it v2
> version of this patch.
> However I am able to see it on https://lore.kernel.org .
>
> https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/
Ah, your message id has a '/' character in it, that's what is breaking
the scripts...
Let me see what needs to be fixed up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.
2021-09-06 16:34 ` Saurav Girepunje
2021-09-07 6:28 ` Greg KH
@ 2021-09-07 6:40 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-09-07 6:40 UTC (permalink / raw)
To: Saurav Girepunje; +Cc: saurav.girepunje, Larry.Finger, phil, linux-kernel
On Mon, Sep 06, 2021 at 10:04:07PM +0530, Saurav Girepunje wrote:
>
>
> On 06/09/21 3:18 pm, Greg KH wrote:
> > On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> > > Remove below duplicate declaration from rtl8188e_led.h file
> > >
> > > void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > > drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > index b00954198764..02cdc970bb17 100644
> > > --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > @@ -12,7 +12,5 @@
> > > /* */
> > > void rtl8188eu_InitSwLeds(struct adapter *padapter);
> > > void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> > > -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > #endif
> > > --
> > > 2.32.0
> > >
> >
> > This email did not make it to lore.kernel.org again:
> > https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
> >
> > Any ideas what is happening?
> > linux-staging@lists.linux.dev
> > thanks,
> >
> > greg k-h
> >
>
> I missed to add the linux-staging@lists.linux.dev. I will resend it v2
> version of this patch.
> However I am able to see it on https://lore.kernel.org .
>
> https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/
You are right, that is odd. I've emailed the b4 developer to see what
is up with this, I'll take this patch in a bit...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-07 6:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 7:14 [PATCH] staging: r8188eu: include: remove duplicate declaration Saurav Girepunje
2021-09-06 9:48 ` Greg KH
2021-09-06 16:34 ` Saurav Girepunje
2021-09-07 6:28 ` Greg KH
2021-09-07 6:40 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.