* [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set
@ 2021-09-06 15:39 Thomas Huth
2021-09-06 15:40 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2021-09-06 15:39 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini; +Cc: Daniel P. Berrangé, kraxel
When running "./configure --static --disable-system" there is currently
a warning if the static version of libpng is missing:
WARNING: Static library 'png16' not found for dependency 'libpng', may not
be statically linked
Since it does not make sense to look for the VNC-related libraries at all
when we're building without system emulator binaries, let's add a check
for have_system here to silence this warning.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 7e58e6279b..f07236d947 100644
--- a/meson.build
+++ b/meson.build
@@ -931,7 +931,7 @@ vnc = not_found
png = not_found
jpeg = not_found
sasl = not_found
-if not get_option('vnc').disabled()
+if have_system and not get_option('vnc').disabled()
vnc = declare_dependency() # dummy dependency
png = dependency('libpng', required: get_option('vnc_png'),
method: 'pkg-config', kwargs: static_kwargs)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set
2021-09-06 15:39 [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set Thomas Huth
@ 2021-09-06 15:40 ` Daniel P. Berrangé
2021-09-06 15:59 ` Philippe Mathieu-Daudé
2021-09-07 12:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2021-09-06 15:40 UTC (permalink / raw)
To: Thomas Huth; +Cc: Paolo Bonzini, qemu-devel, kraxel
On Mon, Sep 06, 2021 at 05:39:39PM +0200, Thomas Huth wrote:
> When running "./configure --static --disable-system" there is currently
> a warning if the static version of libpng is missing:
>
> WARNING: Static library 'png16' not found for dependency 'libpng', may not
> be statically linked
>
> Since it does not make sense to look for the VNC-related libraries at all
> when we're building without system emulator binaries, let's add a check
> for have_system here to silence this warning.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7e58e6279b..f07236d947 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -931,7 +931,7 @@ vnc = not_found
> png = not_found
> jpeg = not_found
> sasl = not_found
> -if not get_option('vnc').disabled()
> +if have_system and not get_option('vnc').disabled()
> vnc = declare_dependency() # dummy dependency
> png = dependency('libpng', required: get_option('vnc_png'),
> method: 'pkg-config', kwargs: static_kwargs)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set
2021-09-06 15:39 [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set Thomas Huth
2021-09-06 15:40 ` Daniel P. Berrangé
@ 2021-09-06 15:59 ` Philippe Mathieu-Daudé
2021-09-07 12:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-06 15:59 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini; +Cc: Daniel P. Berrangé, kraxel
On 9/6/21 5:39 PM, Thomas Huth wrote:
> When running "./configure --static --disable-system" there is currently
> a warning if the static version of libpng is missing:
>
> WARNING: Static library 'png16' not found for dependency 'libpng', may not
> be statically linked
>
> Since it does not make sense to look for the VNC-related libraries at all
> when we're building without system emulator binaries, let's add a check
> for have_system here to silence this warning.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set
2021-09-06 15:39 [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set Thomas Huth
2021-09-06 15:40 ` Daniel P. Berrangé
2021-09-06 15:59 ` Philippe Mathieu-Daudé
@ 2021-09-07 12:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-09-07 12:52 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Daniel P. Berrangé, kraxel
On 06/09/21 17:39, Thomas Huth wrote:
> When running "./configure --static --disable-system" there is currently
> a warning if the static version of libpng is missing:
>
> WARNING: Static library 'png16' not found for dependency 'libpng', may not
> be statically linked
>
> Since it does not make sense to look for the VNC-related libraries at all
> when we're building without system emulator binaries, let's add a check
> for have_system here to silence this warning.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 7e58e6279b..f07236d947 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -931,7 +931,7 @@ vnc = not_found
> png = not_found
> jpeg = not_found
> sasl = not_found
> -if not get_option('vnc').disabled()
> +if have_system and not get_option('vnc').disabled()
> vnc = declare_dependency() # dummy dependency
> png = dependency('libpng', required: get_option('vnc_png'),
> method: 'pkg-config', kwargs: static_kwargs)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-07 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 15:39 [PATCH] meson.build: Do not look for VNC-related libraries if have_system is not set Thomas Huth
2021-09-06 15:40 ` Daniel P. Berrangé
2021-09-06 15:59 ` Philippe Mathieu-Daudé
2021-09-07 12:52 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.