* [PATCH v2] include/block.h: remove outdated comment
@ 2021-09-03 11:38 Emanuele Giuseppe Esposito
2021-09-06 14:32 ` Stefan Hajnoczi
2021-09-13 11:35 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Emanuele Giuseppe Esposito @ 2021-09-03 11:38 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, Emanuele Giuseppe Esposito, Hanna Reitz, qemu-devel,
Stefan Hajnoczi
There are a couple of errors in bdrv_drained_begin header comment:
- block_job_pause does not exist anymore, it has been replaced
with job_pause in b15de82867
- job_pause is automatically invoked as a .drained_begin callback
(child_job_drained_begin) by the child_job BdrvChildClass struct
in blockjob.c. So no additional pause should be required.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
v2:
+ add "block jobs" to the external request sources
include/block/block.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index 3477290f9a..de40758e71 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -749,9 +749,7 @@ bool bdrv_drain_poll(BlockDriverState *bs, bool recursive,
* bdrv_drained_begin:
*
* Begin a quiesced section for exclusive access to the BDS, by disabling
- * external request sources including NBD server and device model. Note that
- * this doesn't block timers or coroutines from submitting more requests, which
- * means block_job_pause is still necessary.
+ * external request sources including NBD server, block jobs, and device model.
*
* This function can be recursive.
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] include/block.h: remove outdated comment
2021-09-03 11:38 [PATCH v2] include/block.h: remove outdated comment Emanuele Giuseppe Esposito
@ 2021-09-06 14:32 ` Stefan Hajnoczi
2021-09-13 11:35 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2021-09-06 14:32 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito
Cc: Kevin Wolf, Hanna Reitz, qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Fri, Sep 03, 2021 at 01:38:00PM +0200, Emanuele Giuseppe Esposito wrote:
> There are a couple of errors in bdrv_drained_begin header comment:
> - block_job_pause does not exist anymore, it has been replaced
> with job_pause in b15de82867
> - job_pause is automatically invoked as a .drained_begin callback
> (child_job_drained_begin) by the child_job BdrvChildClass struct
> in blockjob.c. So no additional pause should be required.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> v2:
> + add "block jobs" to the external request sources
>
> include/block/block.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] include/block.h: remove outdated comment
2021-09-03 11:38 [PATCH v2] include/block.h: remove outdated comment Emanuele Giuseppe Esposito
2021-09-06 14:32 ` Stefan Hajnoczi
@ 2021-09-13 11:35 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2021-09-13 11:35 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito
Cc: Hanna Reitz, Stefan Hajnoczi, qemu-block, qemu-devel
Am 03.09.2021 um 13:38 hat Emanuele Giuseppe Esposito geschrieben:
> There are a couple of errors in bdrv_drained_begin header comment:
> - block_job_pause does not exist anymore, it has been replaced
> with job_pause in b15de82867
> - job_pause is automatically invoked as a .drained_begin callback
> (child_job_drained_begin) by the child_job BdrvChildClass struct
> in blockjob.c. So no additional pause should be required.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-13 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 11:38 [PATCH v2] include/block.h: remove outdated comment Emanuele Giuseppe Esposito
2021-09-06 14:32 ` Stefan Hajnoczi
2021-09-13 11:35 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.