From: Ming Lei <ming.lei@redhat.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com,
beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com,
swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com,
josef@toxicpanda.com, hch@infradead.org, hare@suse.de,
bvanassche@acm.org, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org,
dm-devel@redhat.com, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 2/8] scsi/sr: add error handling support for add_disk()
Date: Tue, 7 Sep 2021 09:37:05 +0800 [thread overview]
Message-ID: <YTbCQdieHG07Bz8W@T590> (raw)
In-Reply-To: <20210830212538.148729-3-mcgrof@kernel.org>
On Mon, Aug 30, 2021 at 02:25:32PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> drivers/scsi/sr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> index 2942a4ec9bdd..72fd21844367 100644
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@ -779,7 +779,10 @@ static int sr_probe(struct device *dev)
> dev_set_drvdata(dev, cd);
> disk->flags |= GENHD_FL_REMOVABLE;
> sr_revalidate_disk(cd);
> - device_add_disk(&sdev->sdev_gendev, disk, NULL);
> +
> + error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
> + if (error)
> + goto fail_minor;
You don't undo register_cdrom(), maybe you can use kref_put(&cd->kref, sr_kref_release);
to simplify the error handling.
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: ulf.hansson@linaro.org, snitzer@redhat.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
agk@redhat.com, beanhuo@micron.com, sagi@grimberg.me,
linux-scsi@vger.kernel.org, hch@infradead.org,
jejb@linux.ibm.com, josef@toxicpanda.com, swboyd@chromium.org,
linux-block@vger.kernel.org, avri.altman@wdc.com,
kbusch@kernel.org, nbd@other.debian.org, bvanassche@acm.org,
axboe@kernel.dk, martin.petersen@oracle.com,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com
Subject: Re: [dm-devel] [PATCH v3 2/8] scsi/sr: add error handling support for add_disk()
Date: Tue, 7 Sep 2021 09:37:05 +0800 [thread overview]
Message-ID: <YTbCQdieHG07Bz8W@T590> (raw)
In-Reply-To: <20210830212538.148729-3-mcgrof@kernel.org>
On Mon, Aug 30, 2021 at 02:25:32PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> drivers/scsi/sr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> index 2942a4ec9bdd..72fd21844367 100644
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@ -779,7 +779,10 @@ static int sr_probe(struct device *dev)
> dev_set_drvdata(dev, cd);
> disk->flags |= GENHD_FL_REMOVABLE;
> sr_revalidate_disk(cd);
> - device_add_disk(&sdev->sdev_gendev, disk, NULL);
> +
> + error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
> + if (error)
> + goto fail_minor;
You don't undo register_cdrom(), maybe you can use kref_put(&cd->kref, sr_kref_release);
to simplify the error handling.
Thanks,
Ming
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com,
beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com,
swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com,
josef@toxicpanda.com, hch@infradead.org, hare@suse.de,
bvanassche@acm.org, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org,
dm-devel@redhat.com, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 2/8] scsi/sr: add error handling support for add_disk()
Date: Tue, 7 Sep 2021 09:37:05 +0800 [thread overview]
Message-ID: <YTbCQdieHG07Bz8W@T590> (raw)
In-Reply-To: <20210830212538.148729-3-mcgrof@kernel.org>
On Mon, Aug 30, 2021 at 02:25:32PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> drivers/scsi/sr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> index 2942a4ec9bdd..72fd21844367 100644
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@ -779,7 +779,10 @@ static int sr_probe(struct device *dev)
> dev_set_drvdata(dev, cd);
> disk->flags |= GENHD_FL_REMOVABLE;
> sr_revalidate_disk(cd);
> - device_add_disk(&sdev->sdev_gendev, disk, NULL);
> +
> + error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
> + if (error)
> + goto fail_minor;
You don't undo register_cdrom(), maybe you can use kref_put(&cd->kref, sr_kref_release);
to simplify the error handling.
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-07 1:37 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 21:25 [PATCH v3 0/8] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 1/8] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:13 ` Hannes Reinecke
2021-09-06 6:13 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:13 ` Hannes Reinecke
2021-09-07 1:29 ` Ming Lei
2021-09-07 1:29 ` Ming Lei
2021-09-07 1:29 ` [dm-devel] " Ming Lei
2021-09-13 17:21 ` Luis Chamberlain
2021-09-13 17:21 ` [dm-devel] " Luis Chamberlain
2021-09-13 17:21 ` Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 2/8] scsi/sr: " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-09-06 6:13 ` Hannes Reinecke
2021-09-06 6:13 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:13 ` Hannes Reinecke
2021-09-07 1:37 ` Ming Lei [this message]
2021-09-07 1:37 ` Ming Lei
2021-09-07 1:37 ` [dm-devel] " Ming Lei
2021-09-13 17:26 ` Luis Chamberlain
2021-09-13 17:26 ` Luis Chamberlain
2021-09-13 17:26 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 3/8] nvme: " Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:16 ` Hannes Reinecke
2021-09-06 6:16 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:16 ` Hannes Reinecke
2021-09-06 8:09 ` Christoph Hellwig
2021-09-06 8:09 ` [dm-devel] " Christoph Hellwig
2021-09-06 8:09 ` Christoph Hellwig
2021-09-06 8:09 ` Christoph Hellwig
2021-09-06 8:09 ` [dm-devel] " Christoph Hellwig
2021-09-06 8:09 ` Christoph Hellwig
2021-08-30 21:25 ` [PATCH v3 4/8] mmc/core/block: " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-09-06 17:10 ` Ulf Hansson
2021-09-06 17:10 ` [dm-devel] " Ulf Hansson
2021-09-06 17:10 ` Ulf Hansson
2021-08-30 21:25 ` [PATCH v3 5/8] md: " Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:17 ` Hannes Reinecke
2021-09-06 6:17 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:17 ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 6/8] dm: add add_disk() error handling Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:19 ` Hannes Reinecke
2021-09-06 6:19 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:19 ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 7/8] loop: add error handling support for add_disk() Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:19 ` Hannes Reinecke
2021-09-06 6:19 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:19 ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 8/8] nbd: " Luis Chamberlain
2021-08-30 21:25 ` [dm-devel] " Luis Chamberlain
2021-08-30 21:25 ` Luis Chamberlain
2021-09-06 6:20 ` Hannes Reinecke
2021-09-06 6:20 ` [dm-devel] " Hannes Reinecke
2021-09-06 6:20 ` Hannes Reinecke
2021-09-01 4:19 ` [PATCH v3 0/8] block: first batch of add_disk() error handling conversions Tetsuo Handa
2021-09-01 5:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTbCQdieHG07Bz8W@T590 \
--to=ming.lei@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=agk@redhat.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=nbd@other.debian.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.