* Re: patch "staging: r8188eu: Remove _enter/_exit_critical_mutex()" added to staging-testing
[not found] <1630997812180231@kroah.com>
@ 2021-09-07 9:00 ` Fabio M. De Francesco
2021-09-07 10:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Fabio M. De Francesco @ 2021-09-07 9:00 UTC (permalink / raw)
To: gregkh; +Cc: paskripkin, linux-kernel, linux-staging, larry.finger, phil
On Tuesday, September 7, 2021 8:56:52 AM CEST gregkh@linuxfoundation.org
wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> staging: r8188eu: Remove _enter/_exit_critical_mutex()
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> in the staging-testing branch.
>
> The patch will show up in the next release of the linux-next tree
> (usually sometime within the next 24 hours during the week.)
>
> The patch will be merged to the staging-next branch sometime soon,
> after it passes testing, and the merge window is open.
>
> If you have any questions about this process, please let me know.
>
>
> From d3c6dfb00bd9fe75f3a44246d6db7991f6443bac Mon Sep 17 00:00:00 2001
> From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> Date: Sat, 28 Aug 2021 13:36:56 +0200
> Subject: staging: r8188eu: Remove _enter/_exit_critical_mutex()
>
> Remove _enter_critical_mutex() and _exit_critical_mutex(). They are
> unnecessary wrappers, respectively to mutex_lock_interruptible() and
> to mutex_unlock(). They also have an odd interface that takes an unused
> argument named pirqL of type unsigned long.
> The original code enters the critical section if the mutex API is
> interrupted while waiting to acquire the lock; therefore it could lead
> to a race condition. Use mutex_lock() because it is uninterruptible and
> so avoid that above-mentioned potential race condition.
Dear Greg,
I've just read this message. Thank you for applying my patch. I really
appreciated that you trust the code :)
Unfortunately it makes me wonder if I should have added a "Fixes:" tag
because it (among other things) prevents a (possible while remote - I guess)
bug. The code entered the critical section if the sleeping of the
interruptible mutex were interrupted by signals and so it could lead to race
conditions.
I have this doubt. Please let me know if I'd better redo the commit message
and add the above-mentioned tag.
Thanks,
Fabio
> Tested-by: Pavel Skripkin <paskripkin@gmail.com>
> Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Link: https://lore.kernel.org/r/20210828113656.6963-1-fmdefrancesco@gmail.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++--
> drivers/staging/r8188eu/hal/usb_ops_linux.c | 4 ++--
> drivers/staging/r8188eu/include/osdep_service.h | 13 -------------
> drivers/staging/r8188eu/os_dep/os_intfs.c | 4 ++--
> 4 files changed, 6 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: patch "staging: r8188eu: Remove _enter/_exit_critical_mutex()" added to staging-testing
2021-09-07 9:00 ` patch "staging: r8188eu: Remove _enter/_exit_critical_mutex()" added to staging-testing Fabio M. De Francesco
@ 2021-09-07 10:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-09-07 10:08 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: paskripkin, linux-kernel, linux-staging, larry.finger, phil
On Tue, Sep 07, 2021 at 11:00:28AM +0200, Fabio M. De Francesco wrote:
> On Tuesday, September 7, 2021 8:56:52 AM CEST gregkh@linuxfoundation.org
> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > staging: r8188eu: Remove _enter/_exit_critical_mutex()
> >
> > to my staging git tree which can be found at
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > in the staging-testing branch.
> >
> > The patch will show up in the next release of the linux-next tree
> > (usually sometime within the next 24 hours during the week.)
> >
> > The patch will be merged to the staging-next branch sometime soon,
> > after it passes testing, and the merge window is open.
> >
> > If you have any questions about this process, please let me know.
> >
> >
> > From d3c6dfb00bd9fe75f3a44246d6db7991f6443bac Mon Sep 17 00:00:00 2001
> > From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> > Date: Sat, 28 Aug 2021 13:36:56 +0200
> > Subject: staging: r8188eu: Remove _enter/_exit_critical_mutex()
> >
> > Remove _enter_critical_mutex() and _exit_critical_mutex(). They are
> > unnecessary wrappers, respectively to mutex_lock_interruptible() and
> > to mutex_unlock(). They also have an odd interface that takes an unused
> > argument named pirqL of type unsigned long.
> > The original code enters the critical section if the mutex API is
> > interrupted while waiting to acquire the lock; therefore it could lead
> > to a race condition. Use mutex_lock() because it is uninterruptible and
> > so avoid that above-mentioned potential race condition.
>
> Dear Greg,
>
> I've just read this message. Thank you for applying my patch. I really
> appreciated that you trust the code :)
>
> Unfortunately it makes me wonder if I should have added a "Fixes:" tag
> because it (among other things) prevents a (possible while remote - I guess)
> bug. The code entered the critical section if the sleeping of the
> interruptible mutex were interrupted by signals and so it could lead to race
> conditions.
>
> I have this doubt. Please let me know if I'd better redo the commit message
> and add the above-mentioned tag.
Given the mess that is this driver right now, no, that's not needed at
all. Only worry about that when you are fixing a real issue that should
be backported to older kernel releases.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-07 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1630997812180231@kroah.com>
2021-09-07 9:00 ` patch "staging: r8188eu: Remove _enter/_exit_critical_mutex()" added to staging-testing Fabio M. De Francesco
2021-09-07 10:08 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.