From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Martin Kepplinger <martin.kepplinger@puri.sm> Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, mchehab@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: imx: set a media_device bus_info string Date: Thu, 9 Sep 2021 01:37:11 +0300 [thread overview] Message-ID: <YTk7F+UTZmpeXzHj@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210908084746.243359-1-martin.kepplinger@puri.sm> Hi Martin, Thank you for the patch. On Wed, Sep 08, 2021 at 10:47:46AM +0200, Martin Kepplinger wrote: > some tools like v4l2-compliance let users select a media device based s/some/Some/ I'll fix then when applying the patch to my tree. > on the bus_info string which can be quite convenient. Use a unique > string for that. > > This also fixes the following v4l2-compliance warning: > warn: v4l2-test-media.cpp(52): empty bus_info > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/staging/media/imx/imx-media-dev-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c > index d006e961d8f4..80b69a9a752c 100644 > --- a/drivers/staging/media/imx/imx-media-dev-common.c > +++ b/drivers/staging/media/imx/imx-media-dev-common.c > @@ -367,6 +367,8 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev, > imxmd->v4l2_dev.notify = imx_media_notify; > strscpy(imxmd->v4l2_dev.name, "imx-media", > sizeof(imxmd->v4l2_dev.name)); > + snprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info), > + "platform:%s", dev_name(imxmd->md.dev)); > > media_device_init(&imxmd->md); > -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Martin Kepplinger <martin.kepplinger@puri.sm> Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, mchehab@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: imx: set a media_device bus_info string Date: Thu, 9 Sep 2021 01:37:11 +0300 [thread overview] Message-ID: <YTk7F+UTZmpeXzHj@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210908084746.243359-1-martin.kepplinger@puri.sm> Hi Martin, Thank you for the patch. On Wed, Sep 08, 2021 at 10:47:46AM +0200, Martin Kepplinger wrote: > some tools like v4l2-compliance let users select a media device based s/some/Some/ I'll fix then when applying the patch to my tree. > on the bus_info string which can be quite convenient. Use a unique > string for that. > > This also fixes the following v4l2-compliance warning: > warn: v4l2-test-media.cpp(52): empty bus_info > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/staging/media/imx/imx-media-dev-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c > index d006e961d8f4..80b69a9a752c 100644 > --- a/drivers/staging/media/imx/imx-media-dev-common.c > +++ b/drivers/staging/media/imx/imx-media-dev-common.c > @@ -367,6 +367,8 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev, > imxmd->v4l2_dev.notify = imx_media_notify; > strscpy(imxmd->v4l2_dev.name, "imx-media", > sizeof(imxmd->v4l2_dev.name)); > + snprintf(imxmd->md.bus_info, sizeof(imxmd->md.bus_info), > + "platform:%s", dev_name(imxmd->md.dev)); > > media_device_init(&imxmd->md); > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-08 22:43 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-08 8:47 [PATCH] media: imx: set a media_device bus_info string Martin Kepplinger 2021-09-08 8:47 ` Martin Kepplinger 2021-09-08 22:37 ` Laurent Pinchart [this message] 2021-09-08 22:37 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YTk7F+UTZmpeXzHj@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=martin.kepplinger@puri.sm \ --cc=mchehab@kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=slongerbeam@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.