From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7915: fix WMM index on DBDC cards
Date: Thu, 9 Sep 2021 10:10:16 +0200 [thread overview]
Message-ID: <YTnBaNe0jA+rFUV+@lore-desk> (raw)
In-Reply-To: <20210908155841.72052-1-nbd@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
> WMM index range needs to be split between both PHYs if a second PHY exists.
> The condition for that was accidentally written as checking if the vif PHY
> is the secondary one
We need to add the following Fixes tag here:
Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Regards,
Lorenzo
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> index 748ea70ea12e..a19e68668c65 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> @@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
> mvif->phy = phy;
> mvif->band_idx = ext_phy;
>
> - if (ext_phy)
> + if (dev->mt76.phy2)
> mvif->wmm_idx = ext_phy * (MT7915_MAX_WMM_SETS / 2) +
> mvif->idx % (MT7915_MAX_WMM_SETS / 2);
> else
> --
> 2.30.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-09-09 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:58 [PATCH] mt76: mt7915: fix WMM index on DBDC cards Felix Fietkau
2021-09-09 8:10 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTnBaNe0jA+rFUV+@lore-desk \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.