* [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions
@ 2021-09-13 14:31 Simon Trimmer
2021-09-13 16:27 ` Pierre-Louis Bossart
2021-09-14 5:27 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Simon Trimmer @ 2021-09-13 14:31 UTC (permalink / raw)
To: alsa-devel
Cc: patches, Simon Trimmer, pierre-louis.bossart, vkoul,
sanyog.r.kale, yung-chuan.liao
The patch "soundwire: export sdw_write/read_no_pm functions" exposed the
single byte no_pm versions of the IO functions that can be used without
touching PM, export the multi byte no_pm versions for the same reason.
Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
---
drivers/soundwire/bus.c | 8 ++++----
include/linux/soundwire/sdw.h | 2 ++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 1b115734a8f6..859de302dee2 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -379,8 +379,7 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
* all clients need to use the pm versions
*/
-static int
-sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
+int sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
{
struct sdw_msg msg;
int ret;
@@ -395,9 +394,9 @@ sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
ret = 0;
return ret;
}
+EXPORT_SYMBOL(sdw_nread_no_pm);
-static int
-sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
+int sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
{
struct sdw_msg msg;
int ret;
@@ -412,6 +411,7 @@ sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
ret = 0;
return ret;
}
+EXPORT_SYMBOL(sdw_nwrite_no_pm);
int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
{
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index 76ce3f3ac0f2..2a5395f0dcf1 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux/soundwire/sdw.h
@@ -1042,7 +1042,9 @@ int sdw_write(struct sdw_slave *slave, u32 addr, u8 value);
int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value);
int sdw_read_no_pm(struct sdw_slave *slave, u32 addr);
int sdw_nread(struct sdw_slave *slave, u32 addr, size_t count, u8 *val);
+int sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val);
int sdw_nwrite(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val);
+int sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val);
int sdw_update(struct sdw_slave *slave, u32 addr, u8 mask, u8 val);
int sdw_update_no_pm(struct sdw_slave *slave, u32 addr, u8 mask, u8 val);
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions
2021-09-13 14:31 [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions Simon Trimmer
@ 2021-09-13 16:27 ` Pierre-Louis Bossart
2021-09-14 5:27 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2021-09-13 16:27 UTC (permalink / raw)
To: Simon Trimmer, alsa-devel; +Cc: patches, vkoul, yung-chuan.liao, sanyog.r.kale
On 9/13/21 9:31 AM, Simon Trimmer wrote:
> The patch "soundwire: export sdw_write/read_no_pm functions" exposed the
> single byte no_pm versions of the IO functions that can be used without
> touching PM, export the multi byte no_pm versions for the same reason.
>
> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Makes sense to me, e.g. if a codec driver needs to read/write
vendor-specific registers that are not managed with regmap - interrupts
or masks.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/bus.c | 8 ++++----
> include/linux/soundwire/sdw.h | 2 ++
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 1b115734a8f6..859de302dee2 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -379,8 +379,7 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
> * all clients need to use the pm versions
> */
>
> -static int
> -sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
> +int sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
> {
> struct sdw_msg msg;
> int ret;
> @@ -395,9 +394,9 @@ sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
> ret = 0;
> return ret;
> }
> +EXPORT_SYMBOL(sdw_nread_no_pm);
>
> -static int
> -sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
> +int sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
> {
> struct sdw_msg msg;
> int ret;
> @@ -412,6 +411,7 @@ sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val)
> ret = 0;
> return ret;
> }
> +EXPORT_SYMBOL(sdw_nwrite_no_pm);
>
> int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
> {
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index 76ce3f3ac0f2..2a5395f0dcf1 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -1042,7 +1042,9 @@ int sdw_write(struct sdw_slave *slave, u32 addr, u8 value);
> int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value);
> int sdw_read_no_pm(struct sdw_slave *slave, u32 addr);
> int sdw_nread(struct sdw_slave *slave, u32 addr, size_t count, u8 *val);
> +int sdw_nread_no_pm(struct sdw_slave *slave, u32 addr, size_t count, u8 *val);
> int sdw_nwrite(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val);
> +int sdw_nwrite_no_pm(struct sdw_slave *slave, u32 addr, size_t count, const u8 *val);
> int sdw_update(struct sdw_slave *slave, u32 addr, u8 mask, u8 val);
> int sdw_update_no_pm(struct sdw_slave *slave, u32 addr, u8 mask, u8 val);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions
2021-09-13 14:31 [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions Simon Trimmer
2021-09-13 16:27 ` Pierre-Louis Bossart
@ 2021-09-14 5:27 ` Vinod Koul
2021-09-14 8:39 ` Richard Fitzgerald
1 sibling, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2021-09-14 5:27 UTC (permalink / raw)
To: Simon Trimmer
Cc: sanyog.r.kale, alsa-devel, yung-chuan.liao, pierre-louis.bossart,
patches
On 13-09-21, 15:31, Simon Trimmer wrote:
> The patch "soundwire: export sdw_write/read_no_pm functions" exposed the
> single byte no_pm versions of the IO functions that can be used without
> touching PM, export the multi byte no_pm versions for the same reason.
That sounds okay to me, but how about the users for this API..?
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions
2021-09-14 5:27 ` Vinod Koul
@ 2021-09-14 8:39 ` Richard Fitzgerald
0 siblings, 0 replies; 4+ messages in thread
From: Richard Fitzgerald @ 2021-09-14 8:39 UTC (permalink / raw)
To: Vinod Koul, Simon Trimmer
Cc: patches, sanyog.r.kale, yung-chuan.liao, alsa-devel,
pierre-louis.bossart
> On 13-09-21, 15:31, Simon Trimmer wrote:
>> The patch "soundwire: export sdw_write/read_no_pm functions" exposed the
>> single byte no_pm versions of the IO functions that can be used without
>> touching PM, export the multi byte no_pm versions for the same reason.
>
> That sounds okay to me, but how about the users for this API..?
>
In development.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-14 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 14:31 [PATCH] soundwire: export sdw_nwrite_no_pm and sdw_nread_no_pm functions Simon Trimmer
2021-09-13 16:27 ` Pierre-Louis Bossart
2021-09-14 5:27 ` Vinod Koul
2021-09-14 8:39 ` Richard Fitzgerald
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.